opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-05 08:48:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix(dataset): retry failed New RAG document processing"

Browse Source 
This reverts commit 3bca4b3485.
This commit is contained in:
Stephen Zhou 2026-07-30 20:37:15 +08:00
parent bf5f916cd4
commit 29602d261c
No known key found for this signature in database
2 changed files with 0 additions and 88 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
web/features/new-rag/__tests__/documents-page.spec.tsx
View File

@ -780,65 +780,6 @@ describe('DocumentsPage', () => {
)
})
it('retries failed initial processing from a document row action', async () => {
const user = userEvent.setup()
documentsQuery.data = {
pages: [
{
items: [
document({
active: null,
activeRevision: undefined,
id: 'failed-document',
status: 'failed',
title: 'Failed.pdf',
}),
],
},
],
}
tasksQuery.data = {
pages: [
{
items: [
task({
documentId: 'failed-document',
documentRevision: 1,
id: 'failed-task',
state: 'failed',
}),
],
},
],
}
render(<DocumentsPage knowledgeSpaceId="space-1" />)
await user.click(
screen.getByRole('button', {
name: /dataset\.newKnowledge\.documentActions/,
}),
)
await user.click(
await screen.findByRole('menuitem', {
name: 'dataset.newKnowledge.reindexDocument',
}),
)
expect(retryMutation.mutateAsync).toHaveBeenCalledWith({
params: {
control_space_id: 'space-1',
task_id: 'failed-task',
task_kind: 'document',
},
})
expect(reindexMutation.mutateAsync).not.toHaveBeenCalled()
await waitFor(() =>
expect(toastMock.success).toHaveBeenCalledWith(
'dataset.newKnowledge.documentsReindexStarted',
),
)
})
it('opens the upload form and consumes the one-shot URL request', async () => {
const user = userEvent.setup()
const { onUrlUpdate } = render(<DocumentsPage knowledgeSpaceId="space-1" />, {

29
web/features/new-rag/documents-page.tsx
View File

@ -39,7 +39,6 @@ import {
documentDisplayStatus,
newestTaskByDocument,
sourceName,
taskCanRetry,
taskIsActive,
taskNeedsAttention,
taskVersionIsAfter,
@ -280,23 +279,6 @@ export function DocumentsPage({ knowledgeSpaceId }: { knowledgeSpaceId: string }
const { mutateAsync: reindexDocuments } = useMutation(
consoleQuery.knowledgeFs.spaces.byControlSpaceId.documents.reindex.post.mutationOptions(),
)
const { mutateAsync: retryProcessingTask } = useMutation({
mutationFn: async (task: DocumentProcessingTask) => {
const updated = documentTaskFromApi(
await consoleClient.knowledgeFs.spaces.byControlSpaceId.backgroundTasks.byTaskKind.byTaskId.retry.post(
{
params: {
control_space_id: knowledgeSpaceId,
task_id: task.id,
task_kind: task.taskKind ?? 'document',
},
},
),
)
if (!updated) throw new Error('KnowledgeFS returned a non-document task')
return updated
},
})
const {
configureModelSetup,
ensureModelSetupReady,
@ -1640,14 +1622,6 @@ export function DocumentsPage({ knowledgeSpaceId }: { knowledgeSpaceId: string }
setReindexing(true)
try {
if (!(await ensureModelSetupReady())) return
const document = documents.find((candidate) => candidate.id === documentId)
const retryableTask = document?.active ? undefined : taskByDocument.get(documentId)
if (retryableTask && taskCanRetry(retryableTask)) {
await retryProcessingTask(retryableTask)
toast.success(t(($) => $['newKnowledge.documentsReindexStarted']))
refreshDocumentsAndTasks()
return
}
const result = await reindexDocuments({
body: { documentIds: [documentId] },
params: { control_space_id: knowledgeSpaceId },
@ -1671,15 +1645,12 @@ export function DocumentsPage({ knowledgeSpaceId }: { knowledgeSpaceId: string }
},
[
canWrite,
documents,
ensureModelSetupReady,
handleWritePermissionDenied,
knowledgeSpaceId,
refreshDocumentsAndTasks,
reindexDocuments,
retryProcessingTask,
t,
taskByDocument,
],
)