diff --git a/web/features/new-rag/__tests__/quality-evaluation-panel.spec.tsx b/web/features/new-rag/__tests__/quality-evaluation-panel.spec.tsx index 37776fc151b..96e12a95e84 100644 --- a/web/features/new-rag/__tests__/quality-evaluation-panel.spec.tsx +++ b/web/features/new-rag/__tests__/quality-evaluation-panel.spec.tsx @@ -235,7 +235,7 @@ describe('QualityEvaluationPanel', () => { '-translate-y-1/2', ) expect(dialog).toHaveAccessibleDescription( - 'dataset.newKnowledge.qualityPage.evaluation.dialogDescription:{"count":6}', + 'dataset.newKnowledge.qualityPage.evaluation.dialogDescription_other:{"count":6}', ) expect( screen.getByRole('radio', { @@ -245,6 +245,30 @@ describe('QualityEvaluationPanel', () => { expect(screen.getAllByRole('radio')).toHaveLength(3) }) + it('uses singular copy for one active golden question', async () => { + const user = userEvent.setup() + serviceMock.listGoldenQuestions.mockResolvedValue({ + data: [{ id: 'golden-1', status: 'active' }], + next_cursor: null, + }) + renderPanel() + + await screen.findByText('dataset.newKnowledge.qualityPage.evaluation.emptyTitle') + await user.click( + screen.getByRole('button', { + name: 'dataset.newKnowledge.qualityPage.evaluation.run', + }), + ) + + expect( + screen.getByRole('dialog', { + name: 'dataset.newKnowledge.qualityPage.evaluation.dialogTitle', + }), + ).toHaveAccessibleDescription( + 'dataset.newKnowledge.qualityPage.evaluation.dialogDescription_one:{"count":1}', + ) + }) + it('queues every active golden question and opens the persisted evidence report', async () => { const user = userEvent.setup() renderPanel() diff --git a/web/features/new-rag/quality/quality-evaluation-panel.tsx b/web/features/new-rag/quality/quality-evaluation-panel.tsx index 2e0d630d1fc..dbdb3057e37 100644 --- a/web/features/new-rag/quality/quality-evaluation-panel.tsx +++ b/web/features/new-rag/quality/quality-evaluation-panel.tsx @@ -583,9 +583,15 @@ export function QualityEvaluationPanel({ {t(($) => $['newKnowledge.qualityPage.evaluation.dialogTitle'])} - {t(($) => $['newKnowledge.qualityPage.evaluation.dialogDescription'], { - count: activeGoldenQuestionCount, - })} + {t( + ($) => + $[ + activeGoldenQuestionCount === 1 + ? 'newKnowledge.qualityPage.evaluation.dialogDescription_one' + : 'newKnowledge.qualityPage.evaluation.dialogDescription_other' + ], + { count: activeGoldenQuestionCount }, + )}