opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-07-20 18:18:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: CI issues - use lazy logging and remove duplicate class definitions

Browse Source
This commit is contained in:
Kailun Wang 2025-11-29 18:29:05 -05:00
parent c1b914ee7c
commit 7be966b775
2 changed files with 3 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
api/controllers/console/workspace/plugin.py
View File

@ -826,29 +826,3 @@ class PluginReadmeApi(Resource):
return jsonable_encoder(
{"readme": PluginService.fetch_plugin_readme(tenant_id, args.plugin_unique_identifier, args.language)}
)
class ParserUninstall(BaseModel):
plugin_installation_id: str = Field(..., description="Plugin installation ID")
console_ns.schema_model(
ParserUninstall.__name__, ParserUninstall.model_json_schema(ref_template=DEFAULT_REF_TEMPLATE_SWAGGER_2_0)
)
@console_ns.route("/workspaces/current/plugin/uninstall")
class PluginUninstallApi(Resource):
@console_ns.expect(console_ns.models[ParserUninstall.__name__])
@setup_required
@login_required
@account_initialization_required
@plugin_permission_required(install_required=True)
def post(self):
_, tenant_id = current_account_with_tenant()
args = ParserUninstall.model_validate(console_ns.payload)
try:
return {"success": PluginService.uninstall(tenant_id, args.plugin_installation_id)}
except PluginDaemonClientSideError as e:
raise ValueError(e)

6
api/services/plugin/plugin_service.py
View File

@ -518,7 +518,7 @@ class PluginService:
if plugin:
plugin_id = plugin.plugin_id
logger.info(f"Deleting credentials for plugin: {plugin_id}")
logger.info("Deleting credentials for plugin: %s", plugin_id)
# Delete provider credentials that match this plugin
credentials = db.session.scalars(
@ -532,9 +532,9 @@ class PluginService:
db.session.delete(cred)
db.session.commit()
logger.info(f"Deleted {len(credentials)} credentials for plugin: {plugin_id}")
logger.info("Deleted %d credentials for plugin: %s", len(credentials), plugin_id)
except Exception as e:
logger.warning(f"Failed to delete credentials: {e}")
logger.warning("Failed to delete credentials: %s", e)
# Continue with uninstall even if credential deletion fails
return manager.uninstall(tenant_id, plugin_installation_id)