opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-08 02:43:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): remove only-me resource access option (#40956)

Browse Source
This commit is contained in:
Wu Tianwei 2026-08-19 02:50:07 +00:00 committed by GitHub
parent b78a3462c9
commit 8a33a9adb5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/app/components/access-rules-editor/__tests__/index.spec.tsx
View File

@ -143,15 +143,12 @@ describe('AccessRulesEditor', () => {
const allMembersButton = screen.getByRole('button', {
name: /permission\.accessRule\.allPermittedMembers/,
})
const onlyMeButton = screen.getByRole('button', { name: /permission\.accessRule\.onlyMe/ })
const specificMembersButton = screen.getByRole('button', {
name: /permission\.accessRule\.specificMembersOnly/,
})
expect(allMembersButton).toBeDisabled()
expect(onlyMeButton).toBeDisabled()
expect(specificMembersButton).toBeDisabled()
expect(allMembersButton).toHaveAttribute('aria-pressed', 'false')
expect(onlyMeButton).toHaveAttribute('aria-pressed', 'false')
expect(specificMembersButton).toHaveAttribute('aria-pressed', 'false')
})
@ -201,7 +198,7 @@ describe('AccessRulesEditor', () => {
expect(onRemoveAccessPolicyMemberBinding).toHaveBeenCalledWith('account-1', 'app-policy-id')
})
it('should render and update the only-me resource access scope', () => {
it('should hide the only-me option and allow changing a legacy only-me scope', () => {
const onOpenScopeChange = vi.fn()
render(
@ -217,10 +214,9 @@ describe('AccessRulesEditor', () => {
/>,
)
expect(screen.getByRole('button', { name: /permission\.accessRule\.onlyMe/ })).toHaveAttribute(
'aria-pressed',
'true',
)
expect(
screen.queryByRole('button', { name: /permission\.accessRule\.onlyMe/ }),
).not.toBeInTheDocument()
fireEvent.click(
screen.getByRole('button', { name: /permission\.accessRule\.specificMembersOnly/ }),

10
web/app/components/access-rules-editor/open-scope-section.tsx
View File

@ -48,7 +48,7 @@ function ResourceOpenScopeSection({ value, disabled, onChange }: ResourceOpenSco
</h2>
<TitleInfotip content={resourceOpenScopeDescription} />
</div>
<div className="grid grid-cols-1 gap-2 sm:grid-cols-3">
<div className="grid grid-cols-1 gap-2 sm:grid-cols-2">
<OpenScopeOption
value="all"
selected={value === 'all'}
@ -59,14 +59,6 @@ function ResourceOpenScopeSection({ value, disabled, onChange }: ResourceOpenSco
})}
onChange={onChange ? handleRequestChange : undefined}
/>
<OpenScopeOption
value="only_me"
selected={value === 'only_me'}
disabled={disabled || !onChange}
title={t(($) => $['accessRule.onlyMe'], { ns: 'permission' })}
description={t(($) => $['accessRule.onlyMeDescription'], { ns: 'permission' })}
onChange={onChange ? handleRequestChange : undefined}
/>
<OpenScopeOption
value="specific"
selected={value === 'specific'}