From a562d9517bb0850fdb0b2a9ad57fb48b7474d024 Mon Sep 17 00:00:00 2001 From: Stephen Zhou <38493346+hyoban@users.noreply.github.com> Date: Tue, 25 Aug 2026 17:42:23 +0800 Subject: [PATCH] fix(knowledge_fs): use supported research intent in threshold test --- ...-25-research-score-threshold-test-intent.md | 18 ++++++++++++++++++ .../src/research-evidence-retrieval.test.ts | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 knowledge-fs/.harness/changes/2026-08-25-research-score-threshold-test-intent.md diff --git a/knowledge-fs/.harness/changes/2026-08-25-research-score-threshold-test-intent.md b/knowledge-fs/.harness/changes/2026-08-25-research-score-threshold-test-intent.md new file mode 100644 index 00000000000..afd33531439 --- /dev/null +++ b/knowledge-fs/.harness/changes/2026-08-25-research-score-threshold-test-intent.md @@ -0,0 +1,18 @@ +# Research score-threshold test intent + +## What changed + +- Updated the score-threshold retrieval test plan to use the supported `direct` research intent. + +## Why + +- The test fixture used the removed `lookup` intent, causing the KnowledgeFS API TypeScript gate to fail. + +## Verification + +- `pnpm --filter @knowledge/api typecheck` +- `pnpm --filter @knowledge/api test -- research-evidence-retrieval.test.ts` + +## Risks and follow-up + +- No production behavior changed; this only aligns the test fixture with the production query-plan contract. diff --git a/knowledge-fs/packages/api/src/research-evidence-retrieval.test.ts b/knowledge-fs/packages/api/src/research-evidence-retrieval.test.ts index 74ee2594ca2..cee21b0bfba 100644 --- a/knowledge-fs/packages/api/src/research-evidence-retrieval.test.ts +++ b/knowledge-fs/packages/api/src/research-evidence-retrieval.test.ts @@ -183,7 +183,7 @@ describe("Research evidence retrieval V3", () => { }), plan: async () => ({ evidenceDimensions: ["renewal"], - intent: "lookup" as const, + intent: "direct" as const, modelCalled: true, subqueries: [], useGraph: false,