From b95d0f47432e1950cbc32f9e418ab00844da318e Mon Sep 17 00:00:00 2001
From: Stephen Zhou <38493346+hyoban@users.noreply.github.com>
Date: Tue, 18 Aug 2026 15:20:33 +0800
Subject: [PATCH] fix(web): remove knowledge sidebar retrieval mode

---
 .../__tests__/knowledge-space-shell.spec.tsx  | 18 ++------
 .../new-rag/knowledge-space-shell.tsx         | 43 +------------------
 2 files changed, 4 insertions(+), 57 deletions(-)

diff --git a/web/features/new-rag/__tests__/knowledge-space-shell.spec.tsx b/web/features/new-rag/__tests__/knowledge-space-shell.spec.tsx
index fab2b9d3820..fd0bf926b20 100644
--- a/web/features/new-rag/__tests__/knowledge-space-shell.spec.tsx
+++ b/web/features/new-rag/__tests__/knowledge-space-shell.spec.tsx
@@ -188,7 +188,9 @@ describe('KnowledgeSpaceShell', () => {
     )
 
     expect(screen.getByRole('heading', { name: 'Support knowledge' })).toBeInTheDocument()
-    expect(screen.getByText('dataset.newKnowledge.settings.retrievalMode.fast')).toBeInTheDocument()
+    expect(
+      screen.queryByText('dataset.newKnowledge.settings.retrievalMode.fast'),
+    ).not.toBeInTheDocument()
     expect(screen.queryByText('text-embedding-3-large')).not.toBeInTheDocument()
     expect(screen.getByRole('link', { name: 'common.mainNav.home' })).toHaveAttribute('href', '/')
     expect(screen.getByRole('link', { name: 'dataset.knowledge' })).toHaveAttribute(
@@ -269,20 +271,6 @@ describe('KnowledgeSpaceShell', () => {
     )
   })
 
-  it('does not invent sidebar metadata when the summary profile is unavailable', () => {
-    queryMock.data = {
-      control_space_id: 'space-1',
-      state: 'active',
-      technical_summary: { name: 'Support knowledge' },
-    }
-
-    render(<KnowledgeSpaceShell knowledgeSpaceId="space-1">source content</KnowledgeSpaceShell>)
-
-    expect(
-      screen.queryByText('dataset.newKnowledge.settings.retrievalMode.fast'),
-    ).not.toBeInTheDocument()
-  })
-
   it('marks settings as the current navigation item', () => {
     pathnameMock.value = '/datasets/new/space-1/settings'
     queryMock.data = {
diff --git a/web/features/new-rag/knowledge-space-shell.tsx b/web/features/new-rag/knowledge-space-shell.tsx
index 4880d509320..bd9db1d9847 100644
--- a/web/features/new-rag/knowledge-space-shell.tsx
+++ b/web/features/new-rag/knowledge-space-shell.tsx
@@ -36,38 +36,6 @@ function responseStatus(error: unknown) {
   }
 }
 
-function recordProperty(value: unknown, key: string) {
-  if (!value || typeof value !== 'object' || Array.isArray(value)) return
-
-  const property = (value as Record<string, unknown>)[key]
-  if (!property || typeof property !== 'object' || Array.isArray(property)) return
-
-  return property as Record<string, unknown>
-}
-
-function stringProperty(value: unknown, ...keys: string[]) {
-  if (!value || typeof value !== 'object' || Array.isArray(value)) return
-
-  for (const key of keys) {
-    const property = (value as Record<string, unknown>)[key]
-    if (typeof property === 'string' && property.length > 0) return property
-  }
-}
-
-function retrievalModeFromProfile(modelProfile: unknown) {
-  const pendingConfiguration =
-    recordProperty(modelProfile, 'pendingModelConfiguration') ??
-    recordProperty(modelProfile, 'pending_model_configuration')
-  const retrievalProfile =
-    recordProperty(modelProfile, 'retrievalProfile') ??
-    recordProperty(modelProfile, 'retrieval_profile') ??
-    recordProperty(pendingConfiguration, 'retrievalProfile') ??
-    recordProperty(pendingConfiguration, 'retrieval_profile')
-  const mode = stringProperty(retrievalProfile, 'defaultMode', 'default_mode')
-
-  if (mode === 'deep' || mode === 'fast' || mode === 'research') return mode
-}
-
 const knowledgeSpacePageTitle = (
   pathname: string,
   t: ReturnType<typeof useTranslation<'dataset'>>['t'],
@@ -139,8 +107,6 @@ export function KnowledgeSpaceShell({
     externalAccessQuery.data.agent_enabled === true
   const knowledgeSpaceName =
     knowledgeSpaceQuery.data?.technical_summary?.name ?? t(($) => $.knowledge)
-  const modelProfile = knowledgeSpaceQuery.data?.technical_summary?.model_profile
-  const retrievalMode = retrievalModeFromProfile(modelProfile)
   const pageTitle = knowledgeSpacePageTitle(pathname, t, tCommon)
   const documentTitle = `${pageTitle} · ${knowledgeSpaceName}`
   const documentTitleOwnedByChild =
@@ -296,17 +262,10 @@ export function KnowledgeSpaceShell({
                 size="medium"
               />
               {sidebarExpanded && (
-                <div className="flex min-w-0 flex-1 flex-col gap-0.5">
+                <div className="flex min-w-0 flex-1">
                   <h1 className="truncate system-md-semibold text-text-secondary">
                     {knowledgeSpaceName}
                   </h1>
-                  {retrievalMode && (
-                    <div className="flex min-w-0 items-center gap-2 system-2xs-medium-uppercase text-text-tertiary">
-                      <span className="truncate">
-                        {t(($) => $[`newKnowledge.settings.retrievalMode.${retrievalMode}`])}
-                      </span>
-                    </div>
-                  )}
                 </div>
               )}
             </div>