opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-08 02:43:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(web): migrate dataset settings input (#41277)

Browse Source
This commit is contained in:
yyh 2026-08-26 04:44:51 +00:00 committed by GitHub
parent e4cd2c72ad
commit b9ac4d3cb1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
oxlint-suppressions.json
View File

@ -2403,11 +2403,6 @@
"count": 1
}
},
"web/app/components/datasets/settings/form/components/basic-info-section.tsx": {
"no-restricted-imports": {
"count": 1
}
},
"web/app/components/datasets/settings/option-card.tsx": {
"jsx-a11y/click-events-have-key-events": {
"count": 1

12
web/app/components/datasets/settings/form/components/__tests__/basic-info-section.spec.tsx
View File

@ -202,8 +202,11 @@ describe('BasicInfoSection', () => {
it('should render name input with correct value', () => {
render(<BasicInfoSection {...defaultProps} />)
const nameInput = screen.getByDisplayValue('Test Dataset')
const nameInput = screen.getByRole('textbox', {
name: 'datasetSettings.form.name',
})
expect(nameInput)!.toBeInTheDocument()
expect(nameInput).toHaveValue('Test Dataset')
})
it('should render description textarea with correct value', () => {
@ -225,7 +228,9 @@ describe('BasicInfoSection', () => {
const setName = vi.fn()
render(<BasicInfoSection {...defaultProps} setName={setName} />)
const nameInput = screen.getByDisplayValue('Test Dataset')
const nameInput = screen.getByRole('textbox', {
name: 'datasetSettings.form.name',
})
fireEvent.change(nameInput, { target: { value: 'New Name' } })
expect(setName).toHaveBeenCalledWith('New Name')
@ -457,8 +462,7 @@ describe('BasicInfoSection', () => {
it('should have accessible name input', () => {
render(<BasicInfoSection {...defaultProps} />)
const nameInput = screen.getByDisplayValue('Test Dataset')
expect(nameInput.tagName.toLowerCase()).toBe('input')
expect(screen.getByRole('textbox', { name: 'datasetSettings.form.name' })).toBeInTheDocument()
})
it('should have accessible description textarea', () => {

5
web/app/components/datasets/settings/form/components/basic-info-section.tsx
View File

@ -3,11 +3,11 @@ import type { AppIconSelection } from '@/app/components/base/app-icon-picker'
import type { Member } from '@/models/common'
import type { DataSet, DatasetPermission, IconInfo } from '@/models/datasets'
import type { AppIconType } from '@/types/app'
import { Input } from '@langgenius/dify-ui/input'
import { Textarea } from '@langgenius/dify-ui/textarea'
import { useTranslation } from 'react-i18next'
import AppIcon from '@/app/components/base/app-icon'
import AppIconPicker from '@/app/components/base/app-icon-picker'
import Input from '@/app/components/base/input'
import PermissionSelector from '../../permission-selector'
const rowClass = 'flex gap-x-1'
@ -73,9 +73,10 @@ const BasicInfoSection = ({
showEditIcon={!readonly}
/>
<Input
aria-label={t(($) => $['form.name'], { ns: 'datasetSettings' })}
disabled={!currentDataset?.embedding_available || readonly}
value={name}
onChange={(e) => setName(e.target.value)}
onValueChange={(nextValue) => setName(nextValue)}
/>
</div>
</div>