chore: Replace @patch logger.warning with caplog fixture in credit_pool_service test (#38626)

This commit is contained in:
Dresden 2026-07-10 11:08:17 +08:00 committed by GitHub
parent 7da3d7074a
commit faba726a45
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -347,7 +347,9 @@ def test_check_and_deduct_credits_releases_billing_reservation_when_commit_fails
)
def test_check_and_deduct_credits_logs_when_billing_release_fails() -> None:
def test_check_and_deduct_credits_logs_when_billing_release_fails(
caplog: pytest.LogCaptureFixture,
) -> None:
with (
patch("services.credit_pool_service.dify_config.BILLING_ENABLED", True),
patch("services.billing_service.BillingService.quota_reserve") as quota_reserve,
@ -355,7 +357,6 @@ def test_check_and_deduct_credits_logs_when_billing_release_fails() -> None:
patch(
"services.billing_service.BillingService.quota_release", side_effect=RuntimeError("release failed")
) as quota_release,
patch("services.credit_pool_service.logger.warning") as logger_warning,
):
quota_reserve.return_value = {"reservation_id": "reservation-1", "available": 7, "reserved": 3}
@ -368,9 +369,9 @@ def test_check_and_deduct_credits_logs_when_billing_release_fails() -> None:
bucket="trial",
reservation_id="reservation-1",
)
logger_warning.assert_called_once()
assert logger_warning.call_args.args[3] == "reservation-1"
assert logger_warning.call_args.kwargs["exc_info"] is True
assert len(caplog.records) == 1
assert "reservation-1" in caplog.records[0].message
assert caplog.records[0].exc_info is not None
def test_deduct_credits_capped_uses_billing_consume_capped_when_enabled() -> None: