opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-06-07 16:32:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(api): enforce strict typing on retrieval_model to resolve FIXME (#34614)

Browse Source
This commit is contained in:
Pulakesh 2026-04-07 01:10:53 +00:00 committed by GitHub
parent 0bce6b35b4
commit 0feff5b048
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/services/hit_testing_service.py
View File

@ -44,7 +44,7 @@ class HitTestingService:
dataset: Dataset, dataset: Dataset,
query: str, query: str,
account: Account, account: Account,
retrieval_model: Any, # FIXME drop this any retrieval_model: dict | None,
external_retrieval_model: dict, external_retrieval_model: dict,
attachment_ids: list | None = None, attachment_ids: list | None = None,
limit: int = 10, limit: int = 10,
@ -54,6 +54,7 @@ class HitTestingService:
# get retrieval model , if the model is not setting , using default # get retrieval model , if the model is not setting , using default
if not retrieval_model: if not retrieval_model:
retrieval_model = dataset.retrieval_model or default_retrieval_model retrieval_model = dataset.retrieval_model or default_retrieval_model
assert isinstance(retrieval_model, dict)
document_ids_filter = None document_ids_filter = None
metadata_filtering_conditions = retrieval_model.get("metadata_filtering_conditions", {}) metadata_filtering_conditions = retrieval_model.get("metadata_filtering_conditions", {})
if metadata_filtering_conditions and query: if metadata_filtering_conditions and query: