From 106cb8e373b5d695b5810241ee32d3f1b096b9f3 Mon Sep 17 00:00:00 2001
From: yyh <yuanyouhuilyz@gmail.com>
Date: Fri, 16 Jan 2026 11:38:13 +0800
Subject: [PATCH] refactor(skill): unify node menu components with cva variants

Merge file-node-menu.tsx and folder-node-menu.tsx into a single
declarative NodeMenu component that uses type prop to determine
menu items. Add cva-based variant support to MenuItem for consistent
destructive styling.
---
 .../skill/file-tree/file-node-menu.tsx        |  87 ----------
 .../skill/file-tree/folder-node-menu.tsx      | 147 -----------------
 .../workflow/skill/file-tree/menu-item.tsx    |  61 +++++--
 .../workflow/skill/file-tree/node-menu.tsx    | 155 ++++++++++++++++++
 .../skill/file-tree/tree-context-menu.tsx     |  24 +--
 .../workflow/skill/file-tree/tree-node.tsx    |  21 +--
 6 files changed, 218 insertions(+), 277 deletions(-)
 delete mode 100644 web/app/components/workflow/skill/file-tree/file-node-menu.tsx
 delete mode 100644 web/app/components/workflow/skill/file-tree/folder-node-menu.tsx
 create mode 100644 web/app/components/workflow/skill/file-tree/node-menu.tsx

diff --git a/web/app/components/workflow/skill/file-tree/file-node-menu.tsx b/web/app/components/workflow/skill/file-tree/file-node-menu.tsx
deleted file mode 100644
index a8d85eaa90..0000000000
--- a/web/app/components/workflow/skill/file-tree/file-node-menu.tsx
+++ /dev/null
@@ -1,87 +0,0 @@
-'use client'
-
-import type { FC } from 'react'
-import type { NodeApi, TreeApi } from 'react-arborist'
-import type { TreeNodeData } from '../type'
-import {
-  RiDeleteBinLine,
-  RiEdit2Line,
-} from '@remixicon/react'
-import * as React from 'react'
-import { useTranslation } from 'react-i18next'
-import Confirm from '@/app/components/base/confirm'
-import { cn } from '@/utils/classnames'
-import { useFileOperations } from '../hooks/use-file-operations'
-import MenuItem from './menu-item'
-
-type FileItemMenuProps = {
-  nodeId?: string
-  onClose: () => void
-  className?: string
-  treeRef?: React.RefObject<TreeApi<TreeNodeData> | null>
-  node?: NodeApi<TreeNodeData>
-}
-
-const FileItemMenu: FC<FileItemMenuProps> = ({
-  nodeId,
-  onClose,
-  className,
-  treeRef,
-  node,
-}) => {
-  const { t } = useTranslation('workflow')
-
-  const {
-    showDeleteConfirm,
-    isLoading,
-    isDeleting,
-    handleRename,
-    handleDeleteClick,
-    handleDeleteConfirm,
-    handleDeleteCancel,
-  } = useFileOperations({ nodeId, onClose, treeRef, node })
-
-  return (
-    <div className={cn(
-      'min-w-[180px] rounded-xl border-[0.5px] border-components-panel-border',
-      'bg-components-panel-bg-blur p-1 shadow-lg backdrop-blur-[5px]',
-      className,
-    )}
-    >
-      <MenuItem
-        icon={RiEdit2Line}
-        label={t('skillSidebar.menu.rename')}
-        onClick={handleRename}
-        disabled={isLoading}
-      />
-      <button
-        type="button"
-        onClick={handleDeleteClick}
-        disabled={isLoading}
-        className={cn(
-          'flex w-full items-center gap-2 rounded-lg px-3 py-2',
-          'hover:bg-state-destructive-hover disabled:cursor-not-allowed disabled:opacity-50',
-          'focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-components-input-border-active',
-          'group',
-        )}
-      >
-        <RiDeleteBinLine className="size-4 text-text-tertiary group-hover:text-text-destructive" aria-hidden="true" />
-        <span className="system-sm-regular text-text-secondary group-hover:text-text-destructive">
-          {t('skillSidebar.menu.delete')}
-        </span>
-      </button>
-
-      <Confirm
-        isShow={showDeleteConfirm}
-        type="danger"
-        title={t('skillSidebar.menu.fileDeleteConfirmTitle')}
-        content={t('skillSidebar.menu.fileDeleteConfirmContent')}
-        onConfirm={handleDeleteConfirm}
-        onCancel={handleDeleteCancel}
-        isLoading={isDeleting}
-      />
-    </div>
-  )
-}
-
-export default React.memo(FileItemMenu)
diff --git a/web/app/components/workflow/skill/file-tree/folder-node-menu.tsx b/web/app/components/workflow/skill/file-tree/folder-node-menu.tsx
deleted file mode 100644
index 9dee1a6772..0000000000
--- a/web/app/components/workflow/skill/file-tree/folder-node-menu.tsx
+++ /dev/null
@@ -1,147 +0,0 @@
-'use client'
-
-import type { FC } from 'react'
-import type { NodeApi, TreeApi } from 'react-arborist'
-import type { TreeNodeData } from '../type'
-import {
-  RiDeleteBinLine,
-  RiEdit2Line,
-  RiFileAddLine,
-  RiFolderAddLine,
-  RiFolderUploadLine,
-  RiUploadLine,
-} from '@remixicon/react'
-import * as React from 'react'
-import { useTranslation } from 'react-i18next'
-import Confirm from '@/app/components/base/confirm'
-import { cn } from '@/utils/classnames'
-import { useFileOperations } from '../hooks/use-file-operations'
-import MenuItem from './menu-item'
-
-type FileOperationsMenuProps = {
-  nodeId?: string
-  onClose: () => void
-  className?: string
-  treeRef?: React.RefObject<TreeApi<TreeNodeData> | null>
-  node?: NodeApi<TreeNodeData>
-}
-
-const FileOperationsMenu: FC<FileOperationsMenuProps> = ({
-  nodeId,
-  onClose,
-  className,
-  treeRef,
-  node,
-}) => {
-  const { t } = useTranslation('workflow')
-
-  const {
-    fileInputRef,
-    folderInputRef,
-    showDeleteConfirm,
-    isLoading,
-    isDeleting,
-    handleNewFile,
-    handleNewFolder,
-    handleFileChange,
-    handleFolderChange,
-    handleRename,
-    handleDeleteClick,
-    handleDeleteConfirm,
-    handleDeleteCancel,
-  } = useFileOperations({ nodeId, onClose, treeRef, node })
-
-  return (
-    <div className={cn(
-      'min-w-[180px] rounded-xl border-[0.5px] border-components-panel-border',
-      'bg-components-panel-bg-blur p-1 shadow-lg backdrop-blur-[5px]',
-      className,
-    )}
-    >
-      <input
-        ref={fileInputRef}
-        type="file"
-        multiple
-        className="hidden"
-        onChange={handleFileChange}
-      />
-      <input
-        ref={folderInputRef}
-        type="file"
-        // @ts-expect-error webkitdirectory is a non-standard attribute
-        webkitdirectory=""
-        className="hidden"
-        onChange={handleFolderChange}
-      />
-
-      <MenuItem
-        icon={RiFileAddLine}
-        label={t('skillSidebar.menu.newFile')}
-        onClick={handleNewFile}
-        disabled={isLoading}
-      />
-      <MenuItem
-        icon={RiFolderAddLine}
-        label={t('skillSidebar.menu.newFolder')}
-        onClick={handleNewFolder}
-        disabled={isLoading}
-      />
-
-      <div className="my-1 h-px bg-divider-subtle" />
-
-      <MenuItem
-        icon={RiUploadLine}
-        label={t('skillSidebar.menu.uploadFile')}
-        onClick={() => fileInputRef.current?.click()}
-        disabled={isLoading}
-      />
-      <MenuItem
-        icon={RiFolderUploadLine}
-        label={t('skillSidebar.menu.uploadFolder')}
-        onClick={() => folderInputRef.current?.click()}
-        disabled={isLoading}
-      />
-
-      {nodeId !== 'root' && (
-        <>
-          <div className="my-1 h-px bg-divider-subtle" />
-
-          <MenuItem
-            icon={RiEdit2Line}
-            label={t('skillSidebar.menu.rename')}
-            onClick={handleRename}
-            disabled={isLoading}
-          />
-          <button
-            type="button"
-            onClick={handleDeleteClick}
-            disabled={isLoading}
-            className={cn(
-              'flex w-full items-center gap-2 rounded-lg px-3 py-2',
-              'hover:bg-state-destructive-hover disabled:cursor-not-allowed disabled:opacity-50',
-              'focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-components-input-border-active',
-              'group',
-            )}
-          >
-            <RiDeleteBinLine className="size-4 text-text-tertiary group-hover:text-text-destructive" aria-hidden="true" />
-            <span className="system-sm-regular text-text-secondary group-hover:text-text-destructive">
-              {t('skillSidebar.menu.delete')}
-            </span>
-          </button>
-        </>
-      )}
-
-      <Confirm
-        isShow={showDeleteConfirm}
-        type="danger"
-        title={t('skillSidebar.menu.deleteConfirmTitle')}
-        content={t('skillSidebar.menu.deleteConfirmContent')}
-        onConfirm={handleDeleteConfirm}
-        onCancel={handleDeleteCancel}
-        isLoading={isDeleting}
-      />
-    </div>
-  )
-}
-
-export default React.memo(FileOperationsMenu)
diff --git a/web/app/components/workflow/skill/file-tree/menu-item.tsx b/web/app/components/workflow/skill/file-tree/menu-item.tsx
index 56e7d3ab83..8a95268cdf 100644
--- a/web/app/components/workflow/skill/file-tree/menu-item.tsx
+++ b/web/app/components/workflow/skill/file-tree/menu-item.tsx
@@ -1,31 +1,70 @@
 'use client'
 
+import type { VariantProps } from 'class-variance-authority'
 import type { FC } from 'react'
+import { cva } from 'class-variance-authority'
 import * as React from 'react'
 import { cn } from '@/utils/classnames'
 
+const menuItemVariants = cva(
+  [
+    'flex w-full items-center gap-2 rounded-lg px-3 py-2',
+    'disabled:cursor-not-allowed disabled:opacity-50',
+    'focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-components-input-border-active',
+  ],
+  {
+    variants: {
+      variant: {
+        default: 'hover:bg-state-base-hover',
+        destructive: 'group hover:bg-state-destructive-hover',
+      },
+    },
+    defaultVariants: {
+      variant: 'default',
+    },
+  },
+)
+
+const iconVariants = cva('size-4 text-text-tertiary', {
+  variants: {
+    variant: {
+      default: '',
+      destructive: 'group-hover:text-text-destructive',
+    },
+  },
+  defaultVariants: {
+    variant: 'default',
+  },
+})
+
+const labelVariants = cva('system-sm-regular text-text-secondary', {
+  variants: {
+    variant: {
+      default: '',
+      destructive: 'group-hover:text-text-destructive',
+    },
+  },
+  defaultVariants: {
+    variant: 'default',
+  },
+})
+
 export type MenuItemProps = {
   icon: React.ElementType
   label: string
   onClick: () => void
   disabled?: boolean
-}
+} & VariantProps<typeof menuItemVariants>
 
-const MenuItem: FC<MenuItemProps> = ({ icon: Icon, label, onClick, disabled }) => (
+const MenuItem: FC<MenuItemProps> = ({ icon: Icon, label, onClick, disabled, variant }) => (
   <button
     type="button"
     onClick={onClick}
     disabled={disabled}
-    className={cn(
-      'flex w-full items-center gap-2 rounded-lg px-3 py-2',
-      'hover:bg-state-base-hover disabled:cursor-not-allowed disabled:opacity-50',
-      'focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-components-input-border-active',
-    )}
+    className={cn(menuItemVariants({ variant }))}
   >
-    <Icon className="size-4 text-text-tertiary" aria-hidden="true" />
-    <span className="system-sm-regular text-text-secondary">
-      {label}
-    </span>
+    <Icon className={cn(iconVariants({ variant }))} aria-hidden="true" />
+    <span className={cn(labelVariants({ variant }))}>{label}</span>
   </button>
 )
 
diff --git a/web/app/components/workflow/skill/file-tree/node-menu.tsx b/web/app/components/workflow/skill/file-tree/node-menu.tsx
new file mode 100644
index 0000000000..518a4c98b4
--- /dev/null
+++ b/web/app/components/workflow/skill/file-tree/node-menu.tsx
@@ -0,0 +1,155 @@
+'use client'
+
+import type { FC } from 'react'
+import type { NodeApi, TreeApi } from 'react-arborist'
+import type { TreeNodeData } from '../type'
+import {
+  RiDeleteBinLine,
+  RiEdit2Line,
+  RiFileAddLine,
+  RiFolderAddLine,
+  RiFolderUploadLine,
+  RiUploadLine,
+} from '@remixicon/react'
+import * as React from 'react'
+import { useTranslation } from 'react-i18next'
+import Confirm from '@/app/components/base/confirm'
+import { cn } from '@/utils/classnames'
+import { useFileOperations } from '../hooks/use-file-operations'
+import MenuItem from './menu-item'
+
+type NodeMenuProps = {
+  type: 'file' | 'folder'
+  nodeId?: string
+  onClose: () => void
+  className?: string
+  treeRef?: React.RefObject<TreeApi<TreeNodeData> | null>
+  node?: NodeApi<TreeNodeData>
+}
+
+const NodeMenu: FC<NodeMenuProps> = ({
+  type,
+  nodeId,
+  onClose,
+  className,
+  treeRef,
+  node,
+}) => {
+  const { t } = useTranslation('workflow')
+  const isFolder = type === 'folder'
+  const derivedNodeId = node?.data.id ?? nodeId ?? ''
+  const isRoot = derivedNodeId === 'root'
+
+  const {
+    fileInputRef,
+    folderInputRef,
+    showDeleteConfirm,
+    isLoading,
+    isDeleting,
+    handleNewFile,
+    handleNewFolder,
+    handleFileChange,
+    handleFolderChange,
+    handleRename,
+    handleDeleteClick,
+    handleDeleteConfirm,
+    handleDeleteCancel,
+  } = useFileOperations({ nodeId, onClose, treeRef, node })
+
+  const showRenameDelete = isFolder ? !isRoot : true
+  const deleteConfirmTitle = isFolder
+    ? t('skillSidebar.menu.deleteConfirmTitle')
+    : t('skillSidebar.menu.fileDeleteConfirmTitle')
+  const deleteConfirmContent = isFolder
+    ? t('skillSidebar.menu.deleteConfirmContent')
+    : t('skillSidebar.menu.fileDeleteConfirmContent')
+
+  return (
+    <div className={cn(
+      'min-w-[180px] rounded-xl border-[0.5px] border-components-panel-border',
+      'bg-components-panel-bg-blur p-1 shadow-lg backdrop-blur-[5px]',
+      className,
+    )}
+    >
+      {isFolder && (
+        <>
+          <input
+            ref={fileInputRef}
+            type="file"
+            multiple
+            className="hidden"
+            onChange={handleFileChange}
+          />
+          <input
+            ref={folderInputRef}
+            type="file"
+            // @ts-expect-error webkitdirectory is a non-standard attribute
+            webkitdirectory=""
+            className="hidden"
+            onChange={handleFolderChange}
+          />
+
+          <MenuItem
+            icon={RiFileAddLine}
+            label={t('skillSidebar.menu.newFile')}
+            onClick={handleNewFile}
+            disabled={isLoading}
+          />
+          <MenuItem
+            icon={RiFolderAddLine}
+            label={t('skillSidebar.menu.newFolder')}
+            onClick={handleNewFolder}
+            disabled={isLoading}
+          />
+
+          <div className="my-1 h-px bg-divider-subtle" />
+
+          <MenuItem
+            icon={RiUploadLine}
+            label={t('skillSidebar.menu.uploadFile')}
+            onClick={() => fileInputRef.current?.click()}
+            disabled={isLoading}
+          />
+          <MenuItem
+            icon={RiFolderUploadLine}
+            label={t('skillSidebar.menu.uploadFolder')}
+            onClick={() => folderInputRef.current?.click()}
+            disabled={isLoading}
+          />
+
+          {showRenameDelete && <div className="my-1 h-px bg-divider-subtle" />}
+        </>
+      )}
+
+      {showRenameDelete && (
+        <>
+          <MenuItem
+            icon={RiEdit2Line}
+            label={t('skillSidebar.menu.rename')}
+            onClick={handleRename}
+            disabled={isLoading}
+          />
+          <MenuItem
+            icon={RiDeleteBinLine}
+            label={t('skillSidebar.menu.delete')}
+            onClick={handleDeleteClick}
+            disabled={isLoading}
+            variant="destructive"
+          />
+        </>
+      )}
+
+      <Confirm
+        isShow={showDeleteConfirm}
+        type="danger"
+        title={deleteConfirmTitle}
+        content={deleteConfirmContent}
+        onConfirm={handleDeleteConfirm}
+        onCancel={handleDeleteCancel}
+        isLoading={isDeleting}
+      />
+    </div>
+  )
+}
+
+export default React.memo(NodeMenu)
diff --git a/web/app/components/workflow/skill/file-tree/tree-context-menu.tsx b/web/app/components/workflow/skill/file-tree/tree-context-menu.tsx
index 5d4233650e..9389d0c1aa 100644
--- a/web/app/components/workflow/skill/file-tree/tree-context-menu.tsx
+++ b/web/app/components/workflow/skill/file-tree/tree-context-menu.tsx
@@ -9,8 +9,7 @@ import { useCallback, useMemo, useRef } from 'react'
 import { useSkillAssetTreeData } from '../hooks/use-skill-asset-tree'
 import { useSkillEditorStore, useSkillEditorStoreApi } from '../store'
 import { findNodeById } from '../utils/tree-utils'
-import FileNodeMenu from './file-node-menu'
-import FolderNodeMenu from './folder-node-menu'
+import NodeMenu from './node-menu'
 
 type TreeContextMenuProps = {
   treeRef: React.RefObject<TreeApi<TreeNodeData> | null>
@@ -50,21 +49,12 @@ const TreeContextMenu: FC<TreeContextMenuProps> = ({ treeRef }) => {
         left: contextMenu.left,
       }}
     >
-      {isFolder
-        ? (
-            <FolderNodeMenu
-              nodeId={contextMenu.nodeId}
-              onClose={handleClose}
-              treeRef={treeRef}
-            />
-          )
-        : (
-            <FileNodeMenu
-              nodeId={contextMenu.nodeId}
-              onClose={handleClose}
-              treeRef={treeRef}
-            />
-          )}
+      <NodeMenu
+        type={isFolder ? 'folder' : 'file'}
+        nodeId={contextMenu.nodeId}
+        onClose={handleClose}
+        treeRef={treeRef}
+      />
     </div>
   )
 }
diff --git a/web/app/components/workflow/skill/file-tree/tree-node.tsx b/web/app/components/workflow/skill/file-tree/tree-node.tsx
index 1a52334d81..9cb44bf91a 100644
--- a/web/app/components/workflow/skill/file-tree/tree-node.tsx
+++ b/web/app/components/workflow/skill/file-tree/tree-node.tsx
@@ -18,8 +18,7 @@ import { cn } from '@/utils/classnames'
 import { useDelayedClick } from '../hooks/use-delayed-click'
 import { useSkillEditorStore, useSkillEditorStoreApi } from '../store'
 import { getFileIconType } from '../utils/file-utils'
-import FileNodeMenu from './file-node-menu'
-import FolderNodeMenu from './folder-node-menu'
+import NodeMenu from './node-menu'
 import TreeEditInput from './tree-edit-input'
 import TreeGuideLines from './tree-guide-lines'
 
@@ -192,19 +191,11 @@ const TreeNode = ({ node, style, dragHandle }: NodeRendererProps<TreeNodeData>)
           </button>
         </PortalToFollowElemTrigger>
         <PortalToFollowElemContent className="z-[100]">
-          {isFolder
-            ? (
-                <FolderNodeMenu
-                  onClose={() => setShowDropdown(false)}
-                  node={node}
-                />
-              )
-            : (
-                <FileNodeMenu
-                  onClose={() => setShowDropdown(false)}
-                  node={node}
-                />
-              )}
+          <NodeMenu
+            type={isFolder ? 'folder' : 'file'}
+            onClose={() => setShowDropdown(false)}
+            node={node}
+          />
         </PortalToFollowElemContent>
       </PortalToFollowElem>
     </div>