From 10a2124c6a5997c10ca1409c9b0ada656b6f54ca Mon Sep 17 00:00:00 2001 From: ojasarora77 Date: Thu, 25 Jun 2026 16:26:53 +0100 Subject: [PATCH] test: replace logger mock with caplog in workflow collaboration test Replace patch on logging.exception with pytest caplog in test_broadcast_leader_change_logs_emit_errors, following the pattern requested in #37468. --- .../services/test_workflow_collaboration_service.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/api/tests/unit_tests/services/test_workflow_collaboration_service.py b/api/tests/unit_tests/services/test_workflow_collaboration_service.py index 8a6addfeced..93d9b576f97 100644 --- a/api/tests/unit_tests/services/test_workflow_collaboration_service.py +++ b/api/tests/unit_tests/services/test_workflow_collaboration_service.py @@ -1,3 +1,4 @@ +import logging from unittest.mock import Mock, patch import pytest @@ -427,16 +428,20 @@ class TestWorkflowCollaborationService: repository.delete_leader.assert_not_called() def test_broadcast_leader_change_logs_emit_errors( - self, service: tuple[WorkflowCollaborationService, Mock, Mock] + self, + service: tuple[WorkflowCollaborationService, Mock, Mock], + caplog: pytest.LogCaptureFixture, ) -> None: collaboration_service, repository, socketio = service repository.get_session_sids.return_value = ["sid-1", "sid-2"] socketio.emit.side_effect = [RuntimeError("boom"), None] - with patch("services.workflow_collaboration_service.logging.exception") as exception_mock: + with caplog.at_level(logging.ERROR): collaboration_service.broadcast_leader_change("wf-1", "sid-2") - assert exception_mock.call_count == 1 + error_records = [record for record in caplog.records if record.levelno == logging.ERROR] + assert len(error_records) == 1 + assert "Failed to emit leader status to session sid-1" in caplog.text def test_broadcast_online_users_sorts_and_emits( self, service: tuple[WorkflowCollaborationService, Mock, Mock]