From 1fb491337b06b8c54741c0cccd45293e39ed575a Mon Sep 17 00:00:00 2001 From: Sven Weidenmann <93180912+AlsoTheZv3n@users.noreply.github.com> Date: Thu, 21 May 2026 21:41:42 +0200 Subject: [PATCH] refactor: add missing @override decorator to datasource plugin classes (#36494) --- api/core/datasource/local_file/local_file_plugin.py | 4 ++++ api/core/datasource/local_file/local_file_provider.py | 4 +++- api/core/datasource/online_document/online_document_plugin.py | 3 ++- .../datasource/online_document/online_document_provider.py | 3 +++ api/core/datasource/online_drive/online_drive_plugin.py | 2 ++ api/core/datasource/online_drive/online_drive_provider.py | 3 +++ api/core/datasource/website_crawl/website_crawl_plugin.py | 3 ++- api/core/datasource/website_crawl/website_crawl_provider.py | 3 +++ 8 files changed, 22 insertions(+), 3 deletions(-) diff --git a/api/core/datasource/local_file/local_file_plugin.py b/api/core/datasource/local_file/local_file_plugin.py index 070a89cb2f..7d20d62cbb 100644 --- a/api/core/datasource/local_file/local_file_plugin.py +++ b/api/core/datasource/local_file/local_file_plugin.py @@ -1,3 +1,5 @@ +from typing import override + from core.datasource.__base.datasource_plugin import DatasourcePlugin from core.datasource.__base.datasource_runtime import DatasourceRuntime from core.datasource.entities.datasource_entities import ( @@ -22,8 +24,10 @@ class LocalFileDatasourcePlugin(DatasourcePlugin): self.tenant_id = tenant_id self.plugin_unique_identifier = plugin_unique_identifier + @override def datasource_provider_type(self) -> str: return DatasourceProviderType.LOCAL_FILE + @override def get_icon_url(self, tenant_id: str) -> str: return self.icon diff --git a/api/core/datasource/local_file/local_file_provider.py b/api/core/datasource/local_file/local_file_provider.py index b2b6f51dd3..6b6f78b33d 100644 --- a/api/core/datasource/local_file/local_file_provider.py +++ b/api/core/datasource/local_file/local_file_provider.py @@ -1,4 +1,4 @@ -from typing import Any +from typing import Any, override from core.datasource.__base.datasource_provider import DatasourcePluginProviderController from core.datasource.__base.datasource_runtime import DatasourceRuntime @@ -19,12 +19,14 @@ class LocalFileDatasourcePluginProviderController(DatasourcePluginProviderContro self.plugin_unique_identifier = plugin_unique_identifier @property + @override def provider_type(self) -> DatasourceProviderType: """ returns the type of the provider """ return DatasourceProviderType.LOCAL_FILE + @override def _validate_credentials(self, user_id: str, credentials: dict[str, Any]) -> None: """ validate the credentials of the provider diff --git a/api/core/datasource/online_document/online_document_plugin.py b/api/core/datasource/online_document/online_document_plugin.py index ce23da1e09..2fbf575d55 100644 --- a/api/core/datasource/online_document/online_document_plugin.py +++ b/api/core/datasource/online_document/online_document_plugin.py @@ -1,5 +1,5 @@ from collections.abc import Generator -from typing import Any +from typing import Any, override from core.datasource.__base.datasource_plugin import DatasourcePlugin from core.datasource.__base.datasource_runtime import DatasourceRuntime @@ -67,5 +67,6 @@ class OnlineDocumentDatasourcePlugin(DatasourcePlugin): provider_type=provider_type, ) + @override def datasource_provider_type(self) -> str: return DatasourceProviderType.ONLINE_DOCUMENT diff --git a/api/core/datasource/online_document/online_document_provider.py b/api/core/datasource/online_document/online_document_provider.py index a128b479f4..f1f34c8ba1 100644 --- a/api/core/datasource/online_document/online_document_provider.py +++ b/api/core/datasource/online_document/online_document_provider.py @@ -1,3 +1,5 @@ +from typing import override + from core.datasource.__base.datasource_provider import DatasourcePluginProviderController from core.datasource.__base.datasource_runtime import DatasourceRuntime from core.datasource.entities.datasource_entities import DatasourceProviderEntityWithPlugin, DatasourceProviderType @@ -17,6 +19,7 @@ class OnlineDocumentDatasourcePluginProviderController(DatasourcePluginProviderC self.plugin_unique_identifier = plugin_unique_identifier @property + @override def provider_type(self) -> DatasourceProviderType: """ returns the type of the provider diff --git a/api/core/datasource/online_drive/online_drive_plugin.py b/api/core/datasource/online_drive/online_drive_plugin.py index 64715226cc..a12226a160 100644 --- a/api/core/datasource/online_drive/online_drive_plugin.py +++ b/api/core/datasource/online_drive/online_drive_plugin.py @@ -1,4 +1,5 @@ from collections.abc import Generator +from typing import override from core.datasource.__base.datasource_plugin import DatasourcePlugin from core.datasource.__base.datasource_runtime import DatasourceRuntime @@ -67,5 +68,6 @@ class OnlineDriveDatasourcePlugin(DatasourcePlugin): provider_type=provider_type, ) + @override def datasource_provider_type(self) -> str: return DatasourceProviderType.ONLINE_DRIVE diff --git a/api/core/datasource/online_drive/online_drive_provider.py b/api/core/datasource/online_drive/online_drive_provider.py index d0923ed807..d4a6942d09 100644 --- a/api/core/datasource/online_drive/online_drive_provider.py +++ b/api/core/datasource/online_drive/online_drive_provider.py @@ -1,3 +1,5 @@ +from typing import override + from core.datasource.__base.datasource_provider import DatasourcePluginProviderController from core.datasource.__base.datasource_runtime import DatasourceRuntime from core.datasource.entities.datasource_entities import DatasourceProviderEntityWithPlugin, DatasourceProviderType @@ -17,6 +19,7 @@ class OnlineDriveDatasourcePluginProviderController(DatasourcePluginProviderCont self.plugin_unique_identifier = plugin_unique_identifier @property + @override def provider_type(self) -> DatasourceProviderType: """ returns the type of the provider diff --git a/api/core/datasource/website_crawl/website_crawl_plugin.py b/api/core/datasource/website_crawl/website_crawl_plugin.py index 087ac65a7a..c5c9b4c0f2 100644 --- a/api/core/datasource/website_crawl/website_crawl_plugin.py +++ b/api/core/datasource/website_crawl/website_crawl_plugin.py @@ -1,5 +1,5 @@ from collections.abc import Generator, Mapping -from typing import Any +from typing import Any, override from core.datasource.__base.datasource_plugin import DatasourcePlugin from core.datasource.__base.datasource_runtime import DatasourceRuntime @@ -47,5 +47,6 @@ class WebsiteCrawlDatasourcePlugin(DatasourcePlugin): provider_type=provider_type, ) + @override def datasource_provider_type(self) -> str: return DatasourceProviderType.WEBSITE_CRAWL diff --git a/api/core/datasource/website_crawl/website_crawl_provider.py b/api/core/datasource/website_crawl/website_crawl_provider.py index 8c0f20ce2d..0dfdf3c0dd 100644 --- a/api/core/datasource/website_crawl/website_crawl_provider.py +++ b/api/core/datasource/website_crawl/website_crawl_provider.py @@ -1,3 +1,5 @@ +from typing import override + from core.datasource.__base.datasource_provider import DatasourcePluginProviderController from core.datasource.__base.datasource_runtime import DatasourceRuntime from core.datasource.entities.datasource_entities import DatasourceProviderEntityWithPlugin, DatasourceProviderType @@ -21,6 +23,7 @@ class WebsiteCrawlDatasourcePluginProviderController(DatasourcePluginProviderCon self.plugin_unique_identifier = plugin_unique_identifier @property + @override def provider_type(self) -> DatasourceProviderType: """ returns the type of the provider