opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-08 02:43:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(api): type recommend app database retrieval dicts with TypedDicts (#34873)

Browse Source
This commit is contained in:
YBoy 2026-04-10 02:32:24 +02:00 committed by GitHub
parent 985e71ebf4
commit 2352269ba9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 44 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
api/services/recommend_app/database/database_retrieval.py
View File

@ -1,3 +1,5 @@
from typing import Any, TypedDict
from sqlalchemy import select from sqlalchemy import select
from constants.languages import languages from constants.languages import languages
@ -8,16 +10,43 @@ from services.recommend_app.recommend_app_base import RecommendAppRetrievalBase
from services.recommend_app.recommend_app_type import RecommendAppType from services.recommend_app.recommend_app_type import RecommendAppType
class RecommendedAppItemDict(TypedDict):
id: str
app: App | None
app_id: str
description: Any
copyright: Any
privacy_policy: Any
custom_disclaimer: str
category: str
position: int
is_listed: bool
class RecommendedAppsResultDict(TypedDict):
recommended_apps: list[RecommendedAppItemDict]
categories: list[str]
class RecommendedAppDetailDict(TypedDict):
id: str
name: str
icon: Any
icon_background: str | None
mode: str
export_data: str
class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase): class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase):
""" """
Retrieval recommended app from database Retrieval recommended app from database
""" """
def get_recommended_apps_and_categories(self, language: str): def get_recommended_apps_and_categories(self, language: str) -> RecommendedAppsResultDict:
result = self.fetch_recommended_apps_from_db(language) result = self.fetch_recommended_apps_from_db(language)
return result return result
def get_recommend_app_detail(self, app_id: str): def get_recommend_app_detail(self, app_id: str) -> RecommendedAppDetailDict | None:
result = self.fetch_recommended_app_detail_from_db(app_id) result = self.fetch_recommended_app_detail_from_db(app_id)
return result return result
@ -25,7 +54,7 @@ class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase):
return RecommendAppType.DATABASE return RecommendAppType.DATABASE
@classmethod @classmethod
def fetch_recommended_apps_from_db(cls, language: str): def fetch_recommended_apps_from_db(cls, language: str) -> RecommendedAppsResultDict:
""" """
Fetch recommended apps from db. Fetch recommended apps from db.
:param language: language :param language: language
@ -41,7 +70,7 @@ class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase):
).all() ).all()
categories = set() categories = set()
recommended_apps_result = [] recommended_apps_result: list[RecommendedAppItemDict] = []
for recommended_app in recommended_apps: for recommended_app in recommended_apps:
app = recommended_app.app app = recommended_app.app
if not app or not app.is_public: if not app or not app.is_public:
@ -51,7 +80,7 @@ class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase):
if not site: if not site:
continue continue
recommended_app_result = { recommended_app_result: RecommendedAppItemDict = {
"id": recommended_app.id, "id": recommended_app.id,
"app": recommended_app.app, "app": recommended_app.app,
"app_id": recommended_app.app_id, "app_id": recommended_app.app_id,
@ -67,10 +96,10 @@ class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase):
categories.add(recommended_app.category) categories.add(recommended_app.category)
return {"recommended_apps": recommended_apps_result, "categories": sorted(categories)} return RecommendedAppsResultDict(recommended_apps=recommended_apps_result, categories=sorted(categories))
@classmethod @classmethod
def fetch_recommended_app_detail_from_db(cls, app_id: str) -> dict | None: def fetch_recommended_app_detail_from_db(cls, app_id: str) -> RecommendedAppDetailDict | None:
""" """
Fetch recommended app detail from db. Fetch recommended app detail from db.
:param app_id: App ID :param app_id: App ID
@ -89,11 +118,11 @@ class DatabaseRecommendAppRetrieval(RecommendAppRetrievalBase):
if not app_model or not app_model.is_public: if not app_model or not app_model.is_public:
return None return None
return { return RecommendedAppDetailDict(
"id": app_model.id, id=app_model.id,
"name": app_model.name, name=app_model.name,
"icon": app_model.icon, icon=app_model.icon,
"icon_background": app_model.icon_background, icon_background=app_model.icon_background,
"mode": app_model.mode, mode=app_model.mode,
"export_data": AppDslService.export_dsl(app_model=app_model), export_data=AppDslService.export_dsl(app_model=app_model),
} )