From 2604c33e54961cde135e9f55f1880af7141575df Mon Sep 17 00:00:00 2001 From: Evan <2869018789@qq.com> Date: Thu, 18 Jun 2026 15:55:48 +0800 Subject: [PATCH] refactor(tests): replace mock_logger with caplog in service tests (#37468) (#37617) --- .../services/test_trigger_provider_service.py | 30 ++++++++++--------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/api/tests/unit_tests/services/test_trigger_provider_service.py b/api/tests/unit_tests/services/test_trigger_provider_service.py index 4da4af2d939..184e1375ed9 100644 --- a/api/tests/unit_tests/services/test_trigger_provider_service.py +++ b/api/tests/unit_tests/services/test_trigger_provider_service.py @@ -2,6 +2,7 @@ from __future__ import annotations import contextlib import json +import logging from types import SimpleNamespace from typing import Any from unittest.mock import MagicMock @@ -252,27 +253,28 @@ def test_add_trigger_subscription_should_raise_error_when_provider_limit_reached mock_session: MagicMock, provider_id: TriggerProviderID, provider_controller: MagicMock, + caplog, ) -> None: # Arrange _patch_redis_lock(mocker) mock_session.scalar.return_value = TriggerProviderService.__MAX_TRIGGER_PROVIDER_COUNT__ _mock_get_trigger_provider(mocker, provider_controller) - mock_logger = mocker.patch("services.trigger.trigger_provider_service.logger") # Act + Assert - with pytest.raises(ValueError, match="Maximum number of providers"): - TriggerProviderService.add_trigger_subscription( - tenant_id="tenant-1", - user_id="user-1", - name="main", - provider_id=provider_id, - endpoint_id="endpoint-1", - credential_type=CredentialType.API_KEY, - parameters={}, - properties={}, - credentials={}, - ) - mock_logger.exception.assert_called_once() + with caplog.at_level(logging.ERROR, logger="services.trigger.trigger_provider_service"): + with pytest.raises(ValueError, match="Maximum number of providers"): + TriggerProviderService.add_trigger_subscription( + tenant_id="tenant-1", + user_id="user-1", + name="main", + provider_id=provider_id, + endpoint_id="endpoint-1", + credential_type=CredentialType.API_KEY, + parameters={}, + properties={}, + credentials={}, + ) + assert sum(1 for r in caplog.records if r.levelno >= logging.ERROR) == 1 def test_add_trigger_subscription_should_raise_error_when_name_exists(