test: migrate workflow trigger log repository sql tests to testcontainers (#32525)

Co-authored-by: KinomotoMio <200703522+KinomotoMio@users.noreply.github.com>
This commit is contained in:
木之本澪 2026-02-25 03:53:16 +08:00 committed by GitHub
parent 59681ce760
commit 28f2098b00
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 134 additions and 31 deletions

View File

@ -0,0 +1,134 @@
"""Integration tests for SQLAlchemyWorkflowTriggerLogRepository using testcontainers."""
from __future__ import annotations
from uuid import uuid4
from sqlalchemy import delete, func, select
from sqlalchemy.orm import Session
from models.enums import AppTriggerType, CreatorUserRole, WorkflowTriggerStatus
from models.trigger import WorkflowTriggerLog
from repositories.sqlalchemy_workflow_trigger_log_repository import SQLAlchemyWorkflowTriggerLogRepository
def _create_trigger_log(
session: Session,
*,
tenant_id: str,
app_id: str,
workflow_id: str,
workflow_run_id: str,
created_by: str,
) -> WorkflowTriggerLog:
trigger_log = WorkflowTriggerLog(
tenant_id=tenant_id,
app_id=app_id,
workflow_id=workflow_id,
workflow_run_id=workflow_run_id,
root_node_id=None,
trigger_metadata="{}",
trigger_type=AppTriggerType.TRIGGER_WEBHOOK,
trigger_data="{}",
inputs="{}",
outputs=None,
status=WorkflowTriggerStatus.SUCCEEDED,
error=None,
queue_name="default",
celery_task_id=None,
created_by_role=CreatorUserRole.ACCOUNT,
created_by=created_by,
retry_count=0,
)
session.add(trigger_log)
session.flush()
return trigger_log
def test_delete_by_run_ids_executes_delete(db_session_with_containers: Session) -> None:
tenant_id = str(uuid4())
app_id = str(uuid4())
workflow_id = str(uuid4())
created_by = str(uuid4())
run_id_1 = str(uuid4())
run_id_2 = str(uuid4())
untouched_run_id = str(uuid4())
_create_trigger_log(
db_session_with_containers,
tenant_id=tenant_id,
app_id=app_id,
workflow_id=workflow_id,
workflow_run_id=run_id_1,
created_by=created_by,
)
_create_trigger_log(
db_session_with_containers,
tenant_id=tenant_id,
app_id=app_id,
workflow_id=workflow_id,
workflow_run_id=run_id_2,
created_by=created_by,
)
_create_trigger_log(
db_session_with_containers,
tenant_id=tenant_id,
app_id=app_id,
workflow_id=workflow_id,
workflow_run_id=untouched_run_id,
created_by=created_by,
)
db_session_with_containers.commit()
repository = SQLAlchemyWorkflowTriggerLogRepository(db_session_with_containers)
try:
deleted = repository.delete_by_run_ids([run_id_1, run_id_2])
db_session_with_containers.commit()
assert deleted == 2
remaining_logs = db_session_with_containers.scalars(
select(WorkflowTriggerLog).where(WorkflowTriggerLog.tenant_id == tenant_id)
).all()
assert len(remaining_logs) == 1
assert remaining_logs[0].workflow_run_id == untouched_run_id
finally:
db_session_with_containers.execute(delete(WorkflowTriggerLog).where(WorkflowTriggerLog.tenant_id == tenant_id))
db_session_with_containers.commit()
def test_delete_by_run_ids_empty_short_circuits(db_session_with_containers: Session) -> None:
tenant_id = str(uuid4())
app_id = str(uuid4())
workflow_id = str(uuid4())
created_by = str(uuid4())
run_id = str(uuid4())
_create_trigger_log(
db_session_with_containers,
tenant_id=tenant_id,
app_id=app_id,
workflow_id=workflow_id,
workflow_run_id=run_id,
created_by=created_by,
)
db_session_with_containers.commit()
repository = SQLAlchemyWorkflowTriggerLogRepository(db_session_with_containers)
try:
deleted = repository.delete_by_run_ids([])
db_session_with_containers.commit()
assert deleted == 0
remaining_count = db_session_with_containers.scalar(
select(func.count())
.select_from(WorkflowTriggerLog)
.where(WorkflowTriggerLog.tenant_id == tenant_id)
.where(WorkflowTriggerLog.workflow_run_id == run_id)
)
assert remaining_count == 1
finally:
db_session_with_containers.execute(delete(WorkflowTriggerLog).where(WorkflowTriggerLog.tenant_id == tenant_id))
db_session_with_containers.commit()

View File

@ -1,31 +0,0 @@
from unittest.mock import Mock
from sqlalchemy.dialects import postgresql
from sqlalchemy.orm import Session
from repositories.sqlalchemy_workflow_trigger_log_repository import SQLAlchemyWorkflowTriggerLogRepository
def test_delete_by_run_ids_executes_delete():
session = Mock(spec=Session)
session.execute.return_value = Mock(rowcount=2)
repo = SQLAlchemyWorkflowTriggerLogRepository(session)
deleted = repo.delete_by_run_ids(["run-1", "run-2"])
stmt = session.execute.call_args[0][0]
compiled_sql = str(stmt.compile(dialect=postgresql.dialect(), compile_kwargs={"literal_binds": True}))
assert "workflow_trigger_logs" in compiled_sql
assert "'run-1'" in compiled_sql
assert "'run-2'" in compiled_sql
assert deleted == 2
def test_delete_by_run_ids_empty_short_circuits():
session = Mock(spec=Session)
repo = SQLAlchemyWorkflowTriggerLogRepository(session)
deleted = repo.delete_by_run_ids([])
session.execute.assert_not_called()
assert deleted == 0