From 2b91fba3e9de9b4153986b85464673b807f7f297 Mon Sep 17 00:00:00 2001
From: lyzno1 <yuanyouhuilyz@gmail.com>
Date: Wed, 10 Sep 2025 14:11:23 +0800
Subject: [PATCH] refactor(sidebar): extract duplicated icon wrapper logic

---
 web/app/components/app-sidebar/navLink.tsx | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/web/app/components/app-sidebar/navLink.tsx b/web/app/components/app-sidebar/navLink.tsx
index e7b637a64d..ad90b91250 100644
--- a/web/app/components/app-sidebar/navLink.tsx
+++ b/web/app/components/app-sidebar/navLink.tsx
@@ -41,6 +41,12 @@ const NavLink = ({
   const isActive = href.toLowerCase().split('/')?.pop() === formattedSegment
   const NavIcon = isActive ? iconMap.selected : iconMap.normal
 
+  const renderIcon = () => (
+    <div className={classNames(mode !== 'expand' && '-ml-1')}>
+      <NavIcon className="h-4 w-4 shrink-0" aria-hidden="true" />
+    </div>
+  )
+
   if (disabled) {
     return (
       <button
@@ -54,9 +60,7 @@ const NavLink = ({
         title={mode === 'collapse' ? name : ''}
         aria-disabled
       >
-        <div className={classNames(mode !== 'expand' && '-ml-1')}>
-          <NavIcon className="h-4 w-4 shrink-0" aria-hidden="true" />
-        </div>
+        {renderIcon()}
         <span
           className={classNames(
             'overflow-hidden whitespace-nowrap transition-all duration-200 ease-in-out',
@@ -83,9 +87,7 @@ const NavLink = ({
       )}
       title={mode === 'collapse' ? name : ''}
     >
-      <div className={classNames(mode !== 'expand' && '-ml-1')}>
-        <NavIcon className="h-4 w-4 shrink-0" aria-hidden="true" />
-      </div>
+      {renderIcon()}
       <span
         className={classNames(
           'overflow-hidden whitespace-nowrap transition-all duration-200 ease-in-out',