From a099e0a7e6243aec302cca015fd75726d2093246 Mon Sep 17 00:00:00 2001
From: twwu <twwu@dify.ai>
Date: Tue, 17 Dec 2024 16:42:11 +0800
Subject: [PATCH 1/5] fix: Adjust layout and prevent default behavior in action
 buttons

---
 .../datasets/documents/detail/completed/child-segment-list.tsx  | 2 +-
 .../documents/detail/completed/common/action-buttons.tsx        | 2 +-
 .../components/datasets/documents/detail/completed/index.tsx    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/web/app/components/datasets/documents/detail/completed/child-segment-list.tsx b/web/app/components/datasets/documents/detail/completed/child-segment-list.tsx
index 8efdccbffc..fd35c0c81e 100644
--- a/web/app/components/datasets/documents/detail/completed/child-segment-list.tsx
+++ b/web/app/components/datasets/documents/detail/completed/child-segment-list.tsx
@@ -135,7 +135,7 @@ const ChildSegmentList: FC<IChildSegmentCardProps> = ({
       </div>
       {isLoading ? <FullDocListSkeleton /> : null}
       {((isFullDocMode && !isLoading) || !collapsed)
-        ? <div className={classNames('flex items-center gap-x-0.5', isFullDocMode ? 'grow' : '')}>
+        ? <div className={classNames('flex items-center gap-x-0.5', isFullDocMode ? 'grow mb-6' : '')}>
           {isParagraphMode && (
             <div className='self-stretch my-0.5'>
               <Divider type='vertical' className='w-[2px] mx-[7px] bg-text-accent-secondary' />
diff --git a/web/app/components/datasets/documents/detail/completed/common/action-buttons.tsx b/web/app/components/datasets/documents/detail/completed/common/action-buttons.tsx
index 5ade8267c2..15bff500b5 100644
--- a/web/app/components/datasets/documents/detail/completed/common/action-buttons.tsx
+++ b/web/app/components/datasets/documents/detail/completed/common/action-buttons.tsx
@@ -31,9 +31,9 @@ const ActionButtons: FC<IActionButtonsProps> = ({
   })
 
   useKeyPress(`${getKeyboardKeyCodeBySystem('ctrl')}.s`, (e) => {
+    e.preventDefault()
     if (loading)
       return
-    e.preventDefault()
     handleSave()
   }
   , { exactMatch: true, useCapture: true })
diff --git a/web/app/components/datasets/documents/detail/completed/index.tsx b/web/app/components/datasets/documents/detail/completed/index.tsx
index 7e99db4f55..91697db5ce 100644
--- a/web/app/components/datasets/documents/detail/completed/index.tsx
+++ b/web/app/components/datasets/documents/detail/completed/index.tsx
@@ -538,7 +538,7 @@ const Completed: FC<ICompletedProps> = ({
       {
         isFullDocMode
           ? <div className={cn(
-            'flex flex-col grow relative overflow-x-hidden',
+            'flex flex-col grow overflow-x-hidden',
             (isLoadingSegmentList || isLoadingChildSegmentList) ? 'overflow-y-hidden' : 'overflow-y-auto',
           )}>
             <SegmentCard

From 4ef876db239599116ebb03f5b4d406d994b11b78 Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Tue, 17 Dec 2024 17:35:42 +0800
Subject: [PATCH 2/5] chore: use qa language

---
 web/app/components/datasets/create/step-two/index.tsx | 4 ++--
 web/i18n/en-US/dataset-creation.ts                    | 1 +
 web/i18n/zh-Hans/dataset-creation.ts                  | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/web/app/components/datasets/create/step-two/index.tsx b/web/app/components/datasets/create/step-two/index.tsx
index 81fe80f67d..dd33167cb2 100644
--- a/web/app/components/datasets/create/step-two/index.tsx
+++ b/web/app/components/datasets/create/step-two/index.tsx
@@ -550,7 +550,7 @@ const StepTwo = ({
       getRulesFromDetail()
       getDefaultMode()
     }
-  // eslint-disable-next-line react-hooks/exhaustive-deps
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [])
 
   useEffect(() => {
@@ -658,7 +658,7 @@ const StepTwo = ({
                         />
                         <div className='flex items-center gap-1'>
                           <TextLabel>
-                            {t('datasetCreation.stepTwo.QALanguage')}
+                            {t('datasetCreation.stepTwo.useQALanguage')}
                           </TextLabel>
                           <div className='z-50 relative'>
                             <LanguageSelect
diff --git a/web/i18n/en-US/dataset-creation.ts b/web/i18n/en-US/dataset-creation.ts
index c94cb7ce21..94fb54cfc5 100644
--- a/web/i18n/en-US/dataset-creation.ts
+++ b/web/i18n/en-US/dataset-creation.ts
@@ -136,6 +136,7 @@ const translation = {
     QATitle: 'Segmenting in Question & Answer format',
     QATip: 'Enable this option will consume more tokens',
     QALanguage: 'Segment using',
+    useQALanguage: 'Chunk using Q&A format in',
     estimateCost: 'Estimation',
     estimateSegment: 'Estimated chunks',
     segmentCount: 'chunks',
diff --git a/web/i18n/zh-Hans/dataset-creation.ts b/web/i18n/zh-Hans/dataset-creation.ts
index 30e32023f7..226a06ec3a 100644
--- a/web/i18n/zh-Hans/dataset-creation.ts
+++ b/web/i18n/zh-Hans/dataset-creation.ts
@@ -136,6 +136,7 @@ const translation = {
     QATitle: '采用 Q&A 分段模式',
     QATip: '开启后将会消耗额外的 token',
     QALanguage: '分段使用',
+    useQALanguage: '使用 Q&A 分段，语言',
     estimateCost: '执行嵌入预估消耗',
     estimateSegment: '预估分段数',
     segmentCount: '段',

From 39452274f8459117f1a1d690b15f1d152e2275fb Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Tue, 17 Dec 2024 17:46:43 +0800
Subject: [PATCH 3/5] chore: fix chunk detail spacing

---
 .../datasets/hit-testing/components/chunk-detail-modal.tsx      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx b/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx
index 53fb468001..e3b0bef766 100644
--- a/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx
+++ b/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx
@@ -38,7 +38,7 @@ const ChunkDetailModal: FC<Props> = ({
       onClose={onHide}
       className={cn(isParentChildRetrieval ? '!min-w-[1200px]' : '!min-w-[720px]')}
     >
-      <div className='mt-4 flex pb-6'>
+      <div className='mt-4 flex'>
         <div>
           {/* Meta info */}
           <div className='flex justify-between items-center'>

From de6b0670a363b09f656490a9f3688f4084054ba8 Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Tue, 17 Dec 2024 17:53:25 +0800
Subject: [PATCH 4/5] chore: detail ui

---
 .../datasets/hit-testing/components/chunk-detail-modal.tsx      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx b/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx
index e3b0bef766..c1e2e41406 100644
--- a/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx
+++ b/web/app/components/datasets/hit-testing/components/chunk-detail-modal.tsx
@@ -39,7 +39,7 @@ const ChunkDetailModal: FC<Props> = ({
       className={cn(isParentChildRetrieval ? '!min-w-[1200px]' : '!min-w-[720px]')}
     >
       <div className='mt-4 flex'>
-        <div>
+        <div className='w-full'>
           {/* Meta info */}
           <div className='flex justify-between items-center'>
             <div className='grow flex items-center space-x-2'>

From 8ee7e0a787a587d1a9ea1be886b614f25c9629ee Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Tue, 17 Dec 2024 18:10:44 +0800
Subject: [PATCH 5/5] fix: text size

---
 .../datasets/hit-testing/components/child-chunks-item.tsx   | 6 +++---
 .../components/datasets/hit-testing/components/score.tsx    | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/web/app/components/datasets/hit-testing/components/child-chunks-item.tsx b/web/app/components/datasets/hit-testing/components/child-chunks-item.tsx
index 0d9b178a63..043aa3cea7 100644
--- a/web/app/components/datasets/hit-testing/components/child-chunks-item.tsx
+++ b/web/app/components/datasets/hit-testing/components/child-chunks-item.tsx
@@ -19,11 +19,11 @@ const ChildChunks: FC<Props> = ({
     <div
       className={!isShowAll ? 'line-clamp-2' : ''}
     >
-      <div className='inline-flex items-center relative top-[-3px]'>
-        <div className='flex items-center h-[24px] bg-state-accent-solid  system-2xs-semibold-uppercase text-text-primary-on-surface px-1'>C-{position}</div>
+      <div className='inline-flex items-center relative top-[-2px]'>
+        <div className='flex items-center h-[20.5px] bg-state-accent-solid  system-2xs-semibold-uppercase text-text-primary-on-surface px-1'>C-{position}</div>
         <Score value={score} besideChunkName />
       </div>
-      <SliceContent className='bg-state-accent-hover group-hover:bg-state-accent-hover text-text-secondary font-normal'>{content}</SliceContent>
+      <SliceContent className='py-0.5 bg-state-accent-hover group-hover:bg-state-accent-hover text-sm text-text-secondary font-normal'>{content}</SliceContent>
     </div>
   )
 }
diff --git a/web/app/components/datasets/hit-testing/components/score.tsx b/web/app/components/datasets/hit-testing/components/score.tsx
index 6f48edd4bd..115141eaaa 100644
--- a/web/app/components/datasets/hit-testing/components/score.tsx
+++ b/web/app/components/datasets/hit-testing/components/score.tsx
@@ -13,7 +13,7 @@ const Score: FC<Props> = ({
   besideChunkName,
 }) => {
   return (
-    <div className={cn('relative items-center px-[5px] border border-components-progress-bar-border overflow-hidden', besideChunkName ? 'border-l-0 h-[25px]' : 'h-[20px] rounded-md')}>
+    <div className={cn('relative items-center px-[5px] border border-components-progress-bar-border overflow-hidden', besideChunkName ? 'border-l-0 h-[20.5px]' : 'h-[20px] rounded-md')}>
       <div className={cn('absolute top-0 left-0 h-full bg-util-colors-blue-brand-blue-brand-100 border-r-[1.5px] border-components-progress-brand-progress', value === 1 && 'border-r-0')} style={{ width: `${value * 100}%` }} />
       <div className={cn('relative flex items-center h-full space-x-0.5 text-util-colors-blue-brand-blue-brand-700')}>
         <div className='system-2xs-medium-uppercase'>score</div>