diff --git a/api/core/app/apps/workflow_app_runner.py b/api/core/app/apps/workflow_app_runner.py index 0e8f8b8dbf..13b7865f55 100644 --- a/api/core/app/apps/workflow_app_runner.py +++ b/api/core/app/apps/workflow_app_runner.py @@ -157,7 +157,7 @@ class WorkflowBasedAppRunner: # Create initial runtime state with variable pool containing environment variables graph_runtime_state = GraphRuntimeState( variable_pool=VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, environment_variables=workflow.environment_variables, ), @@ -272,7 +272,9 @@ class WorkflowBasedAppRunner: ) # init graph - graph = Graph.init(graph_config=graph_config, node_factory=node_factory, root_node_id=node_id) + graph = Graph.init( + graph_config=graph_config, node_factory=node_factory, root_node_id=node_id, skip_validation=True + ) if not graph: raise ValueError("graph not found in workflow") diff --git a/api/core/workflow/graph/graph.py b/api/core/workflow/graph/graph.py index 7be94c2426..31bf6f3b27 100644 --- a/api/core/workflow/graph/graph.py +++ b/api/core/workflow/graph/graph.py @@ -288,6 +288,7 @@ class Graph: graph_config: Mapping[str, object], node_factory: NodeFactory, root_node_id: str | None = None, + skip_validation: bool = False, ) -> Graph: """ Initialize graph @@ -339,8 +340,9 @@ class Graph: root_node=root_node, ) - # Validate the graph structure using built-in validators - get_graph_validator().validate(graph) + if not skip_validation: + # Validate the graph structure using built-in validators + get_graph_validator().validate(graph) return graph diff --git a/api/core/workflow/runtime/variable_pool.py b/api/core/workflow/runtime/variable_pool.py index d205c6ac8f..c4b077fa69 100644 --- a/api/core/workflow/runtime/variable_pool.py +++ b/api/core/workflow/runtime/variable_pool.py @@ -44,7 +44,7 @@ class VariablePool(BaseModel): ) system_variables: SystemVariable = Field( description="System variables", - default_factory=SystemVariable.empty, + default_factory=SystemVariable.default, ) environment_variables: Sequence[Variable] = Field( description="Environment variables.", @@ -271,4 +271,4 @@ class VariablePool(BaseModel): @classmethod def empty(cls) -> VariablePool: """Create an empty variable pool.""" - return cls(system_variables=SystemVariable.empty()) + return cls(system_variables=SystemVariable.default()) diff --git a/api/core/workflow/system_variable.py b/api/core/workflow/system_variable.py index cda8091771..6946e3e6ab 100644 --- a/api/core/workflow/system_variable.py +++ b/api/core/workflow/system_variable.py @@ -3,6 +3,7 @@ from __future__ import annotations from collections.abc import Mapping, Sequence from types import MappingProxyType from typing import Any +from uuid import uuid4 from pydantic import AliasChoices, BaseModel, ConfigDict, Field, model_validator @@ -72,8 +73,8 @@ class SystemVariable(BaseModel): return data @classmethod - def empty(cls) -> SystemVariable: - return cls() + def default(cls) -> SystemVariable: + return cls(workflow_execution_id=str(uuid4())) def to_dict(self) -> dict[SystemVariableKey, Any]: # NOTE: This method is provided for compatibility with legacy code. diff --git a/api/core/workflow/workflow_entry.py b/api/core/workflow/workflow_entry.py index a325afb9fc..b645f29d27 100644 --- a/api/core/workflow/workflow_entry.py +++ b/api/core/workflow/workflow_entry.py @@ -277,7 +277,7 @@ class WorkflowEntry: # init variable pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, environment_variables=[], ) diff --git a/api/services/rag_pipeline/rag_pipeline.py b/api/services/rag_pipeline/rag_pipeline.py index 2d8418900c..ccc6abcc06 100644 --- a/api/services/rag_pipeline/rag_pipeline.py +++ b/api/services/rag_pipeline/rag_pipeline.py @@ -436,7 +436,7 @@ class RagPipelineService: user_inputs=user_inputs, user_id=account.id, variable_pool=VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs=user_inputs, environment_variables=[], conversation_variables=[], diff --git a/api/services/workflow_service.py b/api/services/workflow_service.py index d8c3159178..6404136994 100644 --- a/api/services/workflow_service.py +++ b/api/services/workflow_service.py @@ -675,7 +675,7 @@ class WorkflowService: else: variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs=user_inputs, environment_variables=draft_workflow.environment_variables, conversation_variables=[], @@ -1063,7 +1063,7 @@ def _setup_variable_pool( system_variable.conversation_id = conversation_id system_variable.dialogue_count = 1 else: - system_variable = SystemVariable.empty() + system_variable = SystemVariable.default() # init variable pool variable_pool = VariablePool( diff --git a/api/tests/unit_tests/core/app/apps/test_workflow_app_runner_single_node.py b/api/tests/unit_tests/core/app/apps/test_workflow_app_runner_single_node.py new file mode 100644 index 0000000000..f5903d28bd --- /dev/null +++ b/api/tests/unit_tests/core/app/apps/test_workflow_app_runner_single_node.py @@ -0,0 +1,107 @@ +from __future__ import annotations + +from typing import Any +from unittest.mock import MagicMock, patch + +import pytest + +from core.app.apps.base_app_queue_manager import AppQueueManager +from core.app.apps.workflow.app_runner import WorkflowAppRunner +from core.app.entities.app_invoke_entities import InvokeFrom, WorkflowAppGenerateEntity +from core.workflow.runtime import GraphRuntimeState, VariablePool +from core.workflow.system_variable import SystemVariable +from models.workflow import Workflow + + +def _make_graph_state(): + variable_pool = VariablePool( + system_variables=SystemVariable.default(), + user_inputs={}, + environment_variables=[], + conversation_variables=[], + ) + return MagicMock(), variable_pool, GraphRuntimeState(variable_pool=variable_pool, start_at=0.0) + + +@pytest.mark.parametrize( + ("single_iteration_run", "single_loop_run"), + [ + (WorkflowAppGenerateEntity.SingleIterationRunEntity(node_id="iter", inputs={}), None), + (None, WorkflowAppGenerateEntity.SingleLoopRunEntity(node_id="loop", inputs={})), + ], +) +def test_run_uses_single_node_execution_branch( + single_iteration_run: Any, + single_loop_run: Any, +) -> None: + app_config = MagicMock() + app_config.app_id = "app" + app_config.tenant_id = "tenant" + app_config.workflow_id = "workflow" + + app_generate_entity = MagicMock(spec=WorkflowAppGenerateEntity) + app_generate_entity.app_config = app_config + app_generate_entity.inputs = {} + app_generate_entity.files = [] + app_generate_entity.user_id = "user" + app_generate_entity.invoke_from = InvokeFrom.SERVICE_API + app_generate_entity.workflow_execution_id = "execution-id" + app_generate_entity.task_id = "task-id" + app_generate_entity.call_depth = 0 + app_generate_entity.trace_manager = None + app_generate_entity.single_iteration_run = single_iteration_run + app_generate_entity.single_loop_run = single_loop_run + + workflow = MagicMock(spec=Workflow) + workflow.tenant_id = "tenant" + workflow.app_id = "app" + workflow.id = "workflow" + workflow.type = "workflow" + workflow.version = "v1" + workflow.graph_dict = {"nodes": [], "edges": []} + workflow.environment_variables = [] + + runner = WorkflowAppRunner( + application_generate_entity=app_generate_entity, + queue_manager=MagicMock(spec=AppQueueManager), + variable_loader=MagicMock(), + workflow=workflow, + system_user_id="system-user", + workflow_execution_repository=MagicMock(), + workflow_node_execution_repository=MagicMock(), + ) + + graph, variable_pool, graph_runtime_state = _make_graph_state() + mock_workflow_entry = MagicMock() + mock_workflow_entry.graph_engine = MagicMock() + mock_workflow_entry.graph_engine.layer = MagicMock() + mock_workflow_entry.run.return_value = iter([]) + + with ( + patch("core.app.apps.workflow.app_runner.RedisChannel"), + patch("core.app.apps.workflow.app_runner.redis_client"), + patch("core.app.apps.workflow.app_runner.WorkflowEntry", return_value=mock_workflow_entry) as entry_class, + patch.object( + runner, + "_prepare_single_node_execution", + return_value=( + graph, + variable_pool, + graph_runtime_state, + ), + ) as prepare_single, + patch.object(runner, "_init_graph") as init_graph, + ): + runner.run() + + prepare_single.assert_called_once_with( + workflow=workflow, + single_iteration_run=single_iteration_run, + single_loop_run=single_loop_run, + ) + init_graph.assert_not_called() + + entry_kwargs = entry_class.call_args.kwargs + assert entry_kwargs["invoke_from"] == InvokeFrom.DEBUGGER + assert entry_kwargs["variable_pool"] is variable_pool + assert entry_kwargs["graph_runtime_state"] is graph_runtime_state diff --git a/api/tests/unit_tests/core/workflow/graph/test_graph_skip_validation.py b/api/tests/unit_tests/core/workflow/graph/test_graph_skip_validation.py new file mode 100644 index 0000000000..6858120335 --- /dev/null +++ b/api/tests/unit_tests/core/workflow/graph/test_graph_skip_validation.py @@ -0,0 +1,120 @@ +from __future__ import annotations + +from typing import Any + +import pytest + +from core.app.entities.app_invoke_entities import InvokeFrom +from core.app.workflow.node_factory import DifyNodeFactory +from core.workflow.entities import GraphInitParams +from core.workflow.graph import Graph +from core.workflow.graph.validation import GraphValidationError +from core.workflow.nodes import NodeType +from core.workflow.runtime import GraphRuntimeState, VariablePool +from core.workflow.system_variable import SystemVariable +from models.enums import UserFrom + + +def _build_iteration_graph(node_id: str) -> dict[str, Any]: + return { + "nodes": [ + { + "id": node_id, + "data": { + "type": "iteration", + "title": "Iteration", + "iterator_selector": ["start", "items"], + "output_selector": [node_id, "output"], + }, + } + ], + "edges": [], + } + + +def _build_loop_graph(node_id: str) -> dict[str, Any]: + return { + "nodes": [ + { + "id": node_id, + "data": { + "type": "loop", + "title": "Loop", + "loop_count": 1, + "break_conditions": [], + "logical_operator": "and", + "loop_variables": [], + "outputs": {}, + }, + } + ], + "edges": [], + } + + +def _make_factory(graph_config: dict[str, Any]) -> DifyNodeFactory: + graph_init_params = GraphInitParams( + tenant_id="tenant", + app_id="app", + workflow_id="workflow", + graph_config=graph_config, + user_id="user", + user_from=UserFrom.ACCOUNT, + invoke_from=InvokeFrom.DEBUGGER, + call_depth=0, + ) + graph_runtime_state = GraphRuntimeState( + variable_pool=VariablePool( + system_variables=SystemVariable.default(), + user_inputs={}, + environment_variables=[], + ), + start_at=0.0, + ) + return DifyNodeFactory(graph_init_params=graph_init_params, graph_runtime_state=graph_runtime_state) + + +def test_iteration_root_requires_skip_validation(): + node_id = "iteration-node" + graph_config = _build_iteration_graph(node_id) + node_factory = _make_factory(graph_config) + + with pytest.raises(GraphValidationError): + Graph.init( + graph_config=graph_config, + node_factory=node_factory, + root_node_id=node_id, + ) + + graph = Graph.init( + graph_config=graph_config, + node_factory=node_factory, + root_node_id=node_id, + skip_validation=True, + ) + + assert graph.root_node.id == node_id + assert graph.root_node.node_type == NodeType.ITERATION + + +def test_loop_root_requires_skip_validation(): + node_id = "loop-node" + graph_config = _build_loop_graph(node_id) + node_factory = _make_factory(graph_config) + + with pytest.raises(GraphValidationError): + Graph.init( + graph_config=graph_config, + node_factory=node_factory, + root_node_id=node_id, + ) + + graph = Graph.init( + graph_config=graph_config, + node_factory=node_factory, + root_node_id=node_id, + skip_validation=True, + ) + + assert graph.root_node.id == node_id + assert graph.root_node.node_type == NodeType.LOOP diff --git a/api/tests/unit_tests/core/workflow/nodes/http_request/test_http_request_executor.py b/api/tests/unit_tests/core/workflow/nodes/http_request/test_http_request_executor.py index 2a9db2d328..cefc4967ac 100644 --- a/api/tests/unit_tests/core/workflow/nodes/http_request/test_http_request_executor.py +++ b/api/tests/unit_tests/core/workflow/nodes/http_request/test_http_request_executor.py @@ -16,7 +16,7 @@ from core.workflow.system_variable import SystemVariable def test_executor_with_json_body_and_number_variable(): # Prepare the variable pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["pre_node_id", "number"], 42) @@ -69,7 +69,7 @@ def test_executor_with_json_body_and_number_variable(): def test_executor_with_json_body_and_object_variable(): # Prepare the variable pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["pre_node_id", "object"], {"name": "John Doe", "age": 30, "email": "john@example.com"}) @@ -124,7 +124,7 @@ def test_executor_with_json_body_and_object_variable(): def test_executor_with_json_body_and_nested_object_variable(): # Prepare the variable pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["pre_node_id", "object"], {"name": "John Doe", "age": 30, "email": "john@example.com"}) @@ -178,7 +178,7 @@ def test_executor_with_json_body_and_nested_object_variable(): def test_extract_selectors_from_template_with_newline(): - variable_pool = VariablePool(system_variables=SystemVariable.empty()) + variable_pool = VariablePool(system_variables=SystemVariable.default()) variable_pool.add(("node_id", "custom_query"), "line1\nline2") node_data = HttpRequestNodeData( title="Test JSON Body with Nested Object Variable", @@ -205,7 +205,7 @@ def test_extract_selectors_from_template_with_newline(): def test_executor_with_form_data(): # Prepare the variable pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["pre_node_id", "text_field"], "Hello, World!") @@ -290,7 +290,7 @@ def test_init_headers(): return Executor( node_data=node_data, timeout=timeout, - variable_pool=VariablePool(system_variables=SystemVariable.empty()), + variable_pool=VariablePool(system_variables=SystemVariable.default()), ) executor = create_executor("aa\n cc:") @@ -324,7 +324,7 @@ def test_init_params(): return Executor( node_data=node_data, timeout=timeout, - variable_pool=VariablePool(system_variables=SystemVariable.empty()), + variable_pool=VariablePool(system_variables=SystemVariable.default()), ) # Test basic key-value pairs @@ -355,7 +355,7 @@ def test_init_params(): def test_empty_api_key_raises_error_bearer(): """Test that empty API key raises AuthorizationConfigError for bearer auth.""" - variable_pool = VariablePool(system_variables=SystemVariable.empty()) + variable_pool = VariablePool(system_variables=SystemVariable.default()) node_data = HttpRequestNodeData( title="test", method="get", @@ -379,7 +379,7 @@ def test_empty_api_key_raises_error_bearer(): def test_empty_api_key_raises_error_basic(): """Test that empty API key raises AuthorizationConfigError for basic auth.""" - variable_pool = VariablePool(system_variables=SystemVariable.empty()) + variable_pool = VariablePool(system_variables=SystemVariable.default()) node_data = HttpRequestNodeData( title="test", method="get", @@ -403,7 +403,7 @@ def test_empty_api_key_raises_error_basic(): def test_empty_api_key_raises_error_custom(): """Test that empty API key raises AuthorizationConfigError for custom auth.""" - variable_pool = VariablePool(system_variables=SystemVariable.empty()) + variable_pool = VariablePool(system_variables=SystemVariable.default()) node_data = HttpRequestNodeData( title="test", method="get", @@ -427,7 +427,7 @@ def test_empty_api_key_raises_error_custom(): def test_whitespace_only_api_key_raises_error(): """Test that whitespace-only API key raises AuthorizationConfigError.""" - variable_pool = VariablePool(system_variables=SystemVariable.empty()) + variable_pool = VariablePool(system_variables=SystemVariable.default()) node_data = HttpRequestNodeData( title="test", method="get", @@ -451,7 +451,7 @@ def test_whitespace_only_api_key_raises_error(): def test_valid_api_key_works(): """Test that valid API key works correctly for bearer auth.""" - variable_pool = VariablePool(system_variables=SystemVariable.empty()) + variable_pool = VariablePool(system_variables=SystemVariable.default()) node_data = HttpRequestNodeData( title="test", method="get", @@ -487,7 +487,7 @@ def test_executor_with_json_body_and_unquoted_uuid_variable(): test_uuid = "57eeeeb1-450b-482c-81b9-4be77e95dee2" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["pre_node_id", "uuid"], test_uuid) @@ -531,7 +531,7 @@ def test_executor_with_json_body_and_unquoted_uuid_with_newlines(): test_uuid = "57eeeeb1-450b-482c-81b9-4be77e95dee2" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["pre_node_id", "uuid"], test_uuid) @@ -569,7 +569,7 @@ def test_executor_with_json_body_and_unquoted_uuid_with_newlines(): def test_executor_with_json_body_preserves_numbers_and_strings(): """Test that numbers are preserved and string values are properly quoted.""" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) variable_pool.add(["node", "count"], 42) diff --git a/api/tests/unit_tests/core/workflow/nodes/llm/test_node.py b/api/tests/unit_tests/core/workflow/nodes/llm/test_node.py index 77264022bc..3d1b8b2f27 100644 --- a/api/tests/unit_tests/core/workflow/nodes/llm/test_node.py +++ b/api/tests/unit_tests/core/workflow/nodes/llm/test_node.py @@ -86,7 +86,7 @@ def graph_init_params() -> GraphInitParams: @pytest.fixture def graph_runtime_state() -> GraphRuntimeState: variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) return GraphRuntimeState( diff --git a/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_file_conversion.py b/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_file_conversion.py index ead2334473..d8f6b41f89 100644 --- a/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_file_conversion.py +++ b/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_file_conversion.py @@ -111,7 +111,7 @@ def test_webhook_node_file_conversion_to_file_variable(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -184,7 +184,7 @@ def test_webhook_node_file_conversion_with_missing_files(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -219,7 +219,7 @@ def test_webhook_node_file_conversion_with_none_file(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -256,7 +256,7 @@ def test_webhook_node_file_conversion_with_non_dict_file(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -300,7 +300,7 @@ def test_webhook_node_file_conversion_mixed_parameters(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -370,7 +370,7 @@ def test_webhook_node_different_file_types(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -430,7 +430,7 @@ def test_webhook_node_file_conversion_with_non_dict_wrapper(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, diff --git a/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_node.py b/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_node.py index bbb5511923..3b5aedebca 100644 --- a/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_node.py +++ b/api/tests/unit_tests/core/workflow/nodes/webhook/test_webhook_node.py @@ -75,7 +75,7 @@ def test_webhook_node_basic_initialization(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) @@ -118,7 +118,7 @@ def test_webhook_node_run_with_headers(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": { @@ -154,7 +154,7 @@ def test_webhook_node_run_with_query_params(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -190,7 +190,7 @@ def test_webhook_node_run_with_body_params(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -249,7 +249,7 @@ def test_webhook_node_run_with_file_params(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, @@ -302,7 +302,7 @@ def test_webhook_node_run_mixed_parameters(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {"Authorization": "Bearer token"}, @@ -342,7 +342,7 @@ def test_webhook_node_run_empty_webhook_data(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, # No webhook_data ) @@ -368,7 +368,7 @@ def test_webhook_node_run_case_insensitive_headers(): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": { @@ -398,7 +398,7 @@ def test_webhook_node_variable_pool_user_inputs(): # Add some additional variables to the pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": {"headers": {}, "query_params": {}, "body": {}, "files": {}}, "other_var": "should_be_included", @@ -429,7 +429,7 @@ def test_webhook_node_different_methods(method): ) variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={ "webhook_data": { "headers": {}, diff --git a/api/tests/unit_tests/core/workflow/test_workflow_entry.py b/api/tests/unit_tests/core/workflow/test_workflow_entry.py index b38e070ffc..27ffa455d6 100644 --- a/api/tests/unit_tests/core/workflow/test_workflow_entry.py +++ b/api/tests/unit_tests/core/workflow/test_workflow_entry.py @@ -127,7 +127,7 @@ class TestWorkflowEntry: return node_config workflow = StubWorkflow() - variable_pool = VariablePool(system_variables=SystemVariable.empty(), user_inputs={}) + variable_pool = VariablePool(system_variables=SystemVariable.default(), user_inputs={}) expected_limits = CodeNodeLimits( max_string_length=dify_config.CODE_MAX_STRING_LENGTH, max_number=dify_config.CODE_MAX_NUMBER, @@ -157,7 +157,7 @@ class TestWorkflowEntry: # Initialize variable pool with environment variables env_var = StringVariable(name="API_KEY", value="existing_key") variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), environment_variables=[env_var], user_inputs={}, ) @@ -198,7 +198,7 @@ class TestWorkflowEntry: # Initialize variable pool with conversation variables conv_var = StringVariable(name="last_message", value="Hello") variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), conversation_variables=[conv_var], user_inputs={}, ) @@ -239,7 +239,7 @@ class TestWorkflowEntry: """Test mapping regular node variables from user inputs to variable pool.""" # Initialize empty variable pool variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) @@ -281,7 +281,7 @@ class TestWorkflowEntry: def test_mapping_user_inputs_with_file_handling(self): """Test mapping file inputs from user inputs to variable pool.""" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) @@ -340,7 +340,7 @@ class TestWorkflowEntry: def test_mapping_user_inputs_missing_variable_error(self): """Test that mapping raises error when required variable is missing.""" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) @@ -366,7 +366,7 @@ class TestWorkflowEntry: def test_mapping_user_inputs_with_alternative_key_format(self): """Test mapping with alternative key format (without node prefix).""" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) @@ -396,7 +396,7 @@ class TestWorkflowEntry: def test_mapping_user_inputs_with_complex_selectors(self): """Test mapping with complex node variable keys.""" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, ) @@ -432,7 +432,7 @@ class TestWorkflowEntry: def test_mapping_user_inputs_invalid_node_variable(self): """Test that mapping handles invalid node variable format.""" variable_pool = VariablePool( - system_variables=SystemVariable.empty(), + system_variables=SystemVariable.default(), user_inputs={}, )