opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-09-10 17:10:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: validate missing text indexing technique (#35941)

Browse Source
This commit is contained in:
juyua9 2026-05-12 13:07:03 +08:00 committed by GitHub
parent 4fd4615c56
commit 4bb987eca3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/controllers/service_api/dataset/document.py
View File

@ -136,7 +136,7 @@ def _create_document_by_text(tenant_id: str, dataset_id: UUID) -> tuple[Mapping[
if not dataset: if not dataset:
raise ValueError("Dataset does not exist.") raise ValueError("Dataset does not exist.")
if not dataset.indexing_technique and not args["indexing_technique"]: if not dataset.indexing_technique and not args.get("indexing_technique"):
raise ValueError("indexing_technique is required.") raise ValueError("indexing_technique is required.")
embedding_model_provider = payload.embedding_model_provider embedding_model_provider = payload.embedding_model_provider

6
api/tests/unit_tests/controllers/service_api/dataset/test_document.py
View File

@ -1057,8 +1057,8 @@ class TestDocumentAddByTextApi:
"""Test error when both dataset and payload lack indexing_technique. """Test error when both dataset and payload lack indexing_technique.
When ``indexing_technique`` is ``None`` in the payload, ``model_dump(exclude_none=True)`` When ``indexing_technique`` is ``None`` in the payload, ``model_dump(exclude_none=True)``
omits the key. The production code accesses ``args["indexing_technique"]`` which raises omits the key. The service API should still raise the same validation error as other
``KeyError`` before the ``ValueError`` guard can fire. document creation paths instead of leaking a ``KeyError`` from the dumped payload dict.
""" """
# Arrange — neutralise billing decorators # Arrange — neutralise billing decorators
self._setup_billing_mocks(mock_validate_token, mock_feature_svc, mock_tenant.id) self._setup_billing_mocks(mock_validate_token, mock_feature_svc, mock_tenant.id)
@ -1074,7 +1074,7 @@ class TestDocumentAddByTextApi:
headers={"Authorization": "Bearer test_token"}, headers={"Authorization": "Bearer test_token"},
): ):
api = DocumentAddByTextApi() api = DocumentAddByTextApi()
with pytest.raises(KeyError): with pytest.raises(ValueError, match="indexing_technique is required."):
api.post(tenant_id=mock_tenant.id, dataset_id=mock_dataset.id) api.post(tenant_id=mock_tenant.id, dataset_id=mock_dataset.id)