From 4cba23813483f78eaed590ed16497128e55a82ca Mon Sep 17 00:00:00 2001 From: Jingyi-Dify Date: Thu, 7 May 2026 17:56:40 -0700 Subject: [PATCH] docs: update iconify review guidance - generalize generated icon diff review guidance for intrinsic width and height changes --- .agents/skills/frontend-code-review/references/performance.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.agents/skills/frontend-code-review/references/performance.md b/.agents/skills/frontend-code-review/references/performance.md index 253b52f47a..d91ddafee9 100644 --- a/.agents/skills/frontend-code-review/references/performance.md +++ b/.agents/skills/frontend-code-review/references/performance.md @@ -53,4 +53,4 @@ Category: Performance New custom SVG icons should be added to `packages/iconify-collections/assets/...`, generated with `pnpm --filter @dify/iconify-collections generate`, checked with `pnpm --filter @dify/iconify-collections check:dimensions`, and consumed through Tailwind `i-custom-*` classes. Do not add new generated React icon components or JSON files under `web/app/components/base/icons/src/...` for new custom SVG icons. -When reviewing generated `packages/iconify-collections/custom-*/icons.json` diffs, verify unrelated existing icons did not lose or change intrinsic `width` / `height`, especially layout-sensitive groups such as `main-nav-*`. +When reviewing generated `packages/iconify-collections/custom-*/icons.json` diffs, verify unrelated existing icons did not lose or change intrinsic `width` / `height`. \ No newline at end of file