From 4ea4d227c6006ca342496bbd670bfa19e44c63be Mon Sep 17 00:00:00 2001
From: twwu <twwu@dify.ai>
Date: Wed, 9 Jul 2025 14:44:56 +0800
Subject: [PATCH] refactor: Remove unused file support types logic from
 CreateFormPipeline component

---
 .../online-drive/file-list/list/index.tsx     | 14 ++------
 .../documents/create-from-pipeline/index.tsx  | 33 ++++---------------
 2 files changed, 9 insertions(+), 38 deletions(-)

diff --git a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/list/index.tsx b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/list/index.tsx
index 22c3f408a5..9060862d8e 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/list/index.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/data-source/online-drive/file-list/list/index.tsx
@@ -1,12 +1,10 @@
-import React, { useEffect, useMemo, useRef } from 'react'
-import { type OnlineDriveFile, OnlineDriveFileType } from '@/models/pipeline'
+import React, { useEffect, useRef } from 'react'
+import type { OnlineDriveFile } from '@/models/pipeline'
 import Item from './item'
 import EmptyFolder from './empty-folder'
 import EmptySearchResult from './empty-search-result'
 import Loading from '@/app/components/base/loading'
 import { RiLoader2Line } from '@remixicon/react'
-import { useFileSupportTypes } from '@/service/use-common'
-import { getFileExtension } from './utils'
 import { useDataSourceStore } from '../../../store'
 
 type FileListProps = {
@@ -64,11 +62,6 @@ const List = ({
   const isPartLoading = isLoading && fileList.length > 0
   const isEmptyFolder = !isLoading && fileList.length === 0 && keywords.length === 0
   const isSearchResultEmpty = !isLoading && fileList.length === 0 && keywords.length > 0
-  const { data: supportFileTypesRes } = useFileSupportTypes()
-  const supportedFileTypes = useMemo(() => {
-    if (!supportFileTypesRes) return []
-    return Array.from(new Set(supportFileTypesRes.allowed_extensions.map(item => item.toLowerCase())))
-  }, [supportFileTypesRes])
 
   return (
     <div className='grow overflow-hidden p-1 pt-0'>
@@ -92,14 +85,11 @@ const List = ({
           {
             fileList.map((file) => {
               const isSelected = selectedFileList.includes(file.key)
-              const extension = getFileExtension(file.key)
-              const disabled = file.type === OnlineDriveFileType.file && !supportedFileTypes.includes(extension)
               return (
                 <Item
                   key={file.key}
                   file={file}
                   isSelected={isSelected}
-                  disabled={disabled}
                   onSelect={handleSelectFile}
                   onOpen={handleOpenFolder}
                   isMultipleChoice={!isInPipeline}
diff --git a/web/app/components/datasets/documents/create-from-pipeline/index.tsx b/web/app/components/datasets/documents/create-from-pipeline/index.tsx
index 6b16a5748b..aef577c74b 100644
--- a/web/app/components/datasets/documents/create-from-pipeline/index.tsx
+++ b/web/app/components/datasets/documents/create-from-pipeline/index.tsx
@@ -30,8 +30,7 @@ import { TransferMethod } from '@/types/app'
 import { useAddDocumentsSteps, useLocalFile, useOnlineDocuments, useOnlineDrive, useWebsiteCrawl } from './hooks'
 import DataSourceProvider from './data-source/store/provider'
 import { useDataSourceStore } from './data-source/store'
-import { useFileSupportTypes, useFileUploadConfig } from '@/service/use-common'
-import { getFileExtension } from './data-source/online-drive/file-list/list/utils'
+import { useFileUploadConfig } from '@/service/use-common'
 
 const CreateFormPipeline = () => {
   const { t } = useTranslation()
@@ -49,7 +48,6 @@ const CreateFormPipeline = () => {
 
   const { data: pipelineInfo, isFetching: isFetchingPipelineInfo } = usePublishedPipelineInfo(pipelineId || '')
   const { data: fileUploadConfigResponse } = useFileUploadConfig()
-  const { data: supportFileTypesRes } = useFileSupportTypes()
 
   const {
     steps,
@@ -113,11 +111,6 @@ const CreateFormPipeline = () => {
     return false
   }, [datasource, datasourceType, isShowVectorSpaceFull, fileList.length, allFileLoaded, onlineDocuments.length, websitePages.length, selectedFileList.length])
 
-  const supportedFileTypes = useMemo(() => {
-    if (!supportFileTypesRes) return []
-    return Array.from(new Set(supportFileTypesRes.allowed_extensions.map(item => item.toLowerCase())))
-  }, [supportFileTypesRes])
-
   const fileUploadConfig = useMemo(() => fileUploadConfigResponse ?? {
     file_size_limit: 15,
     batch_count_limit: 5,
@@ -131,28 +124,20 @@ const CreateFormPipeline = () => {
     if (datasourceType === DatasourceType.onlineDrive) {
       const isBucketList = onlineDriveFileList.some(file => file.type === 'bucket')
       return !isBucketList && onlineDriveFileList.filter((item) => {
-        if (item.type === 'bucket') return false
-        if (item.type === 'folder') return true
-        if (item.type === 'file')
-          return supportedFileTypes.includes(getFileExtension(item.key))
-        return false
+        return item.type !== 'bucket'
       }).length > 0
     }
-  }, [currentWorkspace?.pages.length, datasourceType, onlineDriveFileList, supportedFileTypes])
+  }, [currentWorkspace?.pages.length, datasourceType, onlineDriveFileList])
 
   const totalOptions = useMemo(() => {
     if (datasourceType === DatasourceType.onlineDocument)
       return currentWorkspace?.pages.length
     if (datasourceType === DatasourceType.onlineDrive) {
       return onlineDriveFileList.filter((item) => {
-        if (item.type === 'bucket') return false
-        if (item.type === 'folder') return true
-        if (item.type === 'file')
-          return supportedFileTypes.includes(getFileExtension(item.key))
-        return false
+        return item.type !== 'bucket'
       }).length
     }
-  }, [currentWorkspace?.pages.length, datasourceType, onlineDriveFileList, supportedFileTypes])
+  }, [currentWorkspace?.pages.length, datasourceType, onlineDriveFileList])
 
   const selectedOptions = useMemo(() => {
     if (datasourceType === DatasourceType.onlineDocument)
@@ -324,18 +309,14 @@ const CreateFormPipeline = () => {
     }
     if (datasourceType === DatasourceType.onlineDrive) {
       const allKeys = onlineDriveFileList.filter((item) => {
-        if (item.type === 'bucket') return false
-        if (item.type === 'folder') return true
-        if (item.type === 'file')
-          return supportedFileTypes.includes(getFileExtension(item.key))
-        return false
+        return item.type !== 'bucket'
       }).map(file => file.key)
       if (selectedFileList.length < allKeys.length)
         setSelectedFileList(allKeys)
       else
         setSelectedFileList([])
     }
-  }, [PagesMapAndSelectedPagesId, currentWorkspace?.pages, dataSourceStore, datasourceType, onlineDocuments.length, onlineDriveFileList, selectedFileList.length, supportedFileTypes])
+  }, [PagesMapAndSelectedPagesId, currentWorkspace?.pages, dataSourceStore, datasourceType, onlineDocuments.length, onlineDriveFileList, selectedFileList.length])
 
   if (isFetchingPipelineInfo) {
     return (