From 598dd1f816f4661cdceff5292d3a603c46b528b3 Mon Sep 17 00:00:00 2001
From: Guangdong Liu <liugddx@gmail.com>
Date: Sat, 18 Oct 2025 11:43:24 +0800
Subject: [PATCH] fix: allow optional config parameter and conditionally
 include message file ID (#26960)

---
 api/factories/file_factory.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/api/factories/file_factory.py b/api/factories/file_factory.py
index 735fff53d1..231e805460 100644
--- a/api/factories/file_factory.py
+++ b/api/factories/file_factory.py
@@ -21,7 +21,7 @@ def build_from_message_files(
     *,
     message_files: Sequence["MessageFile"],
     tenant_id: str,
-    config: FileUploadConfig,
+    config: FileUploadConfig | None = None,
 ) -> Sequence[File]:
     results = [
         build_from_message_file(message_file=file, tenant_id=tenant_id, config=config)
@@ -35,15 +35,18 @@ def build_from_message_file(
     *,
     message_file: "MessageFile",
     tenant_id: str,
-    config: FileUploadConfig,
+    config: FileUploadConfig | None,
 ):
     mapping = {
         "transfer_method": message_file.transfer_method,
         "url": message_file.url,
-        "id": message_file.id,
         "type": message_file.type,
     }
 
+    # Only include id if it exists (message_file has been committed to DB)
+    if message_file.id:
+        mapping["id"] = message_file.id
+
     # Set the correct ID field based on transfer method
     if message_file.transfer_method == FileTransferMethod.TOOL_FILE:
         mapping["tool_file_id"] = message_file.upload_file_id