From 6fb657a89ed99051547311cadcb70fda2c64c185 Mon Sep 17 00:00:00 2001
From: Harry <xh001x@hotmail.com>
Date: Mon, 13 Oct 2025 11:22:25 +0800
Subject: [PATCH] refactor(subscription): enhance subscription count handling
 in selector view

- Introduced a subscriptionCount variable to improve readability and performance when checking the number of subscriptions.
- Updated the rendering logic to use subscriptionCount, ensuring consistent and clear display of subscription information in the component.
---
 .../subscription-list/selector-view.tsx                    | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/web/app/components/plugins/plugin-detail-panel/subscription-list/selector-view.tsx b/web/app/components/plugins/plugin-detail-panel/subscription-list/selector-view.tsx
index 0c0dee1911..2f1bfe583d 100644
--- a/web/app/components/plugins/plugin-detail-panel/subscription-list/selector-view.tsx
+++ b/web/app/components/plugins/plugin-detail-panel/subscription-list/selector-view.tsx
@@ -24,6 +24,7 @@ export const SubscriptionSelectorView: React.FC<SubscriptionSelectorProps> = ({
 }) => {
   const { t } = useTranslation()
   const [deletedSubscription, setDeletedSubscription] = useState<TriggerSubscription | null>(null)
+  const subscriptionCount = subscriptions?.length || 0
 
   if (isLoading) {
     return (
@@ -35,10 +36,10 @@ export const SubscriptionSelectorView: React.FC<SubscriptionSelectorProps> = ({
 
   return (
     <div className='w-[320px] p-1'>
-      {subscriptions?.length && <div className='ml-7 mr-1.5 mt-0.5 flex items-center justify-between'>
+      {subscriptionCount > 0 && <div className='ml-7 mr-1.5 mt-0.5 flex items-center justify-between'>
         <div className='flex shrink-0 items-center gap-1'>
           <span className='system-sm-semibold-uppercase text-text-secondary'>
-            {t('pluginTrigger.subscription.listNum', { num: subscriptions?.length || 0 })}
+            {t('pluginTrigger.subscription.listNum', { num: subscriptionCount })}
           </span>
           <Tooltip popupContent={t('pluginTrigger.subscription.list.tip')} />
         </div>
@@ -47,7 +48,7 @@ export const SubscriptionSelectorView: React.FC<SubscriptionSelectorProps> = ({
         />
       </div>}
       <div className='max-h-[320px] overflow-y-auto'>
-        {subscriptions?.length ? (
+        {subscriptionCount > 0 ? (
           <>
             {subscriptions?.map(subscription => (
               <button