refactor: add missing @override decorators to method overrides (#36501)

Co-authored-by: EvanYao826 <evanyao826@gmail.com>
Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: WH-2099 <wh2099@pm.me>
This commit is contained in:
EvanYao 2026-05-23 17:56:36 +08:00 committed by GitHub
parent 8d99326fb3
commit 72ee50c74f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 12 additions and 4 deletions

View File

@ -1,5 +1,5 @@
from collections.abc import Mapping from collections.abc import Mapping
from typing import Any from typing import Any, override
from pydantic import Field from pydantic import Field
from pydantic.fields import FieldInfo from pydantic.fields import FieldInfo
@ -48,6 +48,7 @@ class ApolloSettingsSource(RemoteSettingsSource):
self.namespace = configs["APOLLO_NAMESPACE"] self.namespace = configs["APOLLO_NAMESPACE"]
self.remote_configs = self.client.get_all_dicts(self.namespace) self.remote_configs = self.client.get_all_dicts(self.namespace)
@override
def get_field_value(self, field: FieldInfo, field_name: str) -> tuple[Any, str, bool]: def get_field_value(self, field: FieldInfo, field_name: str) -> tuple[Any, str, bool]:
if not isinstance(self.remote_configs, dict): if not isinstance(self.remote_configs, dict):
raise ValueError(f"remote configs is not dict, but {type(self.remote_configs)}") raise ValueError(f"remote configs is not dict, but {type(self.remote_configs)}")

View File

@ -1,7 +1,7 @@
import logging import logging
import os import os
from collections.abc import Mapping from collections.abc import Mapping
from typing import Any from typing import Any, override
from pydantic.fields import FieldInfo from pydantic.fields import FieldInfo
@ -41,6 +41,7 @@ class NacosSettingsSource(RemoteSettingsSource):
except Exception as e: except Exception as e:
raise RuntimeError(f"Failed to parse config: {e}") raise RuntimeError(f"Failed to parse config: {e}")
@override
def get_field_value(self, field: FieldInfo, field_name: str) -> tuple[Any, str, bool]: def get_field_value(self, field: FieldInfo, field_name: str) -> tuple[Any, str, bool]:
field_value = self.remote_configs.get(field_name) field_value = self.remote_configs.get(field_name)
if field_value is None: if field_value is None:

View File

@ -10,7 +10,7 @@ import threading
from abc import ABC, abstractmethod from abc import ABC, abstractmethod
from collections.abc import Callable, Generator from collections.abc import Callable, Generator
from contextlib import AbstractContextManager, contextmanager from contextlib import AbstractContextManager, contextmanager
from typing import Any, Protocol, final, runtime_checkable from typing import Any, Protocol, final, override, runtime_checkable
from pydantic import BaseModel from pydantic import BaseModel
@ -133,10 +133,12 @@ class NullAppContext(AppContext):
self._config = config or {} self._config = config or {}
self._extensions: dict[str, Any] = {} self._extensions: dict[str, Any] = {}
@override
def get_config(self, key: str, default: Any = None) -> Any: def get_config(self, key: str, default: Any = None) -> Any:
"""Get configuration value by key.""" """Get configuration value by key."""
return self._config.get(key, default) return self._config.get(key, default)
@override
def get_extension(self, name: str) -> Any: def get_extension(self, name: str) -> Any:
"""Get extension by name.""" """Get extension by name."""
return self._extensions.get(name) return self._extensions.get(name)
@ -146,6 +148,7 @@ class NullAppContext(AppContext):
self._extensions[name] = extension self._extensions[name] = extension
@contextmanager @contextmanager
@override
def enter(self) -> Generator[None, None, None]: def enter(self) -> Generator[None, None, None]:
"""Enter null context (no-op).""" """Enter null context (no-op)."""
yield yield

View File

@ -6,7 +6,7 @@ import contextvars
import threading import threading
from collections.abc import Generator from collections.abc import Generator
from contextlib import contextmanager from contextlib import contextmanager
from typing import Any, final from typing import Any, final, override
from flask import Flask, current_app, g from flask import Flask, current_app, g
@ -30,15 +30,18 @@ class FlaskAppContext(AppContext):
""" """
self._flask_app = flask_app self._flask_app = flask_app
@override
def get_config(self, key: str, default: Any = None) -> Any: def get_config(self, key: str, default: Any = None) -> Any:
"""Get configuration value from Flask app config.""" """Get configuration value from Flask app config."""
return self._flask_app.config.get(key, default) return self._flask_app.config.get(key, default)
@override
def get_extension(self, name: str) -> Any: def get_extension(self, name: str) -> Any:
"""Get Flask extension by name.""" """Get Flask extension by name."""
return self._flask_app.extensions.get(name) return self._flask_app.extensions.get(name)
@contextmanager @contextmanager
@override
def enter(self) -> Generator[None, None, None]: def enter(self) -> Generator[None, None, None]:
"""Enter Flask app context.""" """Enter Flask app context."""
with self._flask_app.app_context(): with self._flask_app.app_context():