From 73007362b39079afdea400414692c29908ef93c5 Mon Sep 17 00:00:00 2001 From: twwu Date: Tue, 16 Sep 2025 18:21:08 +0800 Subject: [PATCH] fix: Remove customContainer prop from PortalToFollowElem and adjust padding in dropdown component --- .../app-sidebar/dataset-info/dropdown.tsx | 1 - .../base/portal-to-follow-elem/index.tsx | 16 ++-------------- .../datasets/extra-info/service-api/index.tsx | 1 - 3 files changed, 2 insertions(+), 16 deletions(-) diff --git a/web/app/components/app-sidebar/dataset-info/dropdown.tsx b/web/app/components/app-sidebar/dataset-info/dropdown.tsx index 94118f04e3..ff110f70bd 100644 --- a/web/app/components/app-sidebar/dataset-info/dropdown.tsx +++ b/web/app/components/app-sidebar/dataset-info/dropdown.tsx @@ -114,7 +114,6 @@ const DropDown = ({ } : { mainAxis: 4, }} - customContainer={document.body} > diff --git a/web/app/components/base/portal-to-follow-elem/index.tsx b/web/app/components/base/portal-to-follow-elem/index.tsx index 430c49f4ba..55891bd8d2 100644 --- a/web/app/components/base/portal-to-follow-elem/index.tsx +++ b/web/app/components/base/portal-to-follow-elem/index.tsx @@ -4,7 +4,6 @@ import { FloatingPortal, autoUpdate, flip, - hide, offset, shift, size, @@ -31,7 +30,6 @@ export type PortalToFollowElemOptions = { offset?: number | OffsetOptions onOpenChange?: (open: boolean) => void triggerPopupSameWidth?: boolean - customContainer?: HTMLElement | null } export function usePortalToFollowElem({ @@ -40,9 +38,7 @@ export function usePortalToFollowElem({ offset: offsetValue = 0, onOpenChange: setControlledOpen, triggerPopupSameWidth, - customContainer = null, }: PortalToFollowElemOptions = {}) { - const container = customContainer || document.getElementById('workflow-container') || document.body const [localOpen, setLocalOpen] = useState(false) const open = controlledOpen ?? localOpen const handleOpenChange = useCallback((newOpen: boolean) => { @@ -60,17 +56,9 @@ export function usePortalToFollowElem({ flip({ crossAxis: placement.includes('-'), fallbackAxisSideDirection: 'start', - padding: 8, - }), - shift({ - padding: 8, - boundary: container, - altBoundary: true, - }), - hide({ - // hide when the reference element is not visible - boundary: container, + padding: 5, }), + shift({ padding: 5 }), size({ apply({ rects, elements }) { if (triggerPopupSameWidth) diff --git a/web/app/components/datasets/extra-info/service-api/index.tsx b/web/app/components/datasets/extra-info/service-api/index.tsx index 3daa58a021..b1843682ee 100644 --- a/web/app/components/datasets/extra-info/service-api/index.tsx +++ b/web/app/components/datasets/extra-info/service-api/index.tsx @@ -34,7 +34,6 @@ const ServiceApi = ({ mainAxis: 4, crossAxis: -4, }} - customContainer={document.body} >