refactor(api): remove redundant typing.cast calls (#37124)

api/core/workflow/generator/runner.py

@@ -434,7 +434,7 @@ class WorkflowGenerator:
             if isinstance(parsed, dict):
                 if attempt > 0:
                     logger.info("Workflow generator: %s JSON parse recovered on retry", stage)
-                return cast(dict[str, Any], parsed)
+                return parsed
             last_detail = f"Non-object JSON: {type(parsed).__name__}"
             logger.info("Workflow generator: %s non-object JSON on attempt %s", stage, attempt + 1)
         raise _StageJSONError(stage, last_detail or "JSON parse failed")

api/core/workflow/nodes/agent_v2/plugin_tools_builder.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from collections.abc import Mapping
-from typing import Any, Protocol, cast
+from typing import Any, Protocol
 
 from dify_agent.layers.dify_plugin import (
     DifyPluginCredentialValue,
@@ -197,7 +197,7 @@ class WorkflowAgentPluginToolsBuilder:
             credentials=self._normalize_credentials(runtime.credentials, tool_name=tool_config.tool_name),
             runtime_parameters=runtime_parameters,
             parameters=parameters,
-            parameters_json_schema=cast(dict[str, Any], tool_runtime.get_llm_parameters_json_schema()),
+            parameters_json_schema=tool_runtime.get_llm_parameters_json_schema(),
         )
 
     @staticmethod

api/enterprise/telemetry/enterprise_trace.py

@@ -720,7 +720,7 @@ class EnterpriseOtelTrace:
 
         docs: list[dict[str, Any]] = []
         documents_any: Any = info.documents
-        documents_list: list[Any] = cast(list[Any], documents_any) if isinstance(documents_any, list) else []
+        documents_list: list[Any] = documents_any if isinstance(documents_any, list) else []
         for entry in documents_list:
             if isinstance(entry, dict):
                 entry_dict: dict[str, Any] = cast(dict[str, Any], entry)

api/models/dataset.py

@@ -1226,7 +1226,7 @@ class DatasetKeywordTable(TypeBase):
                         items = cast(dict[str, Any], dct).items()
                         for keyword, node_idxs in items:
                             if isinstance(node_idxs, list):
-                                result[keyword] = set(cast(list[Any], node_idxs))
+                                result[keyword] = set(node_idxs)
                             else:
                                 result[keyword] = node_idxs
                         return result

api/models/model.py

@@ -1153,7 +1153,7 @@ class Conversation(Base):
                     tenant_resolver=tenant_resolver,
                 )
             elif isinstance(value, list):
-                value_list = cast(list[Any], value)
+                value_list = value
                 if all(
                     isinstance(item, dict)
                     and cast(dict[str, Any], item).get("dify_model_identity") == FILE_MODEL_IDENTITY
@@ -1181,7 +1181,7 @@ class Conversation(Base):
             if isinstance(v, File):
                 inputs[k] = v.model_dump()
             elif isinstance(v, list):
-                v_list = cast(list[Any], v)
+                v_list = v
                 if all(isinstance(item, File) for item in v_list):
                     inputs[k] = [item.model_dump() for item in v_list if isinstance(item, File)]
         self._inputs = inputs
@@ -1495,7 +1495,7 @@ class Message(Base):
                     tenant_resolver=tenant_resolver,
                 )
             elif isinstance(value, list):
-                value_list = cast(list[Any], value)
+                value_list = value
                 if all(
                     isinstance(item, dict)
                     and cast(dict[str, Any], item).get("dify_model_identity") == FILE_MODEL_IDENTITY
@@ -1522,7 +1522,7 @@ class Message(Base):
             if isinstance(v, File):
                 inputs[k] = v.model_dump()
             elif isinstance(v, list):
-                v_list = cast(list[Any], v)
+                v_list = v
                 if all(isinstance(item, File) for item in v_list):
                     inputs[k] = [item.model_dump() for item in v_list if isinstance(item, File)]
         self._inputs = inputs

api/models/workflow.py

@@ -1688,7 +1688,7 @@ class WorkflowDraftVariable(Base):
                     tenant_id=tenant_id,
                 )
             case list() if value:
-                value_list = cast(list[Any], value)
+                value_list = value
                 first: Any = value_list[0]
                 if not maybe_file_object(first):
                     return cast(Any, value)
@@ -1742,7 +1742,7 @@ class WorkflowDraftVariable(Base):
                 normalized_file.pop("tenant_id", None)
                 return build_file_from_mapping_without_lookup(file_mapping=normalized_file)
             case list() if value:
-                value_list = cast(list[Any], value)
+                value_list = value
                 first: Any = value_list[0]
                 if not maybe_file_object(first):
                     return cast(Any, value)