From 7869551afd2004dc561534bb940c9b733a3570f1 Mon Sep 17 00:00:00 2001 From: yyh <92089059+lyzno1@users.noreply.github.com> Date: Mon, 9 Mar 2026 09:16:45 +0800 Subject: [PATCH] fix(web): stabilize dayjs timezone tests against DST transitions (#33134) --- .../date-and-time-picker/time-picker/__tests__/index.spec.tsx | 2 +- .../base/date-and-time-picker/utils/__tests__/dayjs.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/app/components/base/date-and-time-picker/time-picker/__tests__/index.spec.tsx b/web/app/components/base/date-and-time-picker/time-picker/__tests__/index.spec.tsx index 81e065c827..a12983f901 100644 --- a/web/app/components/base/date-and-time-picker/time-picker/__tests__/index.spec.tsx +++ b/web/app/components/base/date-and-time-picker/time-picker/__tests__/index.spec.tsx @@ -503,7 +503,7 @@ describe('TimePicker', () => { const emitted = onChange.mock.calls[0][0] expect(isDayjsObject(emitted)).toBe(true) // 10:30 UTC converted to America/New_York (UTC-5 in Jan) = 05:30 - expect(emitted.utcOffset()).toBe(dayjs().tz('America/New_York').utcOffset()) + expect(emitted.utcOffset()).toBe(dayjs.tz('2024-01-01', 'America/New_York').utcOffset()) expect(emitted.hour()).toBe(5) expect(emitted.minute()).toBe(30) }) diff --git a/web/app/components/base/date-and-time-picker/utils/__tests__/dayjs.spec.ts b/web/app/components/base/date-and-time-picker/utils/__tests__/dayjs.spec.ts index e36fecd0b6..9b0a15546f 100644 --- a/web/app/components/base/date-and-time-picker/utils/__tests__/dayjs.spec.ts +++ b/web/app/components/base/date-and-time-picker/utils/__tests__/dayjs.spec.ts @@ -20,7 +20,7 @@ describe('dayjs utilities', () => { const result = toDayjs('07:15 PM', { timezone: tz }) expect(result).toBeDefined() expect(result?.format('HH:mm')).toBe('19:15') - expect(result?.utcOffset()).toBe(getDateWithTimezone({ timezone: tz }).utcOffset()) + expect(result?.utcOffset()).toBe(getDateWithTimezone({ timezone: tz }).startOf('day').utcOffset()) }) it('isDayjsObject detects dayjs instances', () => {