From 7dd507af04943d7eab07b8241c1628a3cbfbbcc1 Mon Sep 17 00:00:00 2001
From: sxxtony <166789813+sxxtony@users.noreply.github.com>
Date: Sun, 12 Apr 2026 22:22:43 -0700
Subject: [PATCH] refactor: migrate SegmentAttachmentBinding to TypeBase
 (#34810)

---
 api/core/rag/docstore/dataset_docstore.py     |  2 +-
 api/models/dataset.py                         | 10 +++++---
 .../rag/docstore/test_dataset_docstore.py     | 24 +++++++++++++++++++
 3 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/api/core/rag/docstore/dataset_docstore.py b/api/core/rag/docstore/dataset_docstore.py
index 40f45953af..8e9ebdd17a 100644
--- a/api/core/rag/docstore/dataset_docstore.py
+++ b/api/core/rag/docstore/dataset_docstore.py
@@ -244,7 +244,7 @@ class DatasetDocumentStore:
         return document_segment
 
     def add_multimodel_documents_binding(self, segment_id: str, multimodel_documents: list[AttachmentDocument] | None):
-        if multimodel_documents:
+        if multimodel_documents and self._document_id is not None:
             for multimodel_document in multimodel_documents:
                 binding = SegmentAttachmentBinding(
                     tenant_id=self._dataset.tenant_id,
diff --git a/api/models/dataset.py b/api/models/dataset.py
index a8ed821c3a..a48afa7ea7 100644
--- a/api/models/dataset.py
+++ b/api/models/dataset.py
@@ -1688,7 +1688,7 @@ class PipelineRecommendedPlugin(TypeBase):
     )
 
 
-class SegmentAttachmentBinding(Base):
+class SegmentAttachmentBinding(TypeBase):
     __tablename__ = "segment_attachment_bindings"
     __table_args__ = (
         sa.PrimaryKeyConstraint("id", name="segment_attachment_binding_pkey"),
@@ -1701,13 +1701,17 @@ class SegmentAttachmentBinding(Base):
         ),
         sa.Index("segment_attachment_binding_attachment_idx", "attachment_id"),
     )
-    id: Mapped[str] = mapped_column(StringUUID, default=lambda: str(uuidv7()))
+    id: Mapped[str] = mapped_column(
+        StringUUID, insert_default=lambda: str(uuidv7()), default_factory=lambda: str(uuidv7()), init=False
+    )
     tenant_id: Mapped[str] = mapped_column(StringUUID, nullable=False)
     dataset_id: Mapped[str] = mapped_column(StringUUID, nullable=False)
     document_id: Mapped[str] = mapped_column(StringUUID, nullable=False)
     segment_id: Mapped[str] = mapped_column(StringUUID, nullable=False)
     attachment_id: Mapped[str] = mapped_column(StringUUID, nullable=False)
-    created_at: Mapped[datetime] = mapped_column(sa.DateTime, nullable=False, server_default=func.current_timestamp())
+    created_at: Mapped[datetime] = mapped_column(
+        sa.DateTime, nullable=False, server_default=func.current_timestamp(), init=False
+    )
 
 
 class DocumentSegmentSummary(Base):
diff --git a/api/tests/unit_tests/core/rag/docstore/test_dataset_docstore.py b/api/tests/unit_tests/core/rag/docstore/test_dataset_docstore.py
index a7b7c1595b..007a76aa66 100644
--- a/api/tests/unit_tests/core/rag/docstore/test_dataset_docstore.py
+++ b/api/tests/unit_tests/core/rag/docstore/test_dataset_docstore.py
@@ -721,6 +721,30 @@ class TestDatasetDocumentStoreMultimodelBinding:
 
             mock_db.session.add.assert_not_called()
 
+    def test_add_multimodel_documents_binding_with_none_document_id(self):
+        """Test that no bindings are added when document_id is None."""
+
+        mock_dataset = MagicMock(spec=Dataset)
+        mock_dataset.id = "test-dataset-id"
+        mock_dataset.tenant_id = "tenant-1"
+
+        mock_attachment = MagicMock(spec=AttachmentDocument)
+        mock_attachment.metadata = {"doc_id": "attachment-1"}
+
+        with patch("core.rag.docstore.dataset_docstore.db") as mock_db:
+            mock_session = MagicMock()
+            mock_db.session = mock_session
+
+            store = DatasetDocumentStore(
+                dataset=mock_dataset,
+                user_id="test-user-id",
+                document_id=None,
+            )
+
+            store.add_multimodel_documents_binding("seg-1", [mock_attachment])
+
+            mock_db.session.add.assert_not_called()
+
 
 class TestDatasetDocumentStoreAddDocumentsUpdateChild:
     """Tests for add_documents when updating existing documents with children."""