opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-05-13 00:33:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: flaky WordExtractor close test in CI (#35652)

Browse Source 
Signed-off-by: kenwoodjw <blackxin55+@gmail.com>
This commit is contained in:
kenwoodjw 2026-04-29 10:27:02 +08:00 committed by fatelei
parent 03df3423fc
commit 84df9d2f01
No known key found for this signature in database
GPG Key ID: 2F91DA05646F4EED
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
api/tests/unit_tests/core/rag/extractor/test_word_extractor.py
View File

@ -1,14 +1,12 @@
"""Primarily used for testing merged cell scenarios""" """Primarily used for testing merged cell scenarios"""
import gc
import io import io
import os import os
import tempfile import tempfile
import warnings
from collections import UserDict from collections import UserDict
from pathlib import Path from pathlib import Path
from types import SimpleNamespace from types import SimpleNamespace
from unittest.mock import AsyncMock, MagicMock from unittest.mock import MagicMock
import pytest import pytest
from docx import Document from docx import Document
@ -377,23 +375,21 @@ def test_close_is_idempotent():
extractor.temp_file.close.assert_called_once() extractor.temp_file.close.assert_called_once()
def test_close_handles_async_close_mock(): async def _async_close() -> None:
return None
def test_close_closes_awaitable_close_result():
extractor = object.__new__(WordExtractor) extractor = object.__new__(WordExtractor)
extractor._closed = False extractor._closed = False
extractor.temp_file = MagicMock() extractor.temp_file = MagicMock()
extractor.temp_file.close = AsyncMock() close_result = _async_close()
extractor.temp_file.close = MagicMock(return_value=close_result)
with warnings.catch_warnings(record=True) as caught: extractor.close()
warnings.simplefilter("always")
extractor.close()
gc.collect()
assert close_result.cr_frame is None
extractor.temp_file.close.assert_called_once() extractor.temp_file.close.assert_called_once()
assert not [
warning
for warning in caught
if issubclass(warning.category, RuntimeWarning) and "AsyncMockMixin._execute_mock_call" in str(warning.message)
]
def test_extract_images_handles_invalid_external_cases(monkeypatch): def test_extract_images_handles_invalid_external_cases(monkeypatch):