opensource/dify
2
0
Fork 0
mirror of https://github.com/langgenius/dify.git synced 2026-06-10 18:24:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore(api): convert BaseTruncator from ABC to Protocol (#37199)

Browse Source
This commit is contained in:
Eric Cao 2026-06-09 10:55:36 +08:00 committed by GitHub
parent 47b58a34ef
commit 8a1c0cf5ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
api/services/variable_truncator.py
View File

@ -1,9 +1,8 @@
from __future__ import annotations
import dataclasses
from abc import ABC, abstractmethod
from collections.abc import Mapping
from typing import Any, overload, override
from typing import Any, Protocol, overload, override
from configs import dify_config
from graphon.file import File
@ -66,14 +65,12 @@ class TruncationResult:
truncated: bool
class BaseTruncator(ABC):
@abstractmethod
def truncate(self, segment: Segment) -> TruncationResult:
pass
class BaseTruncator(Protocol):
"""Protocol for variable truncation strategies."""
@abstractmethod
def truncate_variable_mapping(self, v: Mapping[str, Any]) -> tuple[Mapping[str, Any], bool]:
pass
def truncate(self, segment: Segment) -> TruncationResult: ...
def truncate_variable_mapping(self, v: Mapping[str, Any]) -> tuple[Mapping[str, Any], bool]: ...
class VariableTruncator(BaseTruncator):

22
api/tests/unit_tests/services/test_variable_truncator_additional.py
View File

@ -1,4 +1,3 @@
from collections.abc import Mapping
from typing import Any
import pytest
@ -7,26 +6,7 @@ from graphon.nodes.variable_assigner.common.helpers import UpdatedVariable
from graphon.variables.segments import IntegerSegment, ObjectSegment, StringSegment
from graphon.variables.types import SegmentType
from services import variable_truncator as truncator_module
from services.variable_truncator import BaseTruncator, TruncationResult, VariableTruncator
class _AbstractPassthrough(BaseTruncator):
def truncate(self, segment: Any) -> TruncationResult:
return super().truncate(segment) # type: ignore[misc]
def truncate_variable_mapping(self, v: Mapping[str, Any]) -> tuple[Mapping[str, Any], bool]:
return super().truncate_variable_mapping(v) # type: ignore[misc]
class TestBaseTruncatorContract:
def test_base_truncator_methods_should_execute_abstract_placeholders(self) -> None:
passthrough = _AbstractPassthrough()
truncate_result = passthrough.truncate(StringSegment(value="x"))
mapping_result = passthrough.truncate_variable_mapping({"a": 1})
assert truncate_result is None
assert mapping_result is None
from services.variable_truncator import VariableTruncator
class TestVariableTruncatorAdditionalBehavior: