From 8e8c39a88cc3e5d47b1bf6f8f6acf2e3bdd40142 Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Mon, 18 Mar 2024 15:46:25 +0800
Subject: [PATCH] feat: sys var remove nodeid

---
 .../variable/var-reference-picker.tsx         | 43 ++++++++++++++-----
 1 file changed, 33 insertions(+), 10 deletions(-)

diff --git a/web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx b/web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx
index dbfee3130a..f4a8c88d6e 100644
--- a/web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx
+++ b/web/app/components/workflow/nodes/_base/components/variable/var-reference-picker.tsx
@@ -4,10 +4,11 @@ import React, { useCallback, useEffect, useRef, useState } from 'react'
 import { useTranslation } from 'react-i18next'
 import cn from 'classnames'
 import { isArray } from 'lodash-es'
+import produce from 'immer'
 import VarReferencePopup from './var-reference-popup'
 import { toNodeOutputVars } from './utils'
 import type { ValueSelector, Var } from '@/app/components/workflow/types'
-import { VarType } from '@/app/components/workflow/types'
+import { BlockEnum, VarType } from '@/app/components/workflow/types'
 import { VarBlockIcon } from '@/app/components/workflow/block-icon'
 import { Line3 } from '@/app/components/base/icons/src/public/common'
 import { Variable02 } from '@/app/components/base/icons/src/vender/solid/development'
@@ -39,13 +40,16 @@ type Props = {
   filterVar?: (payload: Var, valueSelector: ValueSelector) => boolean
 }
 
-export const getNodeInfoById = (nodes: any, id: string) => {
+const getNodeInfoById = (nodes: any, id: string) => {
   if (!isArray(nodes))
     return
-
   return nodes.find((node: any) => node.id === id)
 }
 
+const isSystemVar = (valueSelector: ValueSelector) => {
+  return valueSelector[0]?.startsWith('sys.') || valueSelector[1]?.startsWith('sys.')
+}
+
 const VarReferencePicker: FC<Props> = ({
   nodeId,
   width,
@@ -75,15 +79,27 @@ const VarReferencePicker: FC<Props> = ({
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [open])
   const hasValue = !isConstant && value.length > 0
+  const startNode = availableNodes.find((node: any) => {
+    return node.data.type === BlockEnum.Start
+  })
   const outputVarNodeId = hasValue ? value[0] : ''
-  const outputVarNode = hasValue ? getNodeInfoById(availableNodes, outputVarNodeId)?.data : null
+  const outputVarNode = (() => {
+    if (!hasValue || isConstant)
+      return null
+    if (isSystemVar(value as ValueSelector))
+      return startNode?.data
+
+    return getNodeInfoById(availableNodes, outputVarNodeId)?.data
+  })()
   const varName = hasValue ? value[value.length - 1] : ''
 
   const getVarType = () => {
     if (isConstant)
       return 'undefined'
 
-    const targetVar = allOutputVars.find(v => v.nodeId === outputVarNodeId)
+    const targetVarNodeId = isSystemVar(value as ValueSelector) ? startNode?.id : outputVarNodeId
+    const targetVar = allOutputVars.find(v => v.nodeId === targetVarNodeId)
+
     if (!targetVar)
       return 'undefined'
 
@@ -132,6 +148,16 @@ const VarReferencePicker: FC<Props> = ({
     }
   }, [controlFocus])
 
+  const handleVarReferenceChange = useCallback((value: ValueSelector) => {
+    // sys var not passed to backend
+    const newValue = produce(value, (draft) => {
+      if (draft[1] && draft[1].startsWith('sys.'))
+        draft.shift()
+    })
+    onChange(newValue, varKindType)
+    setOpen(false)
+  }, [onChange, varKindType])
+
   const handleStaticChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
     onChange(e.target.value as string, varKindType)
   }, [onChange, varKindType])
@@ -185,7 +211,7 @@ const VarReferencePicker: FC<Props> = ({
                             <div className='p-[1px]'>
                               <VarBlockIcon
                                 className='!text-gray-900'
-                                type={outputVarNode?.type}
+                                type={outputVarNode?.type || BlockEnum.Start}
                               />
                             </div>
                             <div className='mx-0.5 text-xs font-medium text-gray-700'>{outputVarNode?.title}</div>
@@ -211,10 +237,7 @@ const VarReferencePicker: FC<Props> = ({
           {!isConstant && (
             <VarReferencePopup
               vars={outputVars}
-              onChange={(value) => {
-                onChange(value, varKindType)
-                setOpen(false)
-              }}
+              onChange={handleVarReferenceChange}
               itemWidth={width}
             />
           )}