From 8f74e176ca7a8d1609a374c33ecd59039b0a0aca Mon Sep 17 00:00:00 2001 From: FFXN <31929997+FFXN@users.noreply.github.com> Date: Thu, 25 Jun 2026 15:27:16 +0800 Subject: [PATCH] fix: remove redundant snippets permissions (#37921) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- api/services/enterprise/rbac_service.py | 5 ----- .../unit_tests/services/enterprise/test_rbac_service.py | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/api/services/enterprise/rbac_service.py b/api/services/enterprise/rbac_service.py index 1072c7051b0..ec5a539f73a 100644 --- a/api/services/enterprise/rbac_service.py +++ b/api/services/enterprise/rbac_service.py @@ -330,8 +330,6 @@ _LEGACY_WORKSPACE_OWNER_KEYS: list[str] = [ "snippets.management", "tool.manage", "mcp.manage", - "snippets.create_and_modify", - "snippets.management", ] _LEGACY_WORKSPACE_ADMIN_KEYS: list[str] = [ @@ -361,8 +359,6 @@ _LEGACY_WORKSPACE_ADMIN_KEYS: list[str] = [ "snippets.management", "tool.manage", "mcp.manage", - "snippets.create_and_modify", - "snippets.management", ] _LEGACY_WORKSPACE_EDITOR_KEYS: list[str] = [ @@ -378,7 +374,6 @@ _LEGACY_WORKSPACE_EDITOR_KEYS: list[str] = [ "dataset.external.connect", "snippets.create_and_modify", "tool.manage", - "snippets.create_and_modify", "billing.view", "billing.subscription.manage", "billing.manage", diff --git a/api/tests/unit_tests/services/enterprise/test_rbac_service.py b/api/tests/unit_tests/services/enterprise/test_rbac_service.py index ef786c944e1..bb462588851 100644 --- a/api/tests/unit_tests/services/enterprise/test_rbac_service.py +++ b/api/tests/unit_tests/services/enterprise/test_rbac_service.py @@ -621,6 +621,7 @@ class TestMyPermissions: mock_send.assert_not_called() assert out.workspace.permission_keys == workspace_keys + assert len(out.workspace.permission_keys) == len(set(out.workspace.permission_keys)) assert out.app.default_permission_keys == app_keys assert out.dataset.default_permission_keys == dataset_keys assert out.app.overrides == []