From 90ae5e586510bd407454e9ac2ced4b2245d65359 Mon Sep 17 00:00:00 2001 From: Harry Date: Fri, 10 Oct 2025 14:51:52 +0800 Subject: [PATCH] refactor(trigger): enhance update method to use explicit None checks - Updated the `update` method in `SubscriptionBuilderUpdater` to use 'is not None' checks instead of truthy evaluations for better handling of empty values. - This change improves clarity and ensures that empty dictionaries or strings are correctly processed during updates. --- api/core/trigger/entities/entities.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/api/core/trigger/entities/entities.py b/api/core/trigger/entities/entities.py index 3a479d8273..0044b545d7 100644 --- a/api/core/trigger/entities/entities.py +++ b/api/core/trigger/entities/entities.py @@ -242,19 +242,19 @@ class SubscriptionBuilderUpdater(BaseModel): expires_at: int | None = Field(default=None, description="The expires at of the subscription builder") def update(self, subscription_builder: SubscriptionBuilder) -> None: - if self.name: + if self.name is not None: subscription_builder.name = self.name - if self.parameters: + if self.parameters is not None: subscription_builder.parameters = self.parameters - if self.properties: + if self.properties is not None: subscription_builder.properties = self.properties - if self.credentials: + if self.credentials is not None: subscription_builder.credentials = self.credentials - if self.credential_type: + if self.credential_type is not None: subscription_builder.credential_type = self.credential_type - if self.credential_expires_at: + if self.credential_expires_at is not None: subscription_builder.credential_expires_at = self.credential_expires_at - if self.expires_at: + if self.expires_at is not None: subscription_builder.expires_at = self.expires_at