From 9b5e3ba2039e2f5a2c9610e46230e4fd22ebda18 Mon Sep 17 00:00:00 2001 From: L1nSn0w Date: Fri, 8 May 2026 11:09:52 +0800 Subject: [PATCH] refactor(api): drop redundant whitelist filter in _extension_matches The walrus filter was redundant given the early return on empty input: empty whitelist entries normalize to "" and can never match a non-empty input extension, and empty input is already rejected upfront. --- api/factories/file_factory/validation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/factories/file_factory/validation.py b/api/factories/file_factory/validation.py index 86dd06990f..8c4e7ef1d4 100644 --- a/api/factories/file_factory/validation.py +++ b/api/factories/file_factory/validation.py @@ -18,7 +18,7 @@ def _extension_matches(extension: str, whitelist: Iterable[str]) -> bool: normalized = _normalize_extension(extension) if not normalized: return False - return normalized in {ne for e in whitelist if (ne := _normalize_extension(e))} + return normalized in {_normalize_extension(e) for e in whitelist} def is_file_valid_with_config(