From 3fa33b09affab4d746b070a7a8df2427990b5268 Mon Sep 17 00:00:00 2001 From: AkaraChen Date: Thu, 12 Dec 2024 16:42:23 +0800 Subject: [PATCH 1/3] fix: add truncation to document name display and update dataset form checks --- .../common/document-picker/preview-document-picker.tsx | 2 +- web/app/components/datasets/create/step-two/index.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/web/app/components/datasets/common/document-picker/preview-document-picker.tsx b/web/app/components/datasets/common/document-picker/preview-document-picker.tsx index 856e90a28d..fcecf6d887 100644 --- a/web/app/components/datasets/common/document-picker/preview-document-picker.tsx +++ b/web/app/components/datasets/common/document-picker/preview-document-picker.tsx @@ -54,7 +54,7 @@ const PreviewDocumentPicker: FC = ({
- {name || '--'} + {name || '--'}
diff --git a/web/app/components/datasets/create/step-two/index.tsx b/web/app/components/datasets/create/step-two/index.tsx index f006160ef0..f715a50cb9 100644 --- a/web/app/components/datasets/create/step-two/index.tsx +++ b/web/app/components/datasets/create/step-two/index.tsx @@ -584,7 +584,7 @@ const StepTwo = ({
{t('datasetCreation.stepTwo.segmentation')}
- {(!datasetId || [ChuckingMode.text, ChuckingMode.qa].includes(docForm)) + {(!datasetId || [ChuckingMode.text, ChuckingMode.qa].includes(currentDataset!.doc_form)) && } @@ -685,7 +685,7 @@ const StepTwo = ({
} { - (!datasetId || docForm === ChuckingMode.parentChild) + (!datasetId || currentDataset!.doc_form === ChuckingMode.parentChild) && } From 489015bd9ebbe3b2800b4991421ec127b4cccbd5 Mon Sep 17 00:00:00 2001 From: AkaraChen Date: Thu, 12 Dec 2024 16:50:15 +0800 Subject: [PATCH 2/3] fix: update document name display to prevent overflow --- .../datasets/common/document-picker/preview-document-picker.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/app/components/datasets/common/document-picker/preview-document-picker.tsx b/web/app/components/datasets/common/document-picker/preview-document-picker.tsx index fcecf6d887..6d61cc4c69 100644 --- a/web/app/components/datasets/common/document-picker/preview-document-picker.tsx +++ b/web/app/components/datasets/common/document-picker/preview-document-picker.tsx @@ -54,7 +54,7 @@ const PreviewDocumentPicker: FC = ({
- {name || '--'} + {name || '--'}
From 939f7f3e067c89f089b0e66ca65bb98b0c806cb5 Mon Sep 17 00:00:00 2001 From: AkaraChen Date: Thu, 12 Dec 2024 16:56:06 +0800 Subject: [PATCH 3/3] fix: cannot open in upload --- web/app/components/datasets/create/step-two/index.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/web/app/components/datasets/create/step-two/index.tsx b/web/app/components/datasets/create/step-two/index.tsx index f715a50cb9..ed8ee9064d 100644 --- a/web/app/components/datasets/create/step-two/index.tsx +++ b/web/app/components/datasets/create/step-two/index.tsx @@ -591,7 +591,9 @@ const StepTwo = ({ activeHeaderClassName='bg-gradient-to-r from-[#EFF0F9] to-[#F9FAFB]' description={t('datasetCreation.stepTwo.generalTip')} isActive={ - [ChuckingMode.text, ChuckingMode.qa].includes(docForm) + [ChuckingMode.text, ChuckingMode.qa].includes( + datasetId ? currentDataset!.doc_form : docForm, + ) } onSwitched={() => handleChangeDocform(ChuckingMode.text) @@ -692,7 +694,9 @@ const StepTwo = ({ effectImg={OrangeEffect.src} activeHeaderClassName='bg-gradient-to-r from-[#F9F1EE] to-[#F9FAFB]' description={t('datasetCreation.stepTwo.parentChildTip')} - isActive={docForm === ChuckingMode.parentChild} + isActive={ + datasetId ? currentDataset!.doc_form === ChuckingMode.parentChild : docForm === ChuckingMode.parentChild + } onSwitched={() => handleChangeDocform(ChuckingMode.parentChild)} actions={ <>