From ade6dd4b6f48e4e46a87ca12d558229189394fda Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Wed, 18 Dec 2024 14:25:56 +0800
Subject: [PATCH] fix: delimiter not support empty and not escape

---
 web/app/components/datasets/create/step-two/index.tsx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/web/app/components/datasets/create/step-two/index.tsx b/web/app/components/datasets/create/step-two/index.tsx
index 202b256555..c24a0437fd 100644
--- a/web/app/components/datasets/create/step-two/index.tsx
+++ b/web/app/components/datasets/create/step-two/index.tsx
@@ -157,8 +157,8 @@ const StepTwo = ({
   const dataSourceType = isInCreatePage ? inCreatePageDataSourceType : currentDataset?.data_source_type
   const [segmentationType, setSegmentationType] = useState<SegmentType>(SegmentType.CUSTOM)
   const [segmentIdentifier, doSetSegmentIdentifier] = useState(DEFAULT_SEGMENT_IDENTIFIER)
-  const setSegmentIdentifier = useCallback((value: string) => {
-    doSetSegmentIdentifier(value ? escape(value) : DEFAULT_SEGMENT_IDENTIFIER)
+  const setSegmentIdentifier = useCallback((value: string, canEmpty?: boolean) => {
+    doSetSegmentIdentifier(value ? escape(value) : (canEmpty ? '' : DEFAULT_SEGMENT_IDENTIFIER))
   }, [])
   const [maxChunkLength, setMaxChunkLength] = useState(DEFAULT_MAXMIMUM_CHUNK_LENGTH) // default chunk length
   const [limitMaxChunkLength, setLimitMaxChunkLength] = useState(4000)
@@ -612,7 +612,7 @@ const StepTwo = ({
               <div className='flex gap-3'>
                 <DelimiterInput
                   value={segmentIdentifier}
-                  onChange={e => setSegmentIdentifier(e.target.value)}
+                  onChange={e => setSegmentIdentifier(e.target.value, true)}
                 />
                 <MaxLengthInput
                   value={maxChunkLength}
@@ -737,7 +737,7 @@ const StepTwo = ({
                           ...parentChildConfig,
                           parent: {
                             ...parentChildConfig.parent,
-                            delimiter: e.target.value,
+                            delimiter: e.target.value ? escape(e.target.value) : '',
                           },
                         })}
                       />
@@ -782,7 +782,7 @@ const StepTwo = ({
                       ...parentChildConfig,
                       child: {
                         ...parentChildConfig.child,
-                        delimiter: e.target.value,
+                        delimiter: e.target.value ? escape(e.target.value) : '',
                       },
                     })}
                   />