From b1fbaaed95b2e45e6d4b3b8332f962c587f216e4 Mon Sep 17 00:00:00 2001
From: twwu <twwu@dify.ai>
Date: Fri, 25 Apr 2025 18:39:05 +0800
Subject: [PATCH] refactor: Simplify type checks for form field rendering and
 correct comment grammar

---
 .../components/base/form/form-scenarios/base/field.tsx    | 8 ++++----
 web/app/components/base/form/form-scenarios/base/types.ts | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/web/app/components/base/form/form-scenarios/base/field.tsx b/web/app/components/base/form/form-scenarios/base/field.tsx
index cf8bd911d3..40f9cd4c5d 100644
--- a/web/app/components/base/form/form-scenarios/base/field.tsx
+++ b/web/app/components/base/form/form-scenarios/base/field.tsx
@@ -36,7 +36,7 @@ const Field = <T,>({
     if (!isAllConditionsMet)
       return <></>
 
-    if ([BaseVarType.textInput].includes(type)) {
+    if (type === BaseVarType.textInput) {
       return (
         <form.AppField
           name={variable}
@@ -51,7 +51,7 @@ const Field = <T,>({
       )
     }
 
-    if ([BaseVarType.numberInput].includes(type)) {
+    if (type === BaseVarType.numberInput) {
       return (
         <form.AppField
           name={variable}
@@ -68,7 +68,7 @@ const Field = <T,>({
       )
     }
 
-    if ([BaseVarType.checkbox].includes(type)) {
+    if (type === BaseVarType.checkbox) {
       return (
         <form.AppField
           name={variable}
@@ -81,7 +81,7 @@ const Field = <T,>({
       )
     }
 
-    if ([BaseVarType.select].includes(type)) {
+    if (type === BaseVarType.select) {
       return (
         <form.AppField
           name={variable}
diff --git a/web/app/components/base/form/form-scenarios/base/types.ts b/web/app/components/base/form/form-scenarios/base/types.ts
index c756b40894..06b4a93314 100644
--- a/web/app/components/base/form/form-scenarios/base/types.ts
+++ b/web/app/components/base/form/form-scenarios/base/types.ts
@@ -29,7 +29,7 @@ export type BaseConfiguration<T> = {
   maxLength?: number // Max length for text input
   placeholder?: string
   required: boolean
-  showConditions: ShowCondition<T>[] // Show this field only when the all conditions are met
+  showConditions: ShowCondition<T>[] // Show this field only when all conditions are met
   type: BaseVarType
   tooltip?: string // Tooltip for this field
 } & NumberConfiguration & SelectConfiguration