From c0b05db9d77ea9b0a4ebc17db128ee46497c1bc0 Mon Sep 17 00:00:00 2001
From: GareArc <garethcxy@dify.ai>
Date: Wed, 11 Mar 2026 18:09:36 -0700
Subject: [PATCH] test: remove raise_for_status parameter from plugin manager
 test assertions

---
 .../enterprise/test_plugin_manager_service.py | 90 +++++++++++++++++++
 1 file changed, 90 insertions(+)
 create mode 100644 api/tests/unit_tests/services/enterprise/test_plugin_manager_service.py

diff --git a/api/tests/unit_tests/services/enterprise/test_plugin_manager_service.py b/api/tests/unit_tests/services/enterprise/test_plugin_manager_service.py
new file mode 100644
index 0000000000..6ee328ae2c
--- /dev/null
+++ b/api/tests/unit_tests/services/enterprise/test_plugin_manager_service.py
@@ -0,0 +1,90 @@
+"""Unit tests for PluginManagerService.
+
+This module covers the pre-uninstall plugin hook behavior:
+- Successful API call: no exception raised, correct request sent
+- API failure: soft-fail (logs and does not re-raise)
+"""
+
+from unittest.mock import patch
+
+from httpx import HTTPStatusError
+
+from configs import dify_config
+from services.enterprise.plugin_manager_service import (
+    PluginManagerService,
+    PreUninstallPluginRequest,
+)
+
+
+class TestTryPreUninstallPlugin:
+    def test_try_pre_uninstall_plugin_success(self):
+        body = PreUninstallPluginRequest(
+            tenant_id="tenant-123",
+            plugin_unique_identifier="com.example.my_plugin",
+        )
+
+        with patch(
+            "services.enterprise.plugin_manager_service.EnterprisePluginManagerRequest.send_request"
+        ) as mock_send_request:
+            mock_send_request.return_value = {}
+
+            PluginManagerService.try_pre_uninstall_plugin(body)
+
+            mock_send_request.assert_called_once_with(
+                "POST",
+                "/pre-uninstall-plugin",
+                json={"tenant_id": "tenant-123", "plugin_unique_identifier": "com.example.my_plugin"},
+                timeout=dify_config.ENTERPRISE_REQUEST_TIMEOUT,
+            )
+
+    def test_try_pre_uninstall_plugin_http_error_soft_fails(self):
+        body = PreUninstallPluginRequest(
+            tenant_id="tenant-456",
+            plugin_unique_identifier="com.example.other_plugin",
+        )
+
+        with (
+            patch(
+                "services.enterprise.plugin_manager_service.EnterprisePluginManagerRequest.send_request"
+            ) as mock_send_request,
+            patch("services.enterprise.plugin_manager_service.logger") as mock_logger,
+        ):
+            mock_send_request.side_effect = HTTPStatusError(
+                "502 Bad Gateway",
+                request=None,
+                response=None,
+            )
+
+            PluginManagerService.try_pre_uninstall_plugin(body)
+
+            mock_send_request.assert_called_once_with(
+                "POST",
+                "/pre-uninstall-plugin",
+                json={"tenant_id": "tenant-456", "plugin_unique_identifier": "com.example.other_plugin"},
+                timeout=dify_config.ENTERPRISE_REQUEST_TIMEOUT,
+            )
+            mock_logger.exception.assert_called_once()
+
+    def test_try_pre_uninstall_plugin_generic_exception_soft_fails(self):
+        body = PreUninstallPluginRequest(
+            tenant_id="tenant-789",
+            plugin_unique_identifier="com.example.failing_plugin",
+        )
+
+        with (
+            patch(
+                "services.enterprise.plugin_manager_service.EnterprisePluginManagerRequest.send_request"
+            ) as mock_send_request,
+            patch("services.enterprise.plugin_manager_service.logger") as mock_logger,
+        ):
+            mock_send_request.side_effect = ConnectionError("network unreachable")
+
+            PluginManagerService.try_pre_uninstall_plugin(body)
+
+            mock_send_request.assert_called_once_with(
+                "POST",
+                "/pre-uninstall-plugin",
+                json={"tenant_id": "tenant-789", "plugin_unique_identifier": "com.example.failing_plugin"},
+                timeout=dify_config.ENTERPRISE_REQUEST_TIMEOUT,
+            )
+            mock_logger.exception.assert_called_once()