From c2f78412668d2dc7d8e5e04168f05a52b997ca1e Mon Sep 17 00:00:00 2001
From: Siew's Capital Jarvis <brayden.stanley.0127@gmail.com>
Date: Thu, 11 Jun 2026 16:21:18 +0800
Subject: [PATCH] test: remove dead helper causing invalid tool provider
 constructor args (#33124)

Co-authored-by: Brayden Siew <brayden_siew@outlook.com>
Co-authored-by: -LAN- <laipz8200@outlook.com>
---
 .../tools/test_tools_transform_service.py     | 71 +------------------
 1 file changed, 1 insertion(+), 70 deletions(-)

diff --git a/api/tests/test_containers_integration_tests/services/tools/test_tools_transform_service.py b/api/tests/test_containers_integration_tests/services/tools/test_tools_transform_service.py
index a174f5d69f5..2cf6bac2b65 100644
--- a/api/tests/test_containers_integration_tests/services/tools/test_tools_transform_service.py
+++ b/api/tests/test_containers_integration_tests/services/tools/test_tools_transform_service.py
@@ -20,7 +20,7 @@ from core.tools.entities.tool_entities import (
     ToolProviderIdentity,
     ToolProviderType,
 )
-from models.tools import ApiToolProvider, BuiltinToolProvider, MCPToolProvider, WorkflowToolProvider
+from models.tools import ApiToolProvider, WorkflowToolProvider
 from services.tools.tools_transform_service import ToolTransformService
 
 
@@ -39,75 +39,6 @@ class TestToolTransformService:
                     "dify_config": mock_dify_config,
                 }
 
-    def _create_test_tool_provider(
-        self, db_session_with_containers: Session, mock_external_service_dependencies, provider_type="api"
-    ):
-        """
-        Helper method to create a test tool provider for testing.
-
-        Args:
-            db_session_with_containers: Database session from testcontainers infrastructure
-            mock_external_service_dependencies: Mock dependencies
-            provider_type: Type of provider to create
-
-        Returns:
-            Tool provider instance
-        """
-        fake = Faker()
-
-        if provider_type == "api":
-            provider = ApiToolProvider(
-                name=fake.company(),
-                description=fake.text(max_nb_chars=100),
-                icon='{"background": "#FF6B6B", "content": "🔧"}',
-                tenant_id="test_tenant_id",
-                user_id="test_user_id",
-                credentials_str='{"auth_type": "api_key_header", "api_key": "test_key"}',
-                schema="{}",
-                schema_type_str=ApiProviderSchemaType.OPENAPI,
-                tools_str="[]",
-            )
-        elif provider_type == "builtin":
-            provider = BuiltinToolProvider(
-                name=fake.company(),
-                tenant_id="test_tenant_id",
-                user_id="test_user_id",
-                provider="test_provider",
-                credential_type="api_key",
-                encrypted_credentials='{"api_key": "test_key"}',
-            )
-        elif provider_type == "workflow":
-            provider = WorkflowToolProvider(
-                name=fake.company(),
-                description=fake.text(max_nb_chars=100),
-                icon='{"background": "#FF6B6B", "content": "🔧"}',
-                tenant_id="test_tenant_id",
-                user_id="test_user_id",
-                app_id="test_workflow_id",
-                label="Test Workflow",
-                version="1.0.0",
-                parameter_configuration="[]",
-            )
-        elif provider_type == "mcp":
-            provider = MCPToolProvider(
-                name=fake.company(),
-                icon='{"background": "#FF6B6B", "content": "🔧"}',
-                tenant_id="test_tenant_id",
-                user_id="test_user_id",
-                server_url="https://mcp.example.com",
-                server_url_hash="test_server_url_hash",
-                server_identifier="test_server",
-                tools='[{"name": "test_tool", "description": "Test tool"}]',
-                authed=True,
-            )
-        else:
-            raise ValueError(f"Unknown provider type: {provider_type}")
-
-        db_session_with_containers.add(provider)
-        db_session_with_containers.commit()
-
-        return provider
-
     def test_get_plugin_icon_url_success(self, db_session_with_containers: Session, mock_external_service_dependencies):
         """
         Test successful plugin icon URL generation.