From c4e6ed1aa2eb6a0d8f551840eca9a8a9c118e2e4 Mon Sep 17 00:00:00 2001
From: takatost <takatost@gmail.com>
Date: Thu, 21 Mar 2024 17:12:52 +0800
Subject: [PATCH] optimize codes

---
 api/services/account_service.py                         | 4 ++--
 api/services/workflow_service.py                        | 2 --
 api/tasks/mail_invite_member_task.py                    | 2 +-
 api/tests/unit_tests/core/workflow/nodes/test_answer.py | 3 ---
 4 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/api/services/account_service.py b/api/services/account_service.py
index 103af7f79c..8692deed27 100644
--- a/api/services/account_service.py
+++ b/api/services/account_service.py
@@ -178,7 +178,7 @@ class AccountService:
 
     @staticmethod
     def close_account(account: Account) -> None:
-        """todo: Close account"""
+        """Close account"""
         account.status = AccountStatus.CLOSED.value
         db.session.commit()
 
@@ -443,7 +443,7 @@ class RegisterService:
 
             db.session.commit()
         except Exception as e:
-            db.session.rollback()  # todo: do not work
+            db.session.rollback()
             logging.error(f'Register failed: {e}')
             raise AccountRegisterError(f'Registration failed: {e}') from e
 
diff --git a/api/services/workflow_service.py b/api/services/workflow_service.py
index ecbe9721a9..191b7cf6d5 100644
--- a/api/services/workflow_service.py
+++ b/api/services/workflow_service.py
@@ -118,8 +118,6 @@ class WorkflowService:
         if not draft_workflow:
             raise ValueError('No valid workflow found.')
 
-        # TODO check if the workflow structure is valid
-
         # create new workflow
         workflow = Workflow(
             tenant_id=app_model.tenant_id,
diff --git a/api/tasks/mail_invite_member_task.py b/api/tasks/mail_invite_member_task.py
index 7d134fc34f..3341f5f4b8 100644
--- a/api/tasks/mail_invite_member_task.py
+++ b/api/tasks/mail_invite_member_task.py
@@ -27,7 +27,7 @@ def send_invite_member_mail_task(language: str, to: str, token: str, inviter_nam
                              fg='green'))
     start_at = time.perf_counter()
 
-    # TODO send invite member mail using different languages
+    # send invite member mail using different languages
     try:
         url = f'{current_app.config.get("CONSOLE_WEB_URL")}/activate?token={token}'
         if language == 'zh-Hans':
diff --git a/api/tests/unit_tests/core/workflow/nodes/test_answer.py b/api/tests/unit_tests/core/workflow/nodes/test_answer.py
index bad5d42a43..038fda9dac 100644
--- a/api/tests/unit_tests/core/workflow/nodes/test_answer.py
+++ b/api/tests/unit_tests/core/workflow/nodes/test_answer.py
@@ -51,6 +51,3 @@ def test_execute_answer():
 
     assert result.status == WorkflowNodeExecutionStatus.SUCCEEDED
     assert result.outputs['answer'] == "Today's weather is sunny\nYou are a helpful AI.\n{{img}}\nFin."
-
-
-# TODO test files