From d226a5bdd302b3f4a90ef66e95ceacec000f6ce6 Mon Sep 17 00:00:00 2001 From: "yunlu.wen" Date: Tue, 21 Apr 2026 17:27:14 +0800 Subject: [PATCH] rollback unnecessary changes --- api/libs/broadcast_channel/channel.py | 1 - api/libs/broadcast_channel/redis/streams_channel.py | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api/libs/broadcast_channel/channel.py b/api/libs/broadcast_channel/channel.py index 660f977cfc..8eeac37232 100644 --- a/api/libs/broadcast_channel/channel.py +++ b/api/libs/broadcast_channel/channel.py @@ -93,7 +93,6 @@ class Subscriber(Protocol): @abstractmethod def subscribe(self) -> Subscription: - """Create a new subscription.""" pass diff --git a/api/libs/broadcast_channel/redis/streams_channel.py b/api/libs/broadcast_channel/redis/streams_channel.py index 7c5ce794d6..0218170cc1 100644 --- a/api/libs/broadcast_channel/redis/streams_channel.py +++ b/api/libs/broadcast_channel/redis/streams_channel.py @@ -88,7 +88,8 @@ class _StreamsSubscription(Subscription): # since this method runs in a dedicated thread, acquiring `_lock` inside this method won't cause # deadlock. - # `"0"` replays all retained entries; `"$"` tails only new messages. + # Setting initial last id to `$` to signal redis that we only want new messages. + # # ref: https://redis.io/docs/latest/commands/xread/#the-special--id last_id = "$" try: