From dd64af728f2ef96786dce232629e161ef5b64c45 Mon Sep 17 00:00:00 2001
From: hjlarry <hjlarry@163.com>
Date: Thu, 7 Aug 2025 14:29:23 +0800
Subject: [PATCH] refactor the cursors component

---
 .../workflow-app/components/workflow-main.tsx | 60 +--------------
 .../collaboration/components/user-cursors.tsx | 75 +++++++++++++++++++
 2 files changed, 78 insertions(+), 57 deletions(-)
 create mode 100644 web/app/components/workflow/collaboration/components/user-cursors.tsx

diff --git a/web/app/components/workflow-app/components/workflow-main.tsx b/web/app/components/workflow-app/components/workflow-main.tsx
index f6704026b5..15ef50a3a0 100644
--- a/web/app/components/workflow-app/components/workflow-main.tsx
+++ b/web/app/components/workflow-app/components/workflow-main.tsx
@@ -11,6 +11,8 @@ import { FILE_EXTS } from '@/app/components/base/prompt-editor/constants'
 import { WorkflowWithInnerContext } from '@/app/components/workflow'
 import type { WorkflowProps } from '@/app/components/workflow'
 import WorkflowChildren from './workflow-children'
+import UserCursors from '@/app/components/workflow/collaboration/components/user-cursors'
+
 import {
   useConfigsMap,
   useInspectVarsCrud,
@@ -229,63 +231,7 @@ const WorkflowMain = ({
       >
         <WorkflowChildren />
       </WorkflowWithInnerContext>
-
-      {/* Render other users' cursors on top */}
-      {Object.entries(cursors || {}).map(([userId, cursor]) => {
-        if (userId === myUserId)
-          return null
-
-        const userInfo = onlineUsers.find(user => user.user_id === userId)
-        const userName = userInfo?.username || `User ${userId.slice(-4)}`
-
-        const getUserColor = (id: string) => {
-          const colors = ['#3B82F6', '#EF4444', '#10B981', '#F59E0B', '#8B5CF6', '#EC4899', '#06B6D4', '#84CC16']
-          const hash = id.split('').reduce((a, b) => {
-            a = ((a << 5) - a) + b.charCodeAt(0)
-            return a & a
-          }, 0)
-          return colors[Math.abs(hash) % colors.length]
-        }
-
-        const userColor = getUserColor(userId)
-
-        return (
-          <div
-            key={userId}
-            className="pointer-events-none absolute z-[10000] -translate-x-0.5 -translate-y-0.5 transition-all duration-150 ease-out"
-            style={{
-              left: cursor.x,
-              top: cursor.y,
-            }}
-          >
-            <svg
-              width="20"
-              height="20"
-              viewBox="0 0 20 20"
-              fill="none"
-              xmlns="http://www.w3.org/2000/svg"
-              className="drop-shadow-md"
-            >
-              <path
-                d="M3 3L16 8L9 10L7 17L3 3Z"
-                fill={userColor}
-                stroke="white"
-                strokeWidth="1"
-                strokeLinejoin="round"
-              />
-            </svg>
-
-            <div
-              className="absolute -top-0.5 left-[18px] max-w-[120px] overflow-hidden text-ellipsis whitespace-nowrap rounded px-1.5 py-0.5 text-[11px] font-medium text-white shadow-sm"
-              style={{
-                backgroundColor: userColor,
-              }}
-            >
-              {userName}
-            </div>
-          </div>
-        )
-      })}
+      <UserCursors cursors={cursors} myUserId={myUserId} onlineUsers={onlineUsers} />
     </div>
   )
 }
diff --git a/web/app/components/workflow/collaboration/components/user-cursors.tsx b/web/app/components/workflow/collaboration/components/user-cursors.tsx
new file mode 100644
index 0000000000..799972b0b8
--- /dev/null
+++ b/web/app/components/workflow/collaboration/components/user-cursors.tsx
@@ -0,0 +1,75 @@
+import type { FC } from 'react'
+import type { CursorPosition, OnlineUser } from '@/app/components/workflow/collaboration/types'
+
+type UserCursorsProps = {
+  cursors: Record<string, CursorPosition>
+  myUserId: string | null
+  onlineUsers: OnlineUser[]
+}
+
+const getUserColor = (id: string) => {
+  const colors = ['#3B82F6', '#EF4444', '#10B981', '#F59E0B', '#8B5CF6', '#EC4899', '#06B6D4', '#84CC16']
+  const hash = id.split('').reduce((a, b) => {
+    a = ((a << 5) - a) + b.charCodeAt(0)
+    return a & a
+  }, 0)
+  return colors[Math.abs(hash) % colors.length]
+}
+
+const UserCursors: FC<UserCursorsProps> = ({
+  cursors,
+  myUserId,
+  onlineUsers,
+}) => {
+  return (
+    <>
+      {Object.entries(cursors || {}).map(([userId, cursor]) => {
+        if (userId === myUserId)
+          return null
+
+        const userInfo = onlineUsers.find(user => user.user_id === userId)
+        const userName = userInfo?.username || `User ${userId.slice(-4)}`
+        const userColor = getUserColor(userId)
+
+        return (
+          <div
+            key={userId}
+            className="pointer-events-none absolute z-[10000] -translate-x-0.5 -translate-y-0.5 transition-all duration-150 ease-out"
+            style={{
+              left: cursor.x,
+              top: cursor.y,
+            }}
+          >
+            <svg
+              width="20"
+              height="20"
+              viewBox="0 0 20 20"
+              fill="none"
+              xmlns="http://www.w3.org/2000/svg"
+              className="drop-shadow-md"
+            >
+              <path
+                d="M3 3L16 8L9 10L7 17L3 3Z"
+                fill={userColor}
+                stroke="white"
+                strokeWidth="1"
+                strokeLinejoin="round"
+              />
+            </svg>
+
+            <div
+              className="absolute -top-0.5 left-[18px] max-w-[120px] overflow-hidden text-ellipsis whitespace-nowrap rounded px-1.5 py-0.5 text-[11px] font-medium text-white shadow-sm"
+              style={{
+                backgroundColor: userColor,
+              }}
+            >
+              {userName}
+            </div>
+          </div>
+        )
+      })}
+    </>
+  )
+}
+
+export default UserCursors