From f4ecc293f9bf242a7da97e80148b04c626b9b4af Mon Sep 17 00:00:00 2001
From: lyzno1 <yuanyouhuilyz@gmail.com>
Date: Tue, 9 Sep 2025 22:53:13 +0800
Subject: [PATCH] fix(dataset-sidebar): eliminate icon flickering during
 expand/collapse

- Unified layout structure for both expand/collapse states
- Single AppIcon component with dynamic size props instead of conditional rendering
- Fixed container structure prevents DOM rebuilding and flickering
- Adjusted spacing for collapsed state more button positioning
---
 .../app-sidebar/dataset-info/index.tsx        | 82 +++++++++----------
 1 file changed, 41 insertions(+), 41 deletions(-)

diff --git a/web/app/components/app-sidebar/dataset-info/index.tsx b/web/app/components/app-sidebar/dataset-info/index.tsx
index f85e3880b2..44b0baa72b 100644
--- a/web/app/components/app-sidebar/dataset-info/index.tsx
+++ b/web/app/components/app-sidebar/dataset-info/index.tsx
@@ -35,35 +35,47 @@ const DatasetInfo: FC<DatasetInfoProps> = ({
   return (
     <div className={cn('relative flex flex-col', expand ? '' : 'p-1')}>
       {expand && (
-        <>
-          <Effect className='-left-5 top-[-22px] opacity-15' />
-          <div className='flex flex-col gap-y-2 p-2'>
-            <div className='flex items-center justify-between'>
-              <AppIcon
-                size='medium'
-                iconType={iconInfo.icon_type}
-                icon={iconInfo.icon}
-                background={iconInfo.icon_background}
-                imageUrl={iconInfo.icon_url}
-              />
+        <Effect className='-left-5 top-[-22px] opacity-15' />
+      )}
+
+      <div className='flex flex-col gap-2 p-2'>
+        <div className='flex items-center gap-1'>
+          <div className={cn(!expand && '-ml-1')}>
+            <AppIcon
+              size={expand ? 'large' : 'small'}
+              iconType={iconInfo.icon_type}
+              icon={iconInfo.icon}
+              background={iconInfo.icon_background}
+              imageUrl={iconInfo.icon_url}
+            />
+          </div>
+          {expand && (
+            <div className='ml-auto'>
               <Dropdown expand />
             </div>
-            <div className='flex flex-col gap-y-1 pb-0.5'>
-              <div
-                className='system-md-semibold truncate text-text-secondary'
-                title={dataset.name}
-              >
-                {dataset.name}
-              </div>
-              <div className='system-2xs-medium-uppercase text-text-tertiary'>
-                {isExternalProvider && t('dataset.externalTag')}
-                {!isExternalProvider && isPipelinePublished && dataset.doc_form && dataset.indexing_technique && (
-                  <div className='flex items-center gap-x-2'>
-                    <span>{t(`dataset.chunkingMode.${DOC_FORM_TEXT[dataset.doc_form]}`)}</span>
-                    <span>{formatIndexingTechniqueAndMethod(dataset.indexing_technique, dataset.retrieval_model_dict?.search_method)}</span>
-                  </div>
-                )}
-              </div>
+          )}
+        </div>
+        {!expand && (
+          <div className='-mb-2 -mt-1 flex items-center justify-center'>
+            <Dropdown expand={false} />
+          </div>
+        )}
+        {expand && (
+          <div className='flex flex-col gap-y-1 pb-0.5'>
+            <div
+              className='system-md-semibold truncate text-text-secondary'
+              title={dataset.name}
+            >
+              {dataset.name}
+            </div>
+            <div className='system-2xs-medium-uppercase text-text-tertiary'>
+              {isExternalProvider && t('dataset.externalTag')}
+              {!isExternalProvider && isPipelinePublished && dataset.doc_form && dataset.indexing_technique && (
+                <div className='flex items-center gap-x-2'>
+                  <span>{t(`dataset.chunkingMode.${DOC_FORM_TEXT[dataset.doc_form]}`)}</span>
+                  <span>{formatIndexingTechniqueAndMethod(dataset.indexing_technique, dataset.retrieval_model_dict?.search_method)}</span>
+                </div>
+              )}
             </div>
             {!!dataset.description && (
               <p className='system-xs-regular line-clamp-3 text-text-tertiary first-letter:capitalize'>
@@ -71,20 +83,8 @@ const DatasetInfo: FC<DatasetInfoProps> = ({
               </p>
             )}
           </div>
-        </>
-      )}
-      {!expand && (
-        <div className='flex flex-col items-center gap-y-1'>
-          <AppIcon
-            size='medium'
-            iconType={iconInfo.icon_type}
-            icon={iconInfo.icon}
-            background={iconInfo.icon_background}
-            imageUrl={iconInfo.icon_url}
-          />
-          <Dropdown expand={false} />
-        </div>
-      )}
+        )}
+      </div>
     </div>
   )
 }