refactor(api): remove unnecessary type: ignore in summary_index_service (#24494) (#37423)

This commit is contained in:
Manan Bansal 2026-06-15 06:21:44 +05:30 committed by GitHub
parent 06d9b01a8d
commit fbfbbda245
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -123,7 +123,7 @@ class SummaryIndexService:
# Update existing record
existing_summary.summary_content = summary_content
existing_summary.status = status
existing_summary.error = None # type: ignore[assignment] # Clear any previous errors
existing_summary.error = None # Clear any previous errors
# Re-enable if it was disabled
if not existing_summary.enabled:
existing_summary.enabled = True
@ -583,7 +583,7 @@ class SummaryIndexService:
if existing_summary:
# Update existing record
existing_summary.status = status
existing_summary.error = None # type: ignore[assignment] # Clear any previous errors
existing_summary.error = None # Clear any previous errors
if not existing_summary.enabled:
existing_summary.enabled = True
existing_summary.disabled_at = None
@ -685,7 +685,7 @@ class SummaryIndexService:
# Update status to "generating"
summary_record_in_session.status = SummaryStatus.GENERATING
summary_record_in_session.error = None # type: ignore[assignment]
summary_record_in_session.error = None
session.add(summary_record_in_session)
# Don't flush here - wait until after vectorization succeeds
@ -1127,7 +1127,7 @@ class SummaryIndexService:
# Update summary content
summary_record.summary_content = summary_content
summary_record.status = SummaryStatus.GENERATING
summary_record.error = None # type: ignore[assignment] # Clear any previous errors
summary_record.error = None # Clear any previous errors
session.add(summary_record)
# Flush to ensure summary_content is saved before vectorize_summary queries it
session.flush()