yyh
beeb07bc70
refactor(web): simplify avatar composition api
2026-03-25 13:53:54 +08:00
yyh
1a2baa431e
refactor(web): compose avatar fallbacks from primitives
2026-03-25 13:47:59 +08:00
yyh
720c950f9e
refactor(web): remove tooltip-plus and migrate to ui tooltip
2026-03-25 13:35:43 +08:00
yyh
612d90ac6f
fix: remove portal-to-follow-elem-plus shim
2026-03-24 22:18:30 +08:00
Novice
499d237b7e
fix: pass all CI quality checks - ESLint, TypeScript, basedpyright, pyrefly, lint-imports
...
Frontend:
- Migrate deprecated imports: modal→dialog, toast→ui/toast, tooltip→tooltip-plus,
portal-to-follow-elem→portal-to-follow-elem-plus, select→ui/select, confirm→alert-dialog
- Replace next/* with @/next/* wrapper modules
- Convert TypeScript enums to const objects (erasable-syntax-only)
- Replace all `any` types with `unknown` or specific types in workflow types
- Fix unused vars, react-hooks-extra, react-refresh/only-export-components
- Extract InteractionMode to separate module, tool-block commands to commands.ts
Backend:
- Fix pyrefly errors: type narrowing, null guards, getattr patterns
- Remove unused TYPE_CHECKING imports in LLM node
- Add ignore_imports entries to .importlinter for dify_graph boundary violations
Made-with: Cursor
2026-03-24 10:54:58 +08:00
Novice
a28f22e59d
fix: resolve import errors and test failures after segment 4 merge
...
- Update BaseNodeData import path to dify_graph.entities.base_node_data
- Change NodeType.COMMAND/FILE_UPLOAD to BuiltinNodeTypes constants
- Fix system_oauth_encryption -> system_encryption rename in commands
- Remove tests for deleted agent runner modules
- Fix Avatar: named import + string size API in collaboration files
- Add missing skill feature deps: @monaco-editor/react, react-arborist,
@tanstack/react-virtual
- Fix frontend test mocks: add useUserProfile, useLeaderRestoreListener,
next/navigation mock, and nodeOutputVars to expected payload
Made-with: Cursor
2026-03-23 13:59:09 +08:00
yyh
db0c527ce8
Merge remote-tracking branch 'origin/main' into feat/support-agent-sandbox
2026-02-09 18:43:04 +08:00
hjlarry
511df81201
fix web style
2026-01-18 13:40:12 +08:00
hjlarry
fc291e4ca2
Merge remote-tracking branch 'myori/main' into feat/collaboration2
2026-01-17 10:22:41 +08:00
hjlarry
bd597497e7
prevent comment thread pinch
2025-11-27 15:37:46 +08:00
hjlarry
2f60288d86
fix: resize workflow canvas cause incorrect comment position
2025-11-05 14:08:21 +08:00
lyzno1
e6730f7164
fix: dropdown menu border
2025-10-13 13:15:54 +08:00
lyzno1
c571185a91
fix: extract @mention highlighting from content in real-time to persist after edit
2025-10-13 13:03:55 +08:00
lyzno1
325c1cfa41
fix: prevent Save button flash by maintaining loading state until edit closes
2025-10-13 12:56:18 +08:00
lyzno1
b33a97ea5b
style: update comment thread UI with design specs
...
- Fix edit bubble: keep avatar visible and match ThreadMessage layout
- Update edit container: rounded-xl, p-1, shadow-md, backdrop-blur
- Add keyboard shortcut icons (Cmd+Enter) to Save button
- Fix hover background: full-width with -mx-4 negative margin technique
- Apply design tokens consistently across components
2025-10-13 12:42:41 +08:00
lyzno1
44fe71e4db
fix: ensure comment thread always scrolls to bottom on first render
2025-10-12 13:27:42 +08:00
lyzno1
0ac32188c5
feat: implement comprehensive focus management for comment thread
...
- Add forwardRef support to MentionInput to expose textarea ref
- Auto-focus reply input when thread opens (100ms delay)
- Restore focus after reply submission and edit operations
- Add Esc key handler to close thread with smart guards
- Enhance accessibility with ARIA attributes (dialog, modal, labelledby)
- Improve keyboard navigation and user experience
Implements P0-P3 priorities following WCAG 2.1 AA accessibility standards
2025-10-12 13:21:57 +08:00
lyzno1
239a11855a
fix: prevent dropdown from closing when showing inline delete confirmation
...
Use pre-rendering strategy with CSS visibility control instead of conditional rendering to avoid race condition between React state update and PortalToFollowElem's click-outside detection.
2025-10-11 20:21:52 +08:00
lyzno1
0632557d91
feat: use inline delete confirm for comment reply deletion(second time)
2025-10-11 18:37:41 +08:00
lyzno1
44be7d4c51
Revert "feat: use inline delete confirm for comment reply deletion"
...
This reverts commit a077a3f609 .
2025-10-11 18:24:15 +08:00
lyzno1
a077a3f609
feat: use inline delete confirm for comment reply deletion
2025-10-11 18:06:31 +08:00
lyzno1
79beb25530
feat: add tooltips and improve delete button styling in CommentThread
...
- Add compact tooltips to Delete, Resolve, Previous, and Next buttons
- Change delete button hover to red background and text
- Use existing i18n translations for tooltip content
2025-10-11 15:22:37 +08:00
lyzno1
b47b228164
fix: align dropdown menu styles with design specs in CommentThread
...
- Update background to blur variant with backdrop filter
- Change border radius from lg to xl (12px)
- Add rounded corners to menu items to prevent hover overflow
2025-10-11 15:10:57 +08:00
lyzno1
be91db14d9
fix: add hover effect to first message in CommentThread
...
Wrap the root comment message with the same hover container as replies to ensure consistent hover behavior across all messages.
2025-10-11 15:08:27 +08:00
lyzno1
9d93fda471
refactor: separate loading states for comment operations
...
Separate loading states to distinguish between different operations:
- activeCommentDetailLoading: loading comment details, delete/resolve operations
- replySubmitting: sending new replies
- replyUpdating: editing existing replies
Changes:
- Add replySubmitting and replyUpdating states to comment store
- Restore full-screen loading overlay for comment detail loading
- Use inline spinner (RiLoader2Line) in send/save buttons for reply operations
- Update loading state usage in handleCommentReply and handleCommentReplyUpdate
- Pass separated loading states from workflow index to CommentThread component
Benefits:
- UI clarity: different loading states have appropriate visual feedback
- Better UX: users can still navigate while sending replies
- Clear separation of concerns: each operation has its own loading state
2025-10-11 14:34:35 +08:00
lyzno1
00dab7ca5f
feat: improve mention input loading state and prevent button flash on submit
2025-10-11 14:20:37 +08:00
lyzno1
a4add403fb
Fix MentionInput layout and improve comment hover styling
2025-10-11 14:20:37 +08:00
lyzno1
376a084aca
refactor: use PortalToFollowElem for dropdown with scroll handling
...
- Replace inline dropdown with PortalToFollowElem to prevent container overflow
- Use z-[100] for dropdown to ensure proper stacking
- Remove redundant outside click handler (handled by PortalToFollowElem)
- Add scroll event listener to auto-close dropdown when scrolling
- Dropdown now renders via portal outside message container
2025-10-11 14:20:36 +08:00
lyzno1
d1f42d47fe
fix: improve dropdown menu hover and positioning
2025-10-11 14:20:36 +08:00
lyzno1
64b8fd87ad
fix: improve dropdown menu positioning and z-index
2025-10-11 14:20:36 +08:00
lyzno1
364be48248
feat: add smooth scroll to comment thread
2025-10-11 14:20:36 +08:00
hjlarry
a40e11cb3e
only can edit own replies
2025-10-09 17:02:39 +08:00
hjlarry
2310145937
comment reply auto scoll down to bottom
2025-10-09 15:50:23 +08:00
hjlarry
6ce65de2cd
fix merged main issues
2025-10-04 21:11:59 +08:00
hjlarry
37ecd4a0bc
fix @ input problem
2025-10-04 13:39:00 +08:00
hjlarry
86a9a51952
add comment preview
2025-09-24 12:54:54 +08:00
hjlarry
4188c9a1dd
fix dark theme
2025-09-24 10:08:33 +08:00
hjlarry
d5dd73cacf
add i18n for comment
2025-09-23 16:19:04 +08:00
hjlarry
e0df12c212
fix mentioned names color
2025-09-23 11:24:17 +08:00
hjlarry
eb448d9bb8
fix avatar background color
2025-09-23 11:09:02 +08:00
hjlarry
81c6e52401
Merge remote-tracking branch 'origin/p254' into p284
2025-09-18 15:14:55 +08:00
hjlarry
4653981b6b
not display more icon when in edit mode
2025-09-17 20:45:54 +08:00
hjlarry
ea17f41b5b
refactor reply code
2025-09-17 20:29:23 +08:00
hjlarry
29178d8adf
can edit and delete a reply
2025-09-17 17:44:09 +08:00
hjlarry
72debcb228
refactor mention input
2025-09-17 16:28:47 +08:00
hjlarry
72737dabc7
fix at can't click bug
2025-09-17 14:50:05 +08:00
hjlarry
f6e5cb4381
improve comment detail
2025-09-17 14:34:36 +08:00
hjlarry
ffad3b5fb1
comment detail window fix height
2025-09-17 13:45:56 +08:00
hjlarry
cba9fc3020
add comment reply
2025-09-17 12:50:42 +08:00
hjlarry
e776accaf3
add top operation buttons of comment detail
2025-09-17 10:45:15 +08:00