mirror of
https://github.com/langgenius/dify.git
synced 2026-05-10 14:14:17 +08:00
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: jyong <718720800@qq.com> Co-authored-by: Yansong Zhang <916125788@qq.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: hj24 <mambahj24@gmail.com> Co-authored-by: hj24 <huangjian@dify.ai> Co-authored-by: Joel <iamjoel007@gmail.com> Co-authored-by: Stephen Zhou <38493346+hyoban@users.noreply.github.com> Co-authored-by: CodingOnStar <hanxujiang@dify.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: 非法操作 <hjlarry@163.com> Co-authored-by: Ayush Baluni <73417844+aayushbaluni@users.noreply.github.com> Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com> Co-authored-by: jimcody1995 <jjimcody@gmail.com> Co-authored-by: James <63717587+jamesrayammons@users.noreply.github.com> Co-authored-by: Yunlu Wen <yunlu.wen@dify.ai> Co-authored-by: Stephen Zhou <hi@hyoban.cc> Co-authored-by: Coding On Star <447357187@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jerryzai <jerryzh8710@protonmail.com> Co-authored-by: NVIDIAN <speedy.hpc@hotmail.com> Co-authored-by: ai-hpc <ai-hpc@users.noreply.github.com> Co-authored-by: Asuka Minato <i@asukaminato.eu.org> Co-authored-by: Junghwan <70629228+shaun0927@users.noreply.github.com> Co-authored-by: HeYinKazune <70251095+HeYin-OS@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: yyh <yuanyouhuilyz@gmail.com> Co-authored-by: Jingyi <jingyi.qi@dify.ai> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: sxxtony <166789813+sxxtony@users.noreply.github.com>
184 lines
5.5 KiB
TypeScript
184 lines
5.5 KiB
TypeScript
import { act, renderHook } from '@testing-library/react'
|
|
import { useAsyncWindowOpen } from './use-async-window-open'
|
|
|
|
describe('useAsyncWindowOpen', () => {
|
|
const originalOpen = window.open
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
afterAll(() => {
|
|
window.open = originalOpen
|
|
})
|
|
|
|
it('opens immediate url synchronously, clears opener, without calling async getter', async () => {
|
|
const mockWindow: any = { opener: 'should-clear' }
|
|
const openSpy = vi.fn(() => mockWindow)
|
|
window.open = openSpy
|
|
const getUrl = vi.fn()
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(getUrl, {
|
|
immediateUrl: 'https://example.com',
|
|
target: '_blank',
|
|
features: undefined,
|
|
})
|
|
})
|
|
|
|
expect(openSpy).toHaveBeenCalledWith('https://example.com', '_blank', 'noopener,noreferrer')
|
|
expect(getUrl).not.toHaveBeenCalled()
|
|
expect(mockWindow.opener).toBeNull()
|
|
})
|
|
|
|
it('appends noopener,noreferrer when immediate open passes custom features', async () => {
|
|
const mockWindow: any = { opener: 'should-clear' }
|
|
const openSpy = vi.fn(() => mockWindow)
|
|
window.open = openSpy
|
|
const getUrl = vi.fn()
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(getUrl, {
|
|
immediateUrl: 'https://example.com',
|
|
target: '_blank',
|
|
features: 'width=500',
|
|
})
|
|
})
|
|
|
|
expect(openSpy).toHaveBeenCalledWith('https://example.com', '_blank', 'width=500,noopener,noreferrer')
|
|
expect(getUrl).not.toHaveBeenCalled()
|
|
expect(mockWindow.opener).toBeNull()
|
|
})
|
|
|
|
it('reports error when immediate window fails to open', async () => {
|
|
const openSpy = vi.fn(() => null)
|
|
window.open = openSpy
|
|
const getUrl = vi.fn()
|
|
const onError = vi.fn()
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(getUrl, {
|
|
immediateUrl: 'https://example.com',
|
|
target: '_blank',
|
|
onError,
|
|
})
|
|
})
|
|
|
|
expect(onError).toHaveBeenCalled()
|
|
const errArg = onError.mock.calls[0]![0] as Error
|
|
expect(errArg.message).toBe('Failed to open new window')
|
|
expect(getUrl).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('sets opener to null and redirects when async url resolves', async () => {
|
|
const close = vi.fn()
|
|
const mockWindow: any = {
|
|
location: { href: '' },
|
|
close,
|
|
opener: 'should-be-cleared',
|
|
}
|
|
const openSpy = vi.fn(() => mockWindow)
|
|
window.open = openSpy
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(async () => 'https://example.com/path')
|
|
})
|
|
|
|
expect(openSpy).toHaveBeenCalledWith('about:blank', '_blank', undefined)
|
|
expect(mockWindow.opener).toBeNull()
|
|
expect(mockWindow.location.href).toBe('https://example.com/path')
|
|
expect(close).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('closes placeholder and forwards error when async getter throws', async () => {
|
|
const close = vi.fn()
|
|
const mockWindow: any = {
|
|
location: { href: '' },
|
|
close,
|
|
opener: null,
|
|
}
|
|
const openSpy = vi.fn(() => mockWindow)
|
|
window.open = openSpy
|
|
const onError = vi.fn()
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
const error = new Error('fetch failed')
|
|
await act(async () => {
|
|
await result.current(async () => {
|
|
throw error
|
|
}, { onError })
|
|
})
|
|
|
|
expect(close).toHaveBeenCalled()
|
|
expect(onError).toHaveBeenCalledWith(error)
|
|
expect(mockWindow.location.href).toBe('')
|
|
})
|
|
|
|
it('preserves custom features as-is for async open', async () => {
|
|
const close = vi.fn()
|
|
const mockWindow: any = {
|
|
location: { href: '' },
|
|
close,
|
|
opener: 'should-be-cleared',
|
|
}
|
|
const openSpy = vi.fn(() => mockWindow)
|
|
window.open = openSpy
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(async () => 'https://example.com/path', {
|
|
target: '_blank',
|
|
features: 'width=500',
|
|
})
|
|
})
|
|
|
|
expect(openSpy).toHaveBeenCalledWith('about:blank', '_blank', 'width=500')
|
|
expect(mockWindow.opener).toBeNull()
|
|
expect(mockWindow.location.href).toBe('https://example.com/path')
|
|
expect(close).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('closes placeholder and reports when no url is returned', async () => {
|
|
const close = vi.fn()
|
|
const mockWindow: any = {
|
|
location: { href: '' },
|
|
close,
|
|
opener: null,
|
|
}
|
|
const openSpy = vi.fn(() => mockWindow)
|
|
window.open = openSpy
|
|
const onError = vi.fn()
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(async () => null, { onError })
|
|
})
|
|
|
|
expect(close).toHaveBeenCalled()
|
|
expect(onError).toHaveBeenCalled()
|
|
const errArg = onError.mock.calls[0]![0] as Error
|
|
expect(errArg.message).toBe('No url resolved for new window')
|
|
})
|
|
|
|
it('reports failure when window.open returns null', async () => {
|
|
const openSpy = vi.fn(() => null)
|
|
window.open = openSpy
|
|
const getUrl = vi.fn()
|
|
const onError = vi.fn()
|
|
const { result } = renderHook(() => useAsyncWindowOpen())
|
|
|
|
await act(async () => {
|
|
await result.current(getUrl, { onError })
|
|
})
|
|
|
|
expect(onError).toHaveBeenCalled()
|
|
const errArg = onError.mock.calls[0]![0] as Error
|
|
expect(errArg.message).toBe('Failed to open new window')
|
|
expect(getUrl).not.toHaveBeenCalled()
|
|
})
|
|
})
|