mirror of https://github.com/langgenius/dify.git
4a9b74f86b
**Problem:**
The telemetry system had unnecessary abstraction layers and bad practices
from the last 3 commits introducing the gateway implementation:
- TelemetryFacade class wrapper around emit() function
- String literals instead of SignalType enum
- Dictionary mapping enum → string instead of enum → enum
- Unnecessary ENTERPRISE_TELEMETRY_GATEWAY_ENABLED feature flag
- Duplicate guard checks scattered across files
- Non-thread-safe TelemetryGateway singleton pattern
- Missing guard in ops_trace_task.py causing RuntimeError spam
**Solution:**
1. Deleted TelemetryFacade - replaced with thin emit() function in core/telemetry/__init__.py
2. Added SignalType enum ('trace' | 'metric_log') to enterprise/telemetry/contracts.py
3. Replaced CASE_TO_TRACE_TASK_NAME dict with CASE_TO_TRACE_TASK: dict[TelemetryCase, TraceTaskName]
4. Deleted is_gateway_enabled() and _emit_legacy() - using existing ENTERPRISE_ENABLED + ENTERPRISE_TELEMETRY_ENABLED instead
5. Extracted _should_drop_ee_only_event() helper to eliminate duplicate checks
6. Moved TelemetryGateway singleton to ext_enterprise_telemetry.py:
- Init once in init_app() for thread-safety
- Access via get_gateway() function
7. Re-added guard to ops_trace_task.py to prevent RuntimeError when EE=OFF but CE tracing enabled
8. Updated 11 caller files to import 'emit as telemetry_emit' instead of 'TelemetryFacade'
**Result:**
- 322 net lines deleted (533 removed, 211 added)
- All 91 tests pass
- Thread-safe singleton pattern
- Cleaner API surface: from TelemetryFacade.emit() to telemetry_emit()
- Proper enum usage throughout
- No RuntimeError spam in EE=OFF + CE=ON scenario
|
||
|---|---|---|
| .. | ||
| logstore | ||
| otel | ||
| storage | ||
| __init__.py | ||
| ext_app_metrics.py | ||
| ext_blueprints.py | ||
| ext_celery.py | ||
| ext_code_based_extension.py | ||
| ext_commands.py | ||
| ext_compress.py | ||
| ext_database.py | ||
| ext_enterprise_telemetry.py | ||
| ext_fastopenapi.py | ||
| ext_forward_refs.py | ||
| ext_hosting_provider.py | ||
| ext_import_modules.py | ||
| ext_logging.py | ||
| ext_login.py | ||
| ext_logstore.py | ||
| ext_mail.py | ||
| ext_migrate.py | ||
| ext_orjson.py | ||
| ext_otel.py | ||
| ext_proxy_fix.py | ||
| ext_redis.py | ||
| ext_request_logging.py | ||
| ext_sentry.py | ||
| ext_session_factory.py | ||
| ext_set_secretkey.py | ||
| ext_storage.py | ||
| ext_timezone.py | ||
| ext_warnings.py | ||