mirror of
https://github.com/langgenius/dify.git
synced 2026-05-09 12:59:18 +08:00
8a62c1d915
Type and lint pass over the openapi controllers, auth pipeline, and
oauth bearer/device-flow plumbing. Down from 36 pyright errors and 16
ruff errors to 0/0; 93 openapi unit tests pass.
Logic fixes:
- libs/oauth_bearer.py: drop private-naming on the friend-API methods
consumed by _VariantResolver (cache_get / cache_set_positive /
cache_set_negative / hard_expire / session_factory). They were always
cross-class accessors — leading underscore was misleading. Add public
registry property on BearerAuthenticator. _hard_expire row_id widened
to UUID | str (matches the StringUUID column type).
- libs/oauth_bearer.py: type validate_bearer / bearer_feature_required
with ParamSpec / PEP-695 so wrapped routes preserve their signature.
- libs/rate_limit.py: same — typed rate_limit decorator.
- services/oauth_device_flow.py: mint_oauth_token / _upsert accept
Session | scoped_session (Flask-SQLAlchemy proxy). Guard row-is-None
after upsert.
- controllers/openapi/{chat,completion,workflow}_messages.py: tuple-vs-
Mapping shape narrowing on AppGenerateService.generate return —
production returns Mapping, tests mock as (body, status). Validate
through Pydantic Response model in both shapes.
- controllers/openapi/oauth_device.py: replace flask_restx.reqparse (banned)
with Pydantic Request/Query models — DeviceCodeRequest, DevicePollRequest,
DeviceLookupQuery, DeviceMutateRequest. Two PEP-695 generic helpers
(_validate_json / _validate_query) translate ValidationError to BadRequest.
- controllers/openapi/auth/strategies.py: Protocol param-name match
(subject_type), Optional narrowing on app/tenant/account_id/subject_email.
- controllers/openapi/auth/steps.py: subject_type-is-None guard before
mounter dispatch.
- core/app/apps/workflow/generate_task_pipeline.py + models/workflow.py:
add WorkflowAppLogCreatedFrom.OPENAPI + matching match-case branch.
Fixes match-exhaustiveness and possibly-unbound created_from.
- libs/device_flow_security.py: pyright ignore on flask after_request
hook (registered by the framework, pyright sees as unused).
- services/oauth_device_flow.py: rename Exceptions to *Error suffix
(StateNotFoundError / InvalidTransitionError / UserCodeExhaustedError);
same for libs/oauth_bearer.py (InvalidBearerError / TokenExpiredError).
Update all callers across openapi controllers.
- controllers/openapi/{oauth_device,oauth_device_sso}.py +
services/oauth_device_flow.py: switch logger.error in except blocks
to logger.exception (TRY400) — keeps the traceback for ops.
- configs/feature/__init__.py: OPENAPI_KNOWN_CLIENT_IDS computed_field
needs an @property alongside for pyright to see it as a value, not a
method. Matches the existing line-451 pattern.
Plus ruff format + import-sort across the openapi tree (pure formatting).
|
||
|---|---|---|
| .. | ||
| logstore | ||
| otel | ||
| storage | ||
| __init__.py | ||
| ext_app_metrics.py | ||
| ext_blueprints.py | ||
| ext_celery.py | ||
| ext_code_based_extension.py | ||
| ext_commands.py | ||
| ext_compress.py | ||
| ext_database.py | ||
| ext_enterprise_telemetry.py | ||
| ext_fastopenapi.py | ||
| ext_forward_refs.py | ||
| ext_hosting_provider.py | ||
| ext_import_modules.py | ||
| ext_logging.py | ||
| ext_login.py | ||
| ext_logstore.py | ||
| ext_mail.py | ||
| ext_migrate.py | ||
| ext_oauth_bearer.py | ||
| ext_orjson.py | ||
| ext_otel.py | ||
| ext_proxy_fix.py | ||
| ext_redis.py | ||
| ext_request_logging.py | ||
| ext_sentry.py | ||
| ext_session_factory.py | ||
| ext_set_secretkey.py | ||
| ext_socketio.py | ||
| ext_storage.py | ||
| ext_timezone.py | ||
| ext_warnings.py | ||
| redis_names.py | ||