opensource/mateclaw
2
0
Fork 0
mirror of https://gitee.com/mateos/mateclaw.git synced 2026-09-13 03:13:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(skill): persist version on patch and rescan synchronously after edit/patch (#129)

Browse Source
This commit is contained in:
matevip 2026-05-15 15:12:07 +08:00
parent c20c066cbc
commit 1d1a818513
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
mateclaw-server/src/main/java/vip/mate/tool/builtin/SkillManageTool.java
View File

@ -7,6 +7,7 @@ import lombok.extern.slf4j.Slf4j;
import org.springframework.ai.tool.annotation.Tool;
import org.springframework.stereotype.Component;
import vip.mate.skill.model.SkillEntity;
import vip.mate.skill.runtime.SkillRuntimeService;
import vip.mate.skill.runtime.SkillSecurityService;
import vip.mate.skill.runtime.SkillValidationResult;
import vip.mate.skill.service.SkillService;
@ -37,6 +38,7 @@ public class SkillManageTool {
private final SkillService skillService;
private final SkillSecurityService securityService;
private final SkillWorkspaceManager workspaceManager;
private final SkillRuntimeService runtimeService;
/** Skill 名称格式：小写字母/数字/连字符/下划线/点，首字符必须是字母或数字 */
private static final Pattern NAME_PATTERN = Pattern.compile("^[a-z0-9][a-z0-9._-]{0,63}$");
@ -211,6 +213,8 @@ public class SkillManageTool {
log.warn("[SkillManage] Workspace export failed for '{}': {}", name, e.getMessage());
}
rescanQuietly(existing);
log.info("[SkillManage] Agent edited skill: name={}, contentLen={}", name, content.length());
return "Skill '" + name + "' updated successfully (security scan: PASSED).";
} catch (Exception e) {
@ -280,6 +284,7 @@ public class SkillManageTool {
try {
existing.setSkillContent(patchedContent);
existing.setDescription(extractDescription(patchedContent));
existing.setVersion(extractVersion(patchedContent));
existing.setSecurityScanStatus("PASSED");
skillService.updateSkill(existing);
@ -289,6 +294,8 @@ public class SkillManageTool {
log.warn("[SkillManage] Workspace export failed for '{}': {}", name, e.getMessage());
}
rescanQuietly(existing);
log.info("[SkillManage] Agent patched skill: name={}", name);
return "Skill '" + name + "' patched successfully (security scan: PASSED).";
} catch (Exception e) {
@ -357,6 +364,22 @@ public class SkillManageTool {
}
}
/**
* Synchronously re-run the resolver pipeline for the modified skill so
* the active-skills cache and any manifest-projected columns are
* coherent before this tool call returns. Without this, callers race
* the debounced 500ms workspace-event refresh and may observe stale
* state (e.g. the skill detail page showing the previous version).
*/
private void rescanQuietly(SkillEntity skill) {
if (skill == null || runtimeService == null) return;
try {
runtimeService.rescanSingle(skill);
} catch (Exception e) {
log.warn("[SkillManage] Post-write rescan failed for '{}': {}", skill.getName(), e.getMessage());
}
}
/** 从 YAML frontmatter 提取 description */
private String extractDescription(String content) {
String fm = extractFrontmatterValue(content, "description");