opensource/mateclaw
2
0
Fork 0
mirror of https://gitee.com/mateos/mateclaw.git synced 2026-09-13 11:13:43 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

test(trigger): await async dispatch in ChannelMessageTriggerTest

Browse Source 
Decoupling the channel-message event bridge onto an @Async listener means the
downstream workflow run is produced off the event-publishing thread. The test
read the run table synchronously right after publishEvent, racing the listener
— the positive cases failed and the negative cases passed for the wrong reason.
Poll briefly for the run (positive) / give the listener time then assert none
(negative) so the test reflects the async dispatch semantics.
This commit is contained in:
matevip 2026-06-09 10:00:15 +08:00
parent fcc2dd5ccf
commit 3209868274
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
mateclaw-server/src/test/java/vip/mate/trigger/ChannelMessageTriggerTest.java
View File

@ -81,8 +81,7 @@ class ChannelMessageTriggerTest {
publisher.publishEvent(new ChannelMessageReceivedEvent(
workspace, "feishu", "msg-1", "alice", "Alice", "chat-1", "hello"));
List<WorkflowRunEntity> runs = runMapper.selectList(
new LambdaQueryWrapper<WorkflowRunEntity>().eq(WorkflowRunEntity::getWorkflowId, downstream));
List<WorkflowRunEntity> runs = awaitRuns(downstream);
assertEquals(1, runs.size(), "channel_message envelope should have triggered exactly one run");
assertEquals("succeeded", runs.get(0).getState());
assertTrue(runs.get(0).getTriggeredBy() != null
@ -116,8 +115,7 @@ class ChannelMessageTriggerTest {
publisher.publishEvent(new ChannelMessageReceivedEvent(
workspace, "feishu", "msg-2", "bob", "Bob", "chat-2", "hello"));
List<WorkflowRunEntity> runs = runMapper.selectList(
new LambdaQueryWrapper<WorkflowRunEntity>().eq(WorkflowRunEntity::getWorkflowId, downstream));
List<WorkflowRunEntity> runs = awaitNoRuns(downstream);
assertTrue(runs.isEmpty(),
"channelType mismatch should leave the trigger dormant");
}
@ -148,8 +146,7 @@ class ChannelMessageTriggerTest {
publisher.publishEvent(new ChannelMessageReceivedEvent(
workspace, "feishu", "msg-3", "alice", "Alice", "chat-3", "Place an Order, please"));
List<WorkflowRunEntity> runs = runMapper.selectList(
new LambdaQueryWrapper<WorkflowRunEntity>().eq(WorkflowRunEntity::getWorkflowId, downstream));
List<WorkflowRunEntity> runs = awaitRuns(downstream);
assertEquals(1, runs.size(),
"content_match should fire when the substring is present in the message");
}
@ -178,9 +175,28 @@ class ChannelMessageTriggerTest {
publisher.publishEvent(new ChannelMessageReceivedEvent(
workspace, "feishu", "msg-4", "alice", "Alice", "chat-4", "completely unrelated text"));
List<WorkflowRunEntity> runs = runMapper.selectList(
new LambdaQueryWrapper<WorkflowRunEntity>().eq(WorkflowRunEntity::getWorkflowId, downstream));
List<WorkflowRunEntity> runs = awaitNoRuns(downstream);
assertTrue(runs.isEmpty(),
"missing substring should leave the content_match trigger dormant");
}
// The channel-message event bridge dispatches on an @Async listener, so the
// downstream run is produced off the event-publishing thread. Poll briefly
// for it instead of reading immediately (which would race the listener).
private List<WorkflowRunEntity> awaitRuns(long workflowId) {
var q = new LambdaQueryWrapper<WorkflowRunEntity>().eq(WorkflowRunEntity::getWorkflowId, workflowId);
for (int i = 0; i < 50; i++) {
List<WorkflowRunEntity> runs = runMapper.selectList(q);
if (!runs.isEmpty()) return runs;
try { Thread.sleep(100); } catch (InterruptedException e) { Thread.currentThread().interrupt(); break; }
}
return runMapper.selectList(q);
}
// Give the @Async listener time to run, then confirm it produced nothing.
private List<WorkflowRunEntity> awaitNoRuns(long workflowId) {
try { Thread.sleep(1000); } catch (InterruptedException e) { Thread.currentThread().interrupt(); }
return runMapper.selectList(
new LambdaQueryWrapper<WorkflowRunEntity>().eq(WorkflowRunEntity::getWorkflowId, workflowId));
}
}